From: Wolfram Sang <w.sang@pengutronix.de>
To: Arnaud Patard <arnaud.patard@rtp-net.org>
Cc: linux-mmc@vger.kernel.org, "Eric Bénard" <eric@eukrea.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH V2 0/5] sdhci-esdhc-imx: use gpio for write protection and card detection
Date: Tue, 22 Feb 2011 16:08:35 +0100 [thread overview]
Message-ID: <20110222150835.GI2755@pengutronix.de> (raw)
In-Reply-To: <87wrks5dgo.fsf@lebrac.rtp-net.org>
[-- Attachment #1: Type: text/plain, Size: 1076 bytes --]
On Tue, Feb 22, 2011 at 03:52:07PM +0100, Arnaud Patard wrote:
> Has this been tested on imx51 ? By default (even after applying your
> patches), the sdhci has quirk SDHCI_QUIRK_BROKEN_CARD_DETECTION set, so
> we're polling.
Ouch, thanks for that. I missed to delete the above quirk from
sdhci_esdhc_imx_pdata. Can you give another try removing it?
- | SDHCI_QUIRK_BROKEN_CARD_DETECTION,
That should prevent polling. Fixed here already. Will wait for Eric's
tests and send a v3 then.
> I've been wondering if it was a good idea to configure for everyone sdhc
> host card detect pin as gpio 1 1 or gpio 1 8 on imx51, which would mean
> no more polling. What do you think ? Would it be working or it's just a
> stupid idea ?
MX51 won't need platform data. The pins can be routed to the controller,
like efika-mx51 does (judging from the source and documentation).
Regards,
Wolfram
--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: w.sang@pengutronix.de (Wolfram Sang)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V2 0/5] sdhci-esdhc-imx: use gpio for write protection and card detection
Date: Tue, 22 Feb 2011 16:08:35 +0100 [thread overview]
Message-ID: <20110222150835.GI2755@pengutronix.de> (raw)
In-Reply-To: <87wrks5dgo.fsf@lebrac.rtp-net.org>
On Tue, Feb 22, 2011 at 03:52:07PM +0100, Arnaud Patard wrote:
> Has this been tested on imx51 ? By default (even after applying your
> patches), the sdhci has quirk SDHCI_QUIRK_BROKEN_CARD_DETECTION set, so
> we're polling.
Ouch, thanks for that. I missed to delete the above quirk from
sdhci_esdhc_imx_pdata. Can you give another try removing it?
- | SDHCI_QUIRK_BROKEN_CARD_DETECTION,
That should prevent polling. Fixed here already. Will wait for Eric's
tests and send a v3 then.
> I've been wondering if it was a good idea to configure for everyone sdhc
> host card detect pin as gpio 1 1 or gpio 1 8 on imx51, which would mean
> no more polling. What do you think ? Would it be working or it's just a
> stupid idea ?
MX51 won't need platform data. The pins can be routed to the controller,
like efika-mx51 does (judging from the source and documentation).
Regards,
Wolfram
--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20110222/4df3eb02/attachment.sig>
next prev parent reply other threads:[~2011-02-22 15:08 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-22 12:58 [PATCH V2 0/5] sdhci-esdhc-imx: use gpio for write protection and card detection Wolfram Sang
2011-02-22 12:58 ` Wolfram Sang
2011-02-22 12:58 ` [PATCH 1/5] mmc: sdhci-esdhc-imx: add support for write protect on custom GPIO Wolfram Sang
2011-02-22 12:58 ` Wolfram Sang
2011-02-22 12:58 ` [PATCH 2/5] mmc: sdhci-esdhc: broken card detection is not a default quirk Wolfram Sang
2011-02-22 12:58 ` Wolfram Sang
2011-02-22 12:58 ` [PATCH 3/5] mmc: sdhci-esdhc-imx: add card detect on custom GPIO Wolfram Sang
2011-02-22 12:58 ` Wolfram Sang
2011-02-22 12:58 ` [PATCH 4/5] arm: mach-mx3: pcm043: add write-protect and card-detect for SD1 Wolfram Sang
2011-02-22 12:58 ` Wolfram Sang
2011-02-22 19:26 ` Fabio Estevam
2011-02-22 19:26 ` Fabio Estevam
2011-02-22 19:55 ` Wolfram Sang
2011-02-22 19:55 ` Wolfram Sang
2011-02-22 12:58 ` [PATCH 5/5] arm: mach-mx3: use IMX_GPIO_NR instead of hard-coded values Wolfram Sang
2011-02-22 12:58 ` Wolfram Sang
2011-02-22 13:30 ` Lothar Waßmann
2011-02-22 13:30 ` Lothar Waßmann
2011-02-22 19:56 ` Wolfram Sang
2011-02-22 19:56 ` Wolfram Sang
2011-02-22 14:52 ` [PATCH V2 0/5] sdhci-esdhc-imx: use gpio for write protection and card detection Arnaud Patard
2011-02-22 14:52 ` Arnaud Patard (Rtp)
2011-02-22 15:08 ` Wolfram Sang [this message]
2011-02-22 15:08 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110222150835.GI2755@pengutronix.de \
--to=w.sang@pengutronix.de \
--cc=arnaud.patard@rtp-net.org \
--cc=eric@eukrea.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mmc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.