From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: adharmap@codeaurora.org
Cc: davidb@codeaurora.org, "David S. Miller" <davem@davemloft.net>,
Andrew Morton <akpm@linux-foundation.org>,
Bryan Huntsman <bryanh@codeaurora.org>,
Daniel Walker <dwalker@fifo99.com>,
David Collins <collinsd@codeaurora.org>,
Grant Likely <grant.likely@secretlab.ca>,
Greg Kroah-Hartman <gregkh@suse.de>,
Joe Perches <joe@perches.com>,
Russell King <linux@arm.linux.org.uk>,
Samuel Ortiz <sameo@linux.intel.com>,
Stepan Moskovchenko <stepanm@codeaurora.org>,
Linus Walleij <linux.walleij@sterricsson.com>,
linux-arm-kernel@lists.infradead.org,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [Qualcomm PM8921 MFD 1/6] mfd: pm8921: Add PMIC 8921 core driver
Date: Wed, 2 Mar 2011 22:28:51 +0000 [thread overview]
Message-ID: <20110302222850.GA32325@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1299104001-5240-2-git-send-email-adharmap@codeaurora.org>
On Wed, Mar 02, 2011 at 02:13:16PM -0800, adharmap@codeaurora.org wrote:
> +config MFD_PM8XXX
> + tristate "Support for Qualcomm PM8xxx subdevices"
> + help
> + This option enables the usage of various Qualcomm PMIC 8xxx subdevice
> + drivers. This is required in order to use generic PM8xxx subdevice
> + drivers. Selecting with option will result in PM8xxx subdevice
> + drivers being compiled by default.
As this is selected by the driver it shouldn't have any help text -
there's no point in users seeing the option since it's useless by
itself. If we get enough to make an option useful either a menu or
dependencies from the individual MFDs would be a better option.
> +static int __devinit pm8921_add_subdevices(const struct pm8921_platform_data
> + *pdata,
> + struct pm8921 *pmic)
> +{
> + return 0;
> +}
This looks suspicious.
> +static int __init pm8921_init(void)
> +{
> + return platform_driver_register(&pm8921_driver);
> +}
> +postcore_initcall(pm8921_init);
Typically subsys_initcall() has been used.
WARNING: multiple messages have this Message-ID (diff)
From: broonie@opensource.wolfsonmicro.com (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [Qualcomm PM8921 MFD 1/6] mfd: pm8921: Add PMIC 8921 core driver
Date: Wed, 2 Mar 2011 22:28:51 +0000 [thread overview]
Message-ID: <20110302222850.GA32325@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1299104001-5240-2-git-send-email-adharmap@codeaurora.org>
On Wed, Mar 02, 2011 at 02:13:16PM -0800, adharmap at codeaurora.org wrote:
> +config MFD_PM8XXX
> + tristate "Support for Qualcomm PM8xxx subdevices"
> + help
> + This option enables the usage of various Qualcomm PMIC 8xxx subdevice
> + drivers. This is required in order to use generic PM8xxx subdevice
> + drivers. Selecting with option will result in PM8xxx subdevice
> + drivers being compiled by default.
As this is selected by the driver it shouldn't have any help text -
there's no point in users seeing the option since it's useless by
itself. If we get enough to make an option useful either a menu or
dependencies from the individual MFDs would be a better option.
> +static int __devinit pm8921_add_subdevices(const struct pm8921_platform_data
> + *pdata,
> + struct pm8921 *pmic)
> +{
> + return 0;
> +}
This looks suspicious.
> +static int __init pm8921_init(void)
> +{
> + return platform_driver_register(&pm8921_driver);
> +}
> +postcore_initcall(pm8921_init);
Typically subsys_initcall() has been used.
next prev parent reply other threads:[~2011-03-02 22:28 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-02 22:13 [Qualcomm PM8921 MFD 0/6] *** SUBJECT HERE *** adharmap
2011-03-02 22:13 ` adharmap at codeaurora.org
2011-03-02 22:13 ` [Qualcomm PM8921 MFD 1/6] mfd: pm8921: Add PMIC 8921 core driver adharmap
2011-03-02 22:13 ` adharmap at codeaurora.org
2011-03-02 22:28 ` Mark Brown [this message]
2011-03-02 22:28 ` Mark Brown
2011-03-03 3:38 ` Abhijeet Dharmapurikar
2011-03-03 3:38 ` Abhijeet Dharmapurikar
2011-03-02 22:13 ` [Qualcomm PM8921 MFD 2/6] mfd: pm8xxx: Add irq support adharmap
2011-03-02 22:13 ` adharmap at codeaurora.org
2011-03-02 22:46 ` Mark Brown
2011-03-02 22:46 ` Mark Brown
2011-03-03 4:38 ` Abhijeet Dharmapurikar
2011-03-03 4:38 ` Abhijeet Dharmapurikar
2011-03-03 15:22 ` Mark Brown
2011-03-03 15:22 ` Mark Brown
2011-03-03 22:55 ` Abhijeet Dharmapurikar
2011-03-03 22:55 ` Abhijeet Dharmapurikar
2011-03-04 11:12 ` Mark Brown
2011-03-04 11:12 ` Mark Brown
2011-03-02 22:13 ` [Qualcomm PM8921 MFD 3/6] gpio: pm8xxx-gpio: Add pm8xxx gpio driver adharmap
2011-03-02 22:13 ` adharmap at codeaurora.org
2011-07-08 15:44 ` Greg KH
2011-07-08 15:44 ` Greg KH
2011-07-08 17:23 ` Abhijeet Dharmapurikar
2011-07-08 17:23 ` Abhijeet Dharmapurikar
2011-03-02 22:13 ` [Qualcomm PM8921 MFD 4/6] mfd: pm8xxx-mpp: Add pm8xxx MPP driver adharmap
2011-03-02 22:13 ` adharmap at codeaurora.org
2011-07-08 14:57 ` Greg KH
2011-07-08 14:57 ` Greg KH
2011-03-02 22:13 ` [Qualcomm PM8921 MFD 5/6] MAINTAINERS: Add pmic8921, pmic8xxx subdevices maintainers adharmap
2011-03-02 22:13 ` adharmap at codeaurora.org
2011-03-02 22:50 ` Joe Perches
2011-03-02 22:50 ` Joe Perches
2011-03-03 4:41 ` Abhijeet Dharmapurikar
2011-03-03 4:41 ` Abhijeet Dharmapurikar
2011-03-02 22:13 ` [Qualcomm PM8921 MFD 6/6] msm: board-8960: Add support for pm8921 adharmap
2011-03-02 22:13 ` adharmap at codeaurora.org
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110302222850.GA32325@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=adharmap@codeaurora.org \
--cc=akpm@linux-foundation.org \
--cc=bryanh@codeaurora.org \
--cc=collinsd@codeaurora.org \
--cc=davem@davemloft.net \
--cc=davidb@codeaurora.org \
--cc=dwalker@fifo99.com \
--cc=grant.likely@secretlab.ca \
--cc=gregkh@suse.de \
--cc=joe@perches.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux.walleij@sterricsson.com \
--cc=linux@arm.linux.org.uk \
--cc=sameo@linux.intel.com \
--cc=stepanm@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.