From: Abhijeet Dharmapurikar <adharmap@codeaurora.org>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: davidb@codeaurora.org, "David S. Miller" <davem@davemloft.net>,
Andrew Morton <akpm@linux-foundation.org>,
Bryan Huntsman <bryanh@codeaurora.org>,
Daniel Walker <dwalker@fifo99.com>,
David Collins <collinsd@codeaurora.org>,
Grant Likely <grant.likely@secretlab.ca>,
Greg Kroah-Hartman <gregkh@suse.de>,
Joe Perches <joe@perches.com>,
Russell King <linux@arm.linux.org.uk>,
Samuel Ortiz <sameo@linux.intel.com>,
Stepan Moskovchenko <stepanm@codeaurora.org>,
Linus Walleij <linux.walleij@sterricsson.com>,
linux-arm-kernel@lists.infradead.org,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [Qualcomm PM8921 MFD 2/6] mfd: pm8xxx: Add irq support
Date: Thu, 03 Mar 2011 14:55:00 -0800 [thread overview]
Message-ID: <4D701C44.7090506@codeaurora.org> (raw)
In-Reply-To: <20110303152242.GB32234@opensource.wolfsonmicro.com>
Mark Brown wrote:
> On Wed, Mar 02, 2011 at 08:38:03PM -0800, Abhijeet Dharmapurikar wrote:
>> Mark Brown wrote:
>
>>> Is it really useful to register a struct device purely for the interrupt
>>> controller? I'd have expected this to be core functionality of the
>>> device. The fact that you need to store the device at all is a bit odd
>>> too as you're using the MFD API.
>
>> This design is slightly different from other MFD drivers.
>> I separated the interrupt from the core because the interrupt
>> implementation for different Qualcomm pmics remains the same. On
>> 8660 FFA boards for example, we have two pmic chips that have the
>> same interrupt subdevice implementation (the number of interrupts
>> managed by each is different). I didn't want to duplicate the exact
>> code in the core driver - hence a separate interrupt driver.
>
> Could you deal with this with a library instead?
Can you please clarify what a library means here?
>> pm8xxxx_read_block
>
>> Do you still think I should change the name?
>
> I'd suggest adding an _irq in there.
Ok will do.
--
Sent by an employee of the Qualcomm Innovation Center, Inc. The Qualcomm
Innovation Center, Inc. is a member of the Code Aurora Forum.
WARNING: multiple messages have this Message-ID (diff)
From: adharmap@codeaurora.org (Abhijeet Dharmapurikar)
To: linux-arm-kernel@lists.infradead.org
Subject: [Qualcomm PM8921 MFD 2/6] mfd: pm8xxx: Add irq support
Date: Thu, 03 Mar 2011 14:55:00 -0800 [thread overview]
Message-ID: <4D701C44.7090506@codeaurora.org> (raw)
In-Reply-To: <20110303152242.GB32234@opensource.wolfsonmicro.com>
Mark Brown wrote:
> On Wed, Mar 02, 2011 at 08:38:03PM -0800, Abhijeet Dharmapurikar wrote:
>> Mark Brown wrote:
>
>>> Is it really useful to register a struct device purely for the interrupt
>>> controller? I'd have expected this to be core functionality of the
>>> device. The fact that you need to store the device at all is a bit odd
>>> too as you're using the MFD API.
>
>> This design is slightly different from other MFD drivers.
>> I separated the interrupt from the core because the interrupt
>> implementation for different Qualcomm pmics remains the same. On
>> 8660 FFA boards for example, we have two pmic chips that have the
>> same interrupt subdevice implementation (the number of interrupts
>> managed by each is different). I didn't want to duplicate the exact
>> code in the core driver - hence a separate interrupt driver.
>
> Could you deal with this with a library instead?
Can you please clarify what a library means here?
>> pm8xxxx_read_block
>
>> Do you still think I should change the name?
>
> I'd suggest adding an _irq in there.
Ok will do.
--
Sent by an employee of the Qualcomm Innovation Center, Inc. The Qualcomm
Innovation Center, Inc. is a member of the Code Aurora Forum.
next prev parent reply other threads:[~2011-03-03 22:55 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-02 22:13 [Qualcomm PM8921 MFD 0/6] *** SUBJECT HERE *** adharmap
2011-03-02 22:13 ` adharmap at codeaurora.org
2011-03-02 22:13 ` [Qualcomm PM8921 MFD 1/6] mfd: pm8921: Add PMIC 8921 core driver adharmap
2011-03-02 22:13 ` adharmap at codeaurora.org
2011-03-02 22:28 ` Mark Brown
2011-03-02 22:28 ` Mark Brown
2011-03-03 3:38 ` Abhijeet Dharmapurikar
2011-03-03 3:38 ` Abhijeet Dharmapurikar
2011-03-02 22:13 ` [Qualcomm PM8921 MFD 2/6] mfd: pm8xxx: Add irq support adharmap
2011-03-02 22:13 ` adharmap at codeaurora.org
2011-03-02 22:46 ` Mark Brown
2011-03-02 22:46 ` Mark Brown
2011-03-03 4:38 ` Abhijeet Dharmapurikar
2011-03-03 4:38 ` Abhijeet Dharmapurikar
2011-03-03 15:22 ` Mark Brown
2011-03-03 15:22 ` Mark Brown
2011-03-03 22:55 ` Abhijeet Dharmapurikar [this message]
2011-03-03 22:55 ` Abhijeet Dharmapurikar
2011-03-04 11:12 ` Mark Brown
2011-03-04 11:12 ` Mark Brown
2011-03-02 22:13 ` [Qualcomm PM8921 MFD 3/6] gpio: pm8xxx-gpio: Add pm8xxx gpio driver adharmap
2011-03-02 22:13 ` adharmap at codeaurora.org
2011-07-08 15:44 ` Greg KH
2011-07-08 15:44 ` Greg KH
2011-07-08 17:23 ` Abhijeet Dharmapurikar
2011-07-08 17:23 ` Abhijeet Dharmapurikar
2011-03-02 22:13 ` [Qualcomm PM8921 MFD 4/6] mfd: pm8xxx-mpp: Add pm8xxx MPP driver adharmap
2011-03-02 22:13 ` adharmap at codeaurora.org
2011-07-08 14:57 ` Greg KH
2011-07-08 14:57 ` Greg KH
2011-03-02 22:13 ` [Qualcomm PM8921 MFD 5/6] MAINTAINERS: Add pmic8921, pmic8xxx subdevices maintainers adharmap
2011-03-02 22:13 ` adharmap at codeaurora.org
2011-03-02 22:50 ` Joe Perches
2011-03-02 22:50 ` Joe Perches
2011-03-03 4:41 ` Abhijeet Dharmapurikar
2011-03-03 4:41 ` Abhijeet Dharmapurikar
2011-03-02 22:13 ` [Qualcomm PM8921 MFD 6/6] msm: board-8960: Add support for pm8921 adharmap
2011-03-02 22:13 ` adharmap at codeaurora.org
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D701C44.7090506@codeaurora.org \
--to=adharmap@codeaurora.org \
--cc=akpm@linux-foundation.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=bryanh@codeaurora.org \
--cc=collinsd@codeaurora.org \
--cc=davem@davemloft.net \
--cc=davidb@codeaurora.org \
--cc=dwalker@fifo99.com \
--cc=grant.likely@secretlab.ca \
--cc=gregkh@suse.de \
--cc=joe@perches.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux.walleij@sterricsson.com \
--cc=linux@arm.linux.org.uk \
--cc=sameo@linux.intel.com \
--cc=stepanm@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.