From: Evgeniy Polyakov <zbr@ioremap.net>
To: Chris Wright <chrisw@sous-sol.org>,
David Miller <davem@davemloft.net>,
linux-fbdev@vger.kernel.org, netdev@vger.kernel.org,
linux-security-module@vger.kernel.org, dm-devel@redhat.com
Subject: Re: [Drbd-dev] [PATCH 2/2 v2] netlink: kill eff_cap from struct netlink_skb_parms
Date: Fri, 4 Mar 2011 04:29:56 +0300 [thread overview]
Message-ID: <20110304012956.GA13573@ioremap.net> (raw)
In-Reply-To: <20110303223746.GI25069@barkeeper1-xen.linbit>
Hi.
On Thu, Mar 03, 2011 at 11:37:46PM +0100, Lars Ellenberg (lars.ellenberg@linbit.com) wrote:
> If so, then this change introduces the possibility for normal users to
> send privileged commands to connector based subsystems, even if they
> may not be able to bind() to suitable sockets to receive any replies.
>
> Am I missing something?
Yup, connector is very async at that place, but I wonder why the hell I
ever made that decision. I believe we can replace it with pure sync call
of the registered connector callback, since netlink is synchronous and
no one has any problem with it.
--
Evgeniy Polyakov
WARNING: multiple messages have this Message-ID (diff)
From: Evgeniy Polyakov <zbr@ioremap.net>
To: Chris Wright <chrisw@sous-sol.org>,
David Miller <davem@davemloft.net>,
linux-fbdev@vger.kernel.org, netdev@vger.kernel.org,
linux-security-module@vger.kernel.org, dm-devel@redhat.com
Subject: Re: [Drbd-dev] [PATCH 2/2 v2] netlink: kill eff_cap from struct
Date: Fri, 04 Mar 2011 01:29:56 +0000 [thread overview]
Message-ID: <20110304012956.GA13573@ioremap.net> (raw)
In-Reply-To: <20110303223746.GI25069@barkeeper1-xen.linbit>
Hi.
On Thu, Mar 03, 2011 at 11:37:46PM +0100, Lars Ellenberg (lars.ellenberg@linbit.com) wrote:
> If so, then this change introduces the possibility for normal users to
> send privileged commands to connector based subsystems, even if they
> may not be able to bind() to suitable sockets to receive any replies.
>
> Am I missing something?
Yup, connector is very async at that place, but I wonder why the hell I
ever made that decision. I believe we can replace it with pure sync call
of the registered connector callback, since netlink is synchronous and
no one has any problem with it.
--
Evgeniy Polyakov
WARNING: multiple messages have this Message-ID (diff)
From: Evgeniy Polyakov <zbr@ioremap.net>
To: Chris Wright <chrisw@sous-sol.org>,
David Miller <davem@davemloft.net>,
linux-fbdev@vger.kernel.org, netdev@vger.kernel.org,
linux-security-module@vger.kernel.org, dm-devel@redhat.com,
kaber@trash.net, drbd-dev@lists.linbit.com
Subject: Re: [Drbd-dev] [PATCH 2/2 v2] netlink: kill eff_cap from struct netlink_skb_parms
Date: Fri, 4 Mar 2011 04:29:56 +0300 [thread overview]
Message-ID: <20110304012956.GA13573@ioremap.net> (raw)
In-Reply-To: <20110303223746.GI25069@barkeeper1-xen.linbit>
Hi.
On Thu, Mar 03, 2011 at 11:37:46PM +0100, Lars Ellenberg (lars.ellenberg@linbit.com) wrote:
> If so, then this change introduces the possibility for normal users to
> send privileged commands to connector based subsystems, even if they
> may not be able to bind() to suitable sockets to receive any replies.
>
> Am I missing something?
Yup, connector is very async at that place, but I wonder why the hell I
ever made that decision. I believe we can replace it with pure sync call
of the registered connector callback, since netlink is synchronous and
no one has any problem with it.
--
Evgeniy Polyakov
next prev parent reply other threads:[~2011-03-04 1:29 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-03 9:38 [PATCH 2/2] netlink: kill eff_cap from struct netlink_skb_parms Patrick McHardy
2011-03-03 9:38 ` [Drbd-dev] " Patrick McHardy
2011-03-03 10:49 ` James Morris
2011-03-03 10:49 ` [Drbd-dev] " James Morris
2011-03-03 17:32 ` Chris Wright
2011-03-03 17:32 ` [Drbd-dev] " Chris Wright
2011-03-03 18:56 ` David Miller
2011-03-03 18:56 ` [Drbd-dev] " David Miller
2011-03-03 20:15 ` [PATCH 2/2 v2] " Chris Wright
2011-03-03 20:15 ` [Drbd-dev] " Chris Wright
2011-03-03 20:15 ` Chris Wright
2011-03-03 21:39 ` David Miller
2011-03-03 21:39 ` [Drbd-dev] " David Miller
2011-03-03 21:39 ` [PATCH 2/2 v2] netlink: kill eff_cap from struct David Miller
[not found] ` <20110303201522.GT4988-JyIX8gxvWYPr2PDY2+4mTGD2FQJk+8+b@public.gmane.org>
2011-03-03 22:37 ` [PATCH 2/2 v2] netlink: kill eff_cap from struct netlink_skb_parms Lars Ellenberg
2011-03-03 22:37 ` [Drbd-dev] " Lars Ellenberg
2011-03-03 22:37 ` [Drbd-dev] [PATCH 2/2 v2] netlink: kill eff_cap from struct Lars Ellenberg
2011-03-03 23:53 ` [Drbd-dev] [PATCH 2/2 v2] netlink: kill eff_cap from struct netlink_skb_parms Chris Wright
2011-03-03 23:53 ` Chris Wright
2011-03-03 23:53 ` [Drbd-dev] [PATCH 2/2 v2] netlink: kill eff_cap from struct Chris Wright
2011-03-04 1:29 ` Evgeniy Polyakov [this message]
2011-03-04 1:29 ` [Drbd-dev] [PATCH 2/2 v2] netlink: kill eff_cap from struct netlink_skb_parms Evgeniy Polyakov
2011-03-04 1:29 ` [Drbd-dev] [PATCH 2/2 v2] netlink: kill eff_cap from struct Evgeniy Polyakov
2011-03-04 1:38 ` [Drbd-dev] [PATCH 2/2 v2] netlink: kill eff_cap from struct netlink_skb_parms David Miller
2011-03-04 1:38 ` David Miller
2011-03-04 1:38 ` [Drbd-dev] [PATCH 2/2 v2] netlink: kill eff_cap from struct David Miller
2011-03-08 14:50 ` [Drbd-dev] [PATCH 2/2 v2] netlink: kill eff_cap from struct netlink_skb_parms Patrick McHardy
2011-03-08 14:50 ` Patrick McHardy
2011-03-08 14:50 ` Patrick McHardy
2011-03-08 18:32 ` Evgeniy Polyakov
2011-03-08 18:32 ` Evgeniy Polyakov
2011-03-08 18:32 ` [Drbd-dev] [PATCH 2/2 v2] netlink: kill eff_cap from struct Evgeniy Polyakov
2011-03-08 18:54 ` [Drbd-dev] [PATCH 2/2 v2] netlink: kill eff_cap from struct netlink_skb_parms Patrick McHardy
2011-03-08 18:54 ` Patrick McHardy
2011-03-08 18:54 ` Patrick McHardy
2011-03-17 15:43 ` Evgeniy Polyakov
2011-03-17 15:43 ` Evgeniy Polyakov
2011-03-17 15:43 ` [Drbd-dev] [PATCH 2/2 v2] netlink: kill eff_cap from struct Evgeniy Polyakov
2011-03-03 20:17 ` [PATCH 2/2] netlink: kill eff_cap from struct netlink_skb_parms Chris Wright
2011-03-03 20:17 ` [Drbd-dev] " Chris Wright
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110304012956.GA13573@ioremap.net \
--to=zbr@ioremap.net \
--cc=chrisw@sous-sol.org \
--cc=davem@davemloft.net \
--cc=dm-devel@redhat.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.