All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Govindraj <govindraj.ti@gmail.com>
Cc: Kevin Hilman <khilman@ti.com>,
	"Govindraj.R" <govindraj.raja@ti.com>,
	linux-omap@vger.kernel.org, linux-serial@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	Benoit Cousson <b-cousson@ti.com>, Paul Walmsley <paul@pwsan.com>,
	Rajendra Nayak <rnayak@ti.com>
Subject: Re: [PATCH 2/7] OMAP2+: mux: Enable wakeup for wakeup enable requested pads
Date: Tue, 8 Mar 2011 09:26:25 -0800	[thread overview]
Message-ID: <20110308172625.GE26463@atomide.com> (raw)
In-Reply-To: <AANLkTiknEQrqUt1-sY6-aDw4R5ZMP2uErSjRNB5Yex_v@mail.gmail.com>

* Govindraj <govindraj.ti@gmail.com> [110308 03:43]:
> 
> I am not sure whether now we can control read/writes to pad_mux from any driver
> interface and I think we have to go through mux framework for any
> read/writes to mux.

Sure, the drivers should not mess with those registers directly.

> with this I cant control pad wake up capabilities with sysfs as done
> earlier in serial.c
> now control to read/write to pad is outside scope of the driver
> interface as omap_hwmod_mux
> is the one that takes decision for driver with mux values provided
> during omap_hwmod_mux_init.

The sysfs interface to control this should still be from the drivers.
Sounds like we need some way to set the wakeup flags before pm_runtime_put
is called.

Regards,

Tony

WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/7] OMAP2+: mux: Enable wakeup for wakeup enable requested pads
Date: Tue, 8 Mar 2011 09:26:25 -0800	[thread overview]
Message-ID: <20110308172625.GE26463@atomide.com> (raw)
In-Reply-To: <AANLkTiknEQrqUt1-sY6-aDw4R5ZMP2uErSjRNB5Yex_v@mail.gmail.com>

* Govindraj <govindraj.ti@gmail.com> [110308 03:43]:
> 
> I am not sure whether now we can control read/writes to pad_mux from any driver
> interface and I think we have to go through mux framework for any
> read/writes to mux.

Sure, the drivers should not mess with those registers directly.

> with this I cant control pad wake up capabilities with sysfs as done
> earlier in serial.c
> now control to read/write to pad is outside scope of the driver
> interface as omap_hwmod_mux
> is the one that takes decision for driver with mux values provided
> during omap_hwmod_mux_init.

The sysfs interface to control this should still be from the drivers.
Sounds like we need some way to set the wakeup flags before pm_runtime_put
is called.

Regards,

Tony

  reply	other threads:[~2011-03-08 17:26 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-02 11:12 [PATCH 2/7] OMAP2+: mux: Enable wakeup for wakeup enable requested pads Govindraj.R
2011-03-02 11:12 ` Govindraj.R
2011-03-04 23:54 ` Kevin Hilman
2011-03-04 23:54   ` Kevin Hilman
2011-03-05  1:57   ` Kevin Hilman
2011-03-05  1:57     ` Kevin Hilman
2011-03-08 11:44     ` Govindraj
2011-03-08 11:44       ` Govindraj
2011-03-08 17:26       ` Tony Lindgren [this message]
2011-03-08 17:26         ` Tony Lindgren
2011-03-08 18:31         ` Kevin Hilman
2011-03-08 18:31           ` Kevin Hilman
2011-03-08 19:16           ` Paul Walmsley
2011-03-08 19:16             ` Paul Walmsley
2011-03-08 19:21       ` Paul Walmsley
2011-03-08 19:21         ` Paul Walmsley
2011-03-09 12:06         ` Govindraj
2011-03-09 12:06           ` Govindraj
2011-03-08 12:19   ` Govindraj
2011-03-08 12:19     ` Govindraj
2011-03-09  1:14     ` Kevin Hilman
2011-03-09  1:14       ` Kevin Hilman
2011-03-09 14:45       ` Govindraj
2011-03-09 14:45         ` Govindraj
2011-03-05  1:27 ` Kevin Hilman
2011-03-05  1:27   ` Kevin Hilman
  -- strict thread matches above, loose matches on Subject: below --
2011-02-28 14:39 [PATCH 0/7] OMAP2+: UART: runtime conversion + cleanup Govindraj.R
2011-02-28 14:39 ` [PATCH 2/7] OMAP2+: mux: Enable wakeup for wakeup enable requested pads Govindraj.R
2011-02-28 14:39   ` Govindraj.R
2011-03-02  4:49   ` Varadarajan, Charulatha
2011-03-02  4:49     ` Varadarajan, Charulatha
2011-03-02 10:40     ` Govindraj
2011-03-02 10:40       ` Govindraj

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110308172625.GE26463@atomide.com \
    --to=tony@atomide.com \
    --cc=b-cousson@ti.com \
    --cc=govindraj.raja@ti.com \
    --cc=govindraj.ti@gmail.com \
    --cc=khilman@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=paul@pwsan.com \
    --cc=rnayak@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.