* [patch 2/2] iwlwifi: remove duplicate initialization in
@ 2011-03-15 7:03 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2011-03-15 7:03 UTC (permalink / raw)
To: Wey-Yi Guy
Cc: Intel Linux Wireless, John W. Linville, linux-wireless,
kernel-janitors
We initialize exit_pending twice. It's the second initialization which
is correct. That was added in d745d472af "iwlwifi: cancel scan when
down the device".
Signed-off-by: Dan Carpenter <error27@gmail.com>
diff --git a/drivers/net/wireless/iwlwifi/iwl-agn.c b/drivers/net/wireless/iwlwifi/iwl-agn.c
index 321b18b..7adc60e 100644
--- a/drivers/net/wireless/iwlwifi/iwl-agn.c
+++ b/drivers/net/wireless/iwlwifi/iwl-agn.c
@@ -2537,7 +2537,7 @@ static void iwl_cancel_deferred_work(struct iwl_priv *priv);
static void __iwl_down(struct iwl_priv *priv)
{
unsigned long flags;
- int exit_pending = test_bit(STATUS_EXIT_PENDING, &priv->status);
+ int exit_pending;
IWL_DEBUG_INFO(priv, DRV_NAME " is going down\n");
^ permalink raw reply related [flat|nested] 4+ messages in thread* [patch 2/2] iwlwifi: remove duplicate initialization in __iwl_down()
@ 2011-03-15 7:03 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2011-03-15 7:03 UTC (permalink / raw)
To: Wey-Yi Guy
Cc: Intel Linux Wireless, John W. Linville, linux-wireless,
kernel-janitors
We initialize exit_pending twice. It's the second initialization which
is correct. That was added in d745d472af "iwlwifi: cancel scan when
down the device".
Signed-off-by: Dan Carpenter <error27@gmail.com>
diff --git a/drivers/net/wireless/iwlwifi/iwl-agn.c b/drivers/net/wireless/iwlwifi/iwl-agn.c
index 321b18b..7adc60e 100644
--- a/drivers/net/wireless/iwlwifi/iwl-agn.c
+++ b/drivers/net/wireless/iwlwifi/iwl-agn.c
@@ -2537,7 +2537,7 @@ static void iwl_cancel_deferred_work(struct iwl_priv *priv);
static void __iwl_down(struct iwl_priv *priv)
{
unsigned long flags;
- int exit_pending = test_bit(STATUS_EXIT_PENDING, &priv->status);
+ int exit_pending;
IWL_DEBUG_INFO(priv, DRV_NAME " is going down\n");
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [patch 2/2] iwlwifi: remove duplicate initialization in
2011-03-15 7:03 ` [patch 2/2] iwlwifi: remove duplicate initialization in __iwl_down() Dan Carpenter
@ 2011-03-15 9:05 ` Guy, Wey-Yi
-1 siblings, 0 replies; 4+ messages in thread
From: Guy, Wey-Yi @ 2011-03-15 9:05 UTC (permalink / raw)
To: Dan Carpenter
Cc: Intel Linux Wireless, John W. Linville,
linux-wireless@vger.kernel.org, kernel-janitors@vger.kernel.org
On Tue, 2011-03-15 at 00:03 -0700, Dan Carpenter wrote:
> We initialize exit_pending twice. It's the second initialization which
> is correct. That was added in d745d472af "iwlwifi: cancel scan when
> down the device".
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
>
Acked-by: Wey-Yi Guy <wey-yi.w.guy@intel.com>
> diff --git a/drivers/net/wireless/iwlwifi/iwl-agn.c b/drivers/net/wireless/iwlwifi/iwl-agn.c
> index 321b18b..7adc60e 100644
> --- a/drivers/net/wireless/iwlwifi/iwl-agn.c
> +++ b/drivers/net/wireless/iwlwifi/iwl-agn.c
> @@ -2537,7 +2537,7 @@ static void iwl_cancel_deferred_work(struct iwl_priv *priv);
> static void __iwl_down(struct iwl_priv *priv)
> {
> unsigned long flags;
> - int exit_pending = test_bit(STATUS_EXIT_PENDING, &priv->status);
> + int exit_pending;
>
> IWL_DEBUG_INFO(priv, DRV_NAME " is going down\n");
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [patch 2/2] iwlwifi: remove duplicate initialization in __iwl_down()
@ 2011-03-15 9:05 ` Guy, Wey-Yi
0 siblings, 0 replies; 4+ messages in thread
From: Guy, Wey-Yi @ 2011-03-15 9:05 UTC (permalink / raw)
To: Dan Carpenter
Cc: Intel Linux Wireless, John W. Linville,
linux-wireless@vger.kernel.org, kernel-janitors@vger.kernel.org
On Tue, 2011-03-15 at 00:03 -0700, Dan Carpenter wrote:
> We initialize exit_pending twice. It's the second initialization which
> is correct. That was added in d745d472af "iwlwifi: cancel scan when
> down the device".
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
>
Acked-by: Wey-Yi Guy <wey-yi.w.guy@intel.com>
> diff --git a/drivers/net/wireless/iwlwifi/iwl-agn.c b/drivers/net/wireless/iwlwifi/iwl-agn.c
> index 321b18b..7adc60e 100644
> --- a/drivers/net/wireless/iwlwifi/iwl-agn.c
> +++ b/drivers/net/wireless/iwlwifi/iwl-agn.c
> @@ -2537,7 +2537,7 @@ static void iwl_cancel_deferred_work(struct iwl_priv *priv);
> static void __iwl_down(struct iwl_priv *priv)
> {
> unsigned long flags;
> - int exit_pending = test_bit(STATUS_EXIT_PENDING, &priv->status);
> + int exit_pending;
>
> IWL_DEBUG_INFO(priv, DRV_NAME " is going down\n");
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-03-15 9:21 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-03-15 7:03 [patch 2/2] iwlwifi: remove duplicate initialization in Dan Carpenter
2011-03-15 7:03 ` [patch 2/2] iwlwifi: remove duplicate initialization in __iwl_down() Dan Carpenter
2011-03-15 9:05 ` [patch 2/2] iwlwifi: remove duplicate initialization in Guy, Wey-Yi
2011-03-15 9:05 ` [patch 2/2] iwlwifi: remove duplicate initialization in __iwl_down() Guy, Wey-Yi
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.