From: Arnd Bergmann <arnd@arndb.de>
To: Jonathan Cameron <jic23@cam.ac.uk>
Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
Greg KH <greg@kroah.com>
Subject: Re: IIO comments
Date: Wed, 16 Mar 2011 19:52:07 +0100 [thread overview]
Message-ID: <201103161952.07486.arnd@arndb.de> (raw)
In-Reply-To: <4D80EB5F.6030805@cam.ac.uk>
On Wednesday 16 March 2011 17:54:55 Jonathan Cameron wrote:
> >> * iio_allocate_device() could get a size argument and
> >> allocate the dev_data together with the iio_dev in
> >> a single allocation, like netdev_alloc does. In addition,
> >> you can pass a structure with all constant data, such
> >> as THIS_MODULE, and the operations and/or attribute groups,
> >> instead of having to set them individually for each dev.
> > Good idea.
>
> There is an issue here I'd forgotten. Some of our structures have a
> elements which are cacheline aligned. For first version of this I'll
> set our alignment requirements as L1_CACHE_BYTES. Would be nice to be
> able to relax that down the line though as it means we use at least two
> cachelines even if we don't care about that alignment requirement.
I think the data used by a device structure is not really an issue,
especially extending it by just another cache line.
Arnd
prev parent reply other threads:[~2011-03-16 18:52 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-15 21:15 IIO comments Arnd Bergmann
2011-03-16 11:57 ` Jonathan Cameron
2011-03-16 13:33 ` Arnd Bergmann
2011-03-16 14:50 ` Jonathan Cameron
2011-03-16 15:09 ` Guenter Roeck
2011-03-16 15:15 ` Arnd Bergmann
2011-03-16 15:33 ` Jonathan Cameron
2011-03-17 13:24 ` Arnd Bergmann
2011-03-17 16:47 ` Jonathan Cameron
2011-03-17 17:51 ` Arnd Bergmann
2011-03-17 18:33 ` Jonathan Cameron
2011-03-18 12:47 ` Arnd Bergmann
2011-03-18 16:06 ` Jonathan Cameron
2011-03-18 16:18 ` Arnd Bergmann
2011-03-18 16:29 ` Jonathan Cameron
2011-03-18 16:57 ` Arnd Bergmann
2011-03-18 17:51 ` Jonathan Cameron
2011-03-17 13:47 ` Arnd Bergmann
2011-03-17 14:42 ` Jonathan Cameron
2011-03-17 15:03 ` Arnd Bergmann
2011-03-17 16:46 ` Jonathan Cameron
2011-03-17 16:47 ` Jonathan Cameron
2011-03-17 17:54 ` Arnd Bergmann
2011-03-16 16:54 ` Jonathan Cameron
2011-03-16 18:52 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201103161952.07486.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=greg@kroah.com \
--cc=jic23@cam.ac.uk \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.