All of lore.kernel.org
 help / color / mirror / Atom feed
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 7/7] tty: add pruss SUART driver
Date: Fri, 18 Mar 2011 13:07:12 +0100	[thread overview]
Message-ID: <201103181307.12699.arnd@arndb.de> (raw)
In-Reply-To: <02A821E977914EF6B7B4BD36F07C1A2A@subhasishg>

On Friday 18 March 2011, Subhasish Ghosh wrote:
> Hi Greg/Alan,
> 
> Any comments regarding this driver.
> 

I already did a review of the base MFD driver that you have not replied
to yet. A number of the points I brought up in that review and in my
review of the pruss CAN driver also apply to this one. Please post
cleaned-up versions of all those drivers, and I'll have another look.

	Arnd

WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: "Subhasish Ghosh" <subhasish@mistralsolutions.com>
Cc: "Greg Kroah-Hartman" <gregkh@suse.de>,
	"Alan Cox" <alan@lxorguk.ukuu.org.uk>,
	"Thomas Gleixner" <tglx@linutronix.de>,
	linux-arm-kernel@lists.infradead.org, m-watkins@ti.com,
	nsekhar@ti.com, sachi@mistralsolutions.com,
	"Andrew Morton \(commit_signer:1/4=25%\)"
	<akpm@linux-foundation.org>,
	"Randy Dunlap \(commit_signer:1/4=25%\)"
	<randy.dunlap@oracle.com>,
	"open list" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 7/7] tty: add pruss SUART driver
Date: Fri, 18 Mar 2011 13:07:12 +0100	[thread overview]
Message-ID: <201103181307.12699.arnd@arndb.de> (raw)
In-Reply-To: <02A821E977914EF6B7B4BD36F07C1A2A@subhasishg>

On Friday 18 March 2011, Subhasish Ghosh wrote:
> Hi Greg/Alan,
> 
> Any comments regarding this driver.
> 

I already did a review of the base MFD driver that you have not replied
to yet. A number of the points I brought up in that review and in my
review of the pruss CAN driver also apply to this one. Please post
cleaned-up versions of all those drivers, and I'll have another look.

	Arnd

  parent reply	other threads:[~2011-03-18 12:07 UTC|newest]

Thread overview: 63+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-08 13:57 [PATCH v3 0/7] pruss mfd drivers Subhasish Ghosh
2011-03-08 13:57 ` [PATCH v3 1/7] mfd: add pruss mfd driver Subhasish Ghosh
2011-03-08 13:57   ` Subhasish Ghosh
2011-03-09 11:56   ` Marc Kleine-Budde
2011-03-09 11:56     ` Marc Kleine-Budde
2011-03-24 13:16     ` Subhasish Ghosh
2011-03-24 13:16       ` Subhasish Ghosh
2011-03-24 13:24       ` Marc Kleine-Budde
2011-03-24 13:24         ` Marc Kleine-Budde
2011-03-24 13:41         ` Kurt Van Dijck
2011-03-24 13:41           ` Kurt Van Dijck
2011-03-11 15:28   ` Arnd Bergmann
2011-03-11 15:28     ` Arnd Bergmann
2011-03-30  7:16     ` Subhasish Ghosh
2011-03-30  7:16       ` Subhasish Ghosh
2011-03-30 10:59       ` Arnd Bergmann
2011-03-30 10:59         ` Arnd Bergmann
2011-04-05  6:40         ` Subhasish Ghosh
2011-04-05  6:40           ` Subhasish Ghosh
2011-03-30  9:15     ` Subhasish Ghosh
2011-03-30  9:15       ` Subhasish Ghosh
2011-03-30 11:38       ` Arnd Bergmann
2011-03-30 11:38         ` Arnd Bergmann
2011-03-18 11:59   ` Nori, Sekhar
2011-03-18 11:59     ` Nori, Sekhar
2011-03-18 12:39     ` Mark Brown
2011-03-18 12:39       ` Mark Brown
2011-03-22  9:35       ` Nori, Sekhar
2011-03-22  9:35         ` Nori, Sekhar
2011-03-22  9:43         ` Nori, Sekhar
2011-03-22  9:43           ` Nori, Sekhar
2011-03-22 16:52         ` Mark Brown
2011-03-22 16:52           ` Mark Brown
2011-03-08 13:57 ` [PATCH v3 2/7] da850: pruss platform specific additions Subhasish Ghosh
2011-03-08 13:57   ` Subhasish Ghosh
2011-03-08 15:17   ` Sergei Shtylyov
2011-03-08 15:17     ` Sergei Shtylyov
2011-03-08 13:57 ` [PATCH v3 3/7] da850: pruss board " Subhasish Ghosh
2011-03-08 13:57   ` Subhasish Ghosh
2011-03-08 15:19   ` Sergei Shtylyov
2011-03-08 15:19     ` Sergei Shtylyov
2011-03-09  4:29     ` Subhasish Ghosh
2011-03-09  4:29       ` Subhasish Ghosh
2011-03-09 11:59   ` Marc Kleine-Budde
2011-03-09 11:59     ` Marc Kleine-Budde
2011-03-08 13:57 ` [PATCH v3 4/7] mfd: pruss SUART private data Subhasish Ghosh
2011-03-08 13:57   ` Subhasish Ghosh
2011-03-08 13:57 ` [PATCH v3 5/7] da850: pruss SUART board specific additions Subhasish Ghosh
2011-03-08 13:57   ` Subhasish Ghosh
2011-03-08 13:57 ` [PATCH v3 6/7] da850: pruss SUART platform " Subhasish Ghosh
2011-03-08 13:57   ` Subhasish Ghosh
2011-03-08 13:57 ` [PATCH v3 7/7] tty: add pruss SUART driver Subhasish Ghosh
2011-03-08 13:57   ` Subhasish Ghosh
2011-03-08 18:47   ` Randy Dunlap
2011-03-08 18:47     ` Randy Dunlap
2011-03-15  7:23     ` Subhasish Ghosh
2011-03-15  7:23       ` Subhasish Ghosh
2011-03-18  5:43   ` Subhasish Ghosh
2011-03-18  5:43     ` Subhasish Ghosh
2011-03-18 11:45     ` Alan Cox
2011-03-18 11:45       ` Alan Cox
2011-03-18 12:07     ` Arnd Bergmann [this message]
2011-03-18 12:07       ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201103181307.12699.arnd@arndb.de \
    --to=arnd@arndb.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.