From: Dan Carpenter <error27@gmail.com>
To: Mike Isely <isely@pobox.com>
Cc: Mauro Carvalho Chehab <mchehab@infradead.org>,
linux-media@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: [PATCH 2/6] [media] pvrusb2: fix remaining checkpatch.pl complaints
Date: Sat, 26 Mar 2011 01:51:12 +0000 [thread overview]
Message-ID: <20110326015112.GG2008@bicker> (raw)
* Include <linux/string.h> instead of <asm/string.h>.
* Remove unneeded curly braces.
Signed-off-by: Dan Carpenter <error27@gmail.com>
diff --git a/drivers/media/video/pvrusb2/pvrusb2-std.c b/drivers/media/video/pvrusb2/pvrusb2-std.c
index a5d4867..370a9ab 100644
--- a/drivers/media/video/pvrusb2/pvrusb2-std.c
+++ b/drivers/media/video/pvrusb2/pvrusb2-std.c
@@ -20,7 +20,7 @@
#include "pvrusb2-std.h"
#include "pvrusb2-debug.h"
-#include <asm/string.h>
+#include <linux/string.h>
#include <linux/slab.h>
struct std_name {
@@ -294,9 +294,8 @@ static struct v4l2_standard *match_std(v4l2_std_id id)
unsigned int idx;
for (idx = 0; idx < generic_standards_cnt; idx++) {
- if (generic_standards[idx].id & id) {
+ if (generic_standards[idx].id & id)
return generic_standards + idx;
- }
}
return NULL;
}
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <error27@gmail.com>
To: Mike Isely <isely@pobox.com>
Cc: Mauro Carvalho Chehab <mchehab@infradead.org>,
linux-media@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: [PATCH 2/6] [media] pvrusb2: fix remaining checkpatch.pl complaints
Date: Sat, 26 Mar 2011 04:51:12 +0300 [thread overview]
Message-ID: <20110326015112.GG2008@bicker> (raw)
* Include <linux/string.h> instead of <asm/string.h>.
* Remove unneeded curly braces.
Signed-off-by: Dan Carpenter <error27@gmail.com>
diff --git a/drivers/media/video/pvrusb2/pvrusb2-std.c b/drivers/media/video/pvrusb2/pvrusb2-std.c
index a5d4867..370a9ab 100644
--- a/drivers/media/video/pvrusb2/pvrusb2-std.c
+++ b/drivers/media/video/pvrusb2/pvrusb2-std.c
@@ -20,7 +20,7 @@
#include "pvrusb2-std.h"
#include "pvrusb2-debug.h"
-#include <asm/string.h>
+#include <linux/string.h>
#include <linux/slab.h>
struct std_name {
@@ -294,9 +294,8 @@ static struct v4l2_standard *match_std(v4l2_std_id id)
unsigned int idx;
for (idx = 0; idx < generic_standards_cnt; idx++) {
- if (generic_standards[idx].id & id) {
+ if (generic_standards[idx].id & id)
return generic_standards + idx;
- }
}
return NULL;
}
next reply other threads:[~2011-03-26 1:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-26 1:51 Dan Carpenter [this message]
2011-03-26 1:51 ` [PATCH 2/6] [media] pvrusb2: fix remaining checkpatch.pl complaints Dan Carpenter
2011-03-26 4:33 ` [PATCH 2/6] [media] pvrusb2: fix remaining checkpatch.pl Mike Isely
2011-03-26 4:33 ` [PATCH 2/6] [media] pvrusb2: fix remaining checkpatch.pl complaints Mike Isely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110326015112.GG2008@bicker \
--to=error27@gmail.com \
--cc=isely@pobox.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.