* [PATCH 2/6] [media] pvrusb2: fix remaining checkpatch.pl complaints
@ 2011-03-26 1:51 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2011-03-26 1:51 UTC (permalink / raw)
To: Mike Isely; +Cc: Mauro Carvalho Chehab, linux-media, kernel-janitors
* Include <linux/string.h> instead of <asm/string.h>.
* Remove unneeded curly braces.
Signed-off-by: Dan Carpenter <error27@gmail.com>
diff --git a/drivers/media/video/pvrusb2/pvrusb2-std.c b/drivers/media/video/pvrusb2/pvrusb2-std.c
index a5d4867..370a9ab 100644
--- a/drivers/media/video/pvrusb2/pvrusb2-std.c
+++ b/drivers/media/video/pvrusb2/pvrusb2-std.c
@@ -20,7 +20,7 @@
#include "pvrusb2-std.h"
#include "pvrusb2-debug.h"
-#include <asm/string.h>
+#include <linux/string.h>
#include <linux/slab.h>
struct std_name {
@@ -294,9 +294,8 @@ static struct v4l2_standard *match_std(v4l2_std_id id)
unsigned int idx;
for (idx = 0; idx < generic_standards_cnt; idx++) {
- if (generic_standards[idx].id & id) {
+ if (generic_standards[idx].id & id)
return generic_standards + idx;
- }
}
return NULL;
}
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH 2/6] [media] pvrusb2: fix remaining checkpatch.pl complaints
@ 2011-03-26 1:51 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2011-03-26 1:51 UTC (permalink / raw)
To: Mike Isely; +Cc: Mauro Carvalho Chehab, linux-media, kernel-janitors
* Include <linux/string.h> instead of <asm/string.h>.
* Remove unneeded curly braces.
Signed-off-by: Dan Carpenter <error27@gmail.com>
diff --git a/drivers/media/video/pvrusb2/pvrusb2-std.c b/drivers/media/video/pvrusb2/pvrusb2-std.c
index a5d4867..370a9ab 100644
--- a/drivers/media/video/pvrusb2/pvrusb2-std.c
+++ b/drivers/media/video/pvrusb2/pvrusb2-std.c
@@ -20,7 +20,7 @@
#include "pvrusb2-std.h"
#include "pvrusb2-debug.h"
-#include <asm/string.h>
+#include <linux/string.h>
#include <linux/slab.h>
struct std_name {
@@ -294,9 +294,8 @@ static struct v4l2_standard *match_std(v4l2_std_id id)
unsigned int idx;
for (idx = 0; idx < generic_standards_cnt; idx++) {
- if (generic_standards[idx].id & id) {
+ if (generic_standards[idx].id & id)
return generic_standards + idx;
- }
}
return NULL;
}
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH 2/6] [media] pvrusb2: fix remaining checkpatch.pl
2011-03-26 1:51 ` Dan Carpenter
@ 2011-03-26 4:33 ` Mike Isely
-1 siblings, 0 replies; 4+ messages in thread
From: Mike Isely @ 2011-03-26 4:33 UTC (permalink / raw)
To: Dan Carpenter
Cc: Mauro Carvalho Chehab, linux-media, kernel-janitors, Mike Isely
I am OK with the #include change, but NOT the if-statement change. But
since it's bundled into one patch...
Nacked-By: Mike Isely <isely@pobox.com>
On Sat, 26 Mar 2011, Dan Carpenter wrote:
> * Include <linux/string.h> instead of <asm/string.h>.
> * Remove unneeded curly braces.
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
>
> diff --git a/drivers/media/video/pvrusb2/pvrusb2-std.c b/drivers/media/video/pvrusb2/pvrusb2-std.c
> index a5d4867..370a9ab 100644
> --- a/drivers/media/video/pvrusb2/pvrusb2-std.c
> +++ b/drivers/media/video/pvrusb2/pvrusb2-std.c
> @@ -20,7 +20,7 @@
>
> #include "pvrusb2-std.h"
> #include "pvrusb2-debug.h"
> -#include <asm/string.h>
> +#include <linux/string.h>
> #include <linux/slab.h>
>
> struct std_name {
> @@ -294,9 +294,8 @@ static struct v4l2_standard *match_std(v4l2_std_id id)
> unsigned int idx;
>
> for (idx = 0; idx < generic_standards_cnt; idx++) {
> - if (generic_standards[idx].id & id) {
> + if (generic_standards[idx].id & id)
> return generic_standards + idx;
> - }
> }
> return NULL;
> }
>
--
Mike Isely
isely @ isely (dot) net
PGP: 03 54 43 4D 75 E5 CC 92 71 16 01 E2 B5 F5 C1 E8
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH 2/6] [media] pvrusb2: fix remaining checkpatch.pl complaints
@ 2011-03-26 4:33 ` Mike Isely
0 siblings, 0 replies; 4+ messages in thread
From: Mike Isely @ 2011-03-26 4:33 UTC (permalink / raw)
To: Dan Carpenter
Cc: Mauro Carvalho Chehab, linux-media, kernel-janitors, Mike Isely
I am OK with the #include change, but NOT the if-statement change. But
since it's bundled into one patch...
Nacked-By: Mike Isely <isely@pobox.com>
On Sat, 26 Mar 2011, Dan Carpenter wrote:
> * Include <linux/string.h> instead of <asm/string.h>.
> * Remove unneeded curly braces.
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
>
> diff --git a/drivers/media/video/pvrusb2/pvrusb2-std.c b/drivers/media/video/pvrusb2/pvrusb2-std.c
> index a5d4867..370a9ab 100644
> --- a/drivers/media/video/pvrusb2/pvrusb2-std.c
> +++ b/drivers/media/video/pvrusb2/pvrusb2-std.c
> @@ -20,7 +20,7 @@
>
> #include "pvrusb2-std.h"
> #include "pvrusb2-debug.h"
> -#include <asm/string.h>
> +#include <linux/string.h>
> #include <linux/slab.h>
>
> struct std_name {
> @@ -294,9 +294,8 @@ static struct v4l2_standard *match_std(v4l2_std_id id)
> unsigned int idx;
>
> for (idx = 0; idx < generic_standards_cnt; idx++) {
> - if (generic_standards[idx].id & id) {
> + if (generic_standards[idx].id & id)
> return generic_standards + idx;
> - }
> }
> return NULL;
> }
>
--
Mike Isely
isely @ isely (dot) net
PGP: 03 54 43 4D 75 E5 CC 92 71 16 01 E2 B5 F5 C1 E8
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-03-26 4:33 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-03-26 1:51 [PATCH 2/6] [media] pvrusb2: fix remaining checkpatch.pl complaints Dan Carpenter
2011-03-26 1:51 ` Dan Carpenter
2011-03-26 4:33 ` [PATCH 2/6] [media] pvrusb2: fix remaining checkpatch.pl Mike Isely
2011-03-26 4:33 ` [PATCH 2/6] [media] pvrusb2: fix remaining checkpatch.pl complaints Mike Isely
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.