From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V5 3/4] ARM: Xilinx: base header files and assembly macros
Date: Wed, 30 Mar 2011 13:44:45 +0200 [thread overview]
Message-ID: <201103301344.45307.arnd@arndb.de> (raw)
In-Reply-To: <9ceff117-ad43-4513-bee0-153a93c379ce@VA3EHSMHS008.ehs.local>
Hi John,
I looked over the latest version of your patches, everything looks
good to me, but I found one problem that you have probably copied
from other platforms:
On Wednesday 30 March 2011, John Linn wrote:
> +
> +/* Allow IO space to be anywhere in the memory */
> +
> +#define IO_SPACE_LIMIT 0xffff
> +
> +/* IO address mapping macros, nothing special at this time but required */
> +
> +#ifdef __ASSEMBLER__
> +#define IOMEM(x) (x)
> +#else
> +#define IOMEM(x) ((void __force __iomem *)(x))
> +#endif
> +
> +#define __io(a) __typesafe_io(a)
> +#define __mem_pci(a) (a)
The definition of __io() looks wrong, so any call to inb()/outb()
will be a wild pointer access when you add PCI support.
If you don't plan to support PCI in the future, there should
be no problem.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: John Linn <john.linn@xilinx.com>
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux@arm.linux.org.uk,
catalin.marinas@arm.com, glikely@secretlab.ca,
jamie@jamieiles.com
Subject: Re: [PATCH V5 3/4] ARM: Xilinx: base header files and assembly macros
Date: Wed, 30 Mar 2011 13:44:45 +0200 [thread overview]
Message-ID: <201103301344.45307.arnd@arndb.de> (raw)
In-Reply-To: <9ceff117-ad43-4513-bee0-153a93c379ce@VA3EHSMHS008.ehs.local>
Hi John,
I looked over the latest version of your patches, everything looks
good to me, but I found one problem that you have probably copied
from other platforms:
On Wednesday 30 March 2011, John Linn wrote:
> +
> +/* Allow IO space to be anywhere in the memory */
> +
> +#define IO_SPACE_LIMIT 0xffff
> +
> +/* IO address mapping macros, nothing special at this time but required */
> +
> +#ifdef __ASSEMBLER__
> +#define IOMEM(x) (x)
> +#else
> +#define IOMEM(x) ((void __force __iomem *)(x))
> +#endif
> +
> +#define __io(a) __typesafe_io(a)
> +#define __mem_pci(a) (a)
The definition of __io() looks wrong, so any call to inb()/outb()
will be a wild pointer access when you add PCI support.
If you don't plan to support PCI in the future, there should
be no problem.
Arnd
next prev parent reply other threads:[~2011-03-30 11:44 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1301444651-18008-1-git-send-email-john.linn@xilinx.com>
2011-03-30 0:24 ` [PATCH V5 1/4] ARM: Xilinx: Adding Xilinx board support John Linn
2011-03-30 0:24 ` John Linn
[not found] ` <1301444651-18008-2-git-send-email-john.linn@xilinx.com>
2011-03-30 0:24 ` [PATCH V5 2/4] ARM: Xilinx: Adding timer support to the platform John Linn
2011-03-30 0:24 ` John Linn
[not found] ` <1301444651-18008-3-git-send-email-john.linn@xilinx.com>
2011-03-30 0:24 ` [PATCH V5 3/4] ARM: Xilinx: base header files and assembly macros John Linn
2011-03-30 0:24 ` John Linn
2011-03-30 11:44 ` Arnd Bergmann [this message]
2011-03-30 11:44 ` Arnd Bergmann
2011-03-30 13:17 ` John Linn
2011-03-30 13:17 ` John Linn
2011-03-30 13:29 ` Arnd Bergmann
2011-03-30 13:29 ` Arnd Bergmann
2011-03-30 13:37 ` John Linn
2011-03-30 13:37 ` John Linn
2011-03-30 19:15 ` Russell King - ARM Linux
2011-03-30 19:15 ` Russell King - ARM Linux
2011-03-30 19:43 ` Arnd Bergmann
2011-03-30 19:43 ` Arnd Bergmann
[not found] ` <1301444651-18008-4-git-send-email-john.linn@xilinx.com>
2011-03-30 0:24 ` [PATCH V5 4/4] ARM: Xilinx: Adding Xilinx platform infrastructure support John Linn
2011-03-30 0:24 ` John Linn
[not found] <1298929919-510-1-git-send-email-john.linn@xilinx.com>
[not found] ` <1298929919-510-2-git-send-email-john.linn@xilinx.com>
[not found] ` <1298929919-510-3-git-send-email-john.linn@xilinx.com>
2011-02-28 21:51 ` [PATCH V5 3/4] ARM: Xilinx: base header files and assembly macros John Linn
2011-02-28 21:51 ` John Linn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201103301344.45307.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.