[PATCH] drm/nouveau: printk info about disabled modesetting

[PATCH] drm/nouveau: printk info about disabled modesetting

[Marcin Slusarz]

... to make it obvious why nouveau refused to drive the hardware.

Signed-off-by: Marcin Slusarz <marcin.slusarz-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
---
 drivers/gpu/drm/nouveau/nouveau_drv.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/drivers/gpu/drm/nouveau/nouveau_drv.c b/drivers/gpu/drm/nouveau/nouveau_drv.c
index f658a04..515c656 100644
--- a/drivers/gpu/drm/nouveau/nouveau_drv.c
+++ b/drivers/gpu/drm/nouveau/nouveau_drv.c
@@ -445,8 +445,10 @@ static int __init nouveau_init(void)
 			nouveau_modeset = 1;
 	}
 
-	if (!nouveau_modeset)
+	if (!nouveau_modeset) {
+		printk(KERN_INFO "nouveau: modesetting disabled by kernel parameter\n");
 		return 0;
+	}
 
 	nouveau_register_dsm_handler();
 	return drm_init(&driver);
-- 
1.7.4.1

Re: [PATCH] drm/nouveau: printk info about disabled modesetting

[Marcin Slusarz]

On Mon, Apr 04, 2011 at 07:27:35PM +0200, Marcin Slusarz wrote:
> ... to make it obvious why nouveau refused to drive the hardware.
> 
> Signed-off-by: Marcin Slusarz <marcin.slusarz-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> ---
>  drivers/gpu/drm/nouveau/nouveau_drv.c |    4 +++-
>  1 files changed, 3 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/gpu/drm/nouveau/nouveau_drv.c b/drivers/gpu/drm/nouveau/nouveau_drv.c
> index f658a04..515c656 100644
> --- a/drivers/gpu/drm/nouveau/nouveau_drv.c
> +++ b/drivers/gpu/drm/nouveau/nouveau_drv.c
> @@ -445,8 +445,10 @@ static int __init nouveau_init(void)
>  			nouveau_modeset = 1;
>  	}
>  
> -	if (!nouveau_modeset)
> +	if (!nouveau_modeset) {
> +		printk(KERN_INFO "nouveau: modesetting disabled by kernel parameter\n");
>  		return 0;
> +	}
>  
>  	nouveau_register_dsm_handler();
>  	return drm_init(&driver);
> -- 

ping

Re: [PATCH] drm/nouveau: printk info about disabled modesetting

[Ben Skeggs]

On Mon, 2011-05-02 at 00:03 +0200, Marcin Slusarz wrote:
> On Mon, Apr 04, 2011 at 07:27:35PM +0200, Marcin Slusarz wrote:
> > ... to make it obvious why nouveau refused to drive the hardware.
> > 
> > Signed-off-by: Marcin Slusarz <marcin.slusarz-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> > ---
> >  drivers/gpu/drm/nouveau/nouveau_drv.c |    4 +++-
> >  1 files changed, 3 insertions(+), 1 deletions(-)
> > 
> > diff --git a/drivers/gpu/drm/nouveau/nouveau_drv.c b/drivers/gpu/drm/nouveau/nouveau_drv.c
> > index f658a04..515c656 100644
> > --- a/drivers/gpu/drm/nouveau/nouveau_drv.c
> > +++ b/drivers/gpu/drm/nouveau/nouveau_drv.c
> > @@ -445,8 +445,10 @@ static int __init nouveau_init(void)
> >  			nouveau_modeset = 1;
> >  	}
> >  
> > -	if (!nouveau_modeset)
> > +	if (!nouveau_modeset) {
> > +		printk(KERN_INFO "nouveau: modesetting disabled by kernel parameter\n");
> >  		return 0;
> > +	}
> >  
> >  	nouveau_register_dsm_handler();
> >  	return drm_init(&driver);
> > -- 
> 
> ping
I just wonder how this is useful.  I don't find it hard when looking at
people's logs to scroll to the top and look at the kernel commandline.

Really, that should be done *anyway* as there are many more options that
are relevant to what nouveau does/does not do as well...

Ben.

> 
> _______________________________________________
> Nouveau mailing list
> Nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
> http://lists.freedesktop.org/mailman/listinfo/nouveau

Re: [PATCH] drm/nouveau: printk info about disabled modesetting

[Marcin Slusarz]

On Mon, May 02, 2011 at 04:51:14PM +1000, Ben Skeggs wrote:
> On Mon, 2011-05-02 at 00:03 +0200, Marcin Slusarz wrote:
> > On Mon, Apr 04, 2011 at 07:27:35PM +0200, Marcin Slusarz wrote:
> > > ... to make it obvious why nouveau refused to drive the hardware.
> > > 
> > > Signed-off-by: Marcin Slusarz <marcin.slusarz-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> > > ---
> > >  drivers/gpu/drm/nouveau/nouveau_drv.c |    4 +++-
> > >  1 files changed, 3 insertions(+), 1 deletions(-)
> > > 
> > > diff --git a/drivers/gpu/drm/nouveau/nouveau_drv.c b/drivers/gpu/drm/nouveau/nouveau_drv.c
> > > index f658a04..515c656 100644
> > > --- a/drivers/gpu/drm/nouveau/nouveau_drv.c
> > > +++ b/drivers/gpu/drm/nouveau/nouveau_drv.c
> > > @@ -445,8 +445,10 @@ static int __init nouveau_init(void)
> > >  			nouveau_modeset = 1;
> > >  	}
> > >  
> > > -	if (!nouveau_modeset)
> > > +	if (!nouveau_modeset) {
> > > +		printk(KERN_INFO "nouveau: modesetting disabled by kernel parameter\n");
> > >  		return 0;
> > > +	}
> > >  
> > >  	nouveau_register_dsm_handler();
> > >  	return drm_init(&driver);
> > > -- 
> > 
> > ping
> I just wonder how this is useful.  I don't find it hard when looking at
> people's logs to scroll to the top and look at the kernel commandline.

It's not all about kernel commandline (but it's still nice to have it).
You can pass modeset=0 by modprobe.conf and there's no way to read it from
dmesg later.
It just simplifies troubleshooting by taking one of the most frequent reasons
of "nouveau does not detect my card"...

> Really, that should be done *anyway* as there are many more options that
> are relevant to what nouveau does/does not do as well...

Yes. But no other parameter silently disables whole module.

Marcin

Re: [PATCH] drm/nouveau: printk info about disabled modesetting

[Pekka Paalanen]

On Mon, 02 May 2011 16:51:14 +1000
Ben Skeggs <skeggsb-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:

> On Mon, 2011-05-02 at 00:03 +0200, Marcin Slusarz wrote:
> > On Mon, Apr 04, 2011 at 07:27:35PM +0200, Marcin Slusarz wrote:
> > > ... to make it obvious why nouveau refused to drive the hardware.
> > > 
> > > Signed-off-by: Marcin Slusarz <marcin.slusarz-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> > > ---
> > >  drivers/gpu/drm/nouveau/nouveau_drv.c |    4 +++-
> > >  1 files changed, 3 insertions(+), 1 deletions(-)
> > > 
> > > diff --git a/drivers/gpu/drm/nouveau/nouveau_drv.c b/drivers/gpu/drm/nouveau/nouveau_drv.c
> > > index f658a04..515c656 100644
> > > --- a/drivers/gpu/drm/nouveau/nouveau_drv.c
> > > +++ b/drivers/gpu/drm/nouveau/nouveau_drv.c
> > > @@ -445,8 +445,10 @@ static int __init nouveau_init(void)
> > >  			nouveau_modeset = 1;
> > >  	}
> > >  
> > > -	if (!nouveau_modeset)
> > > +	if (!nouveau_modeset) {
> > > +		printk(KERN_INFO "nouveau: modesetting disabled by kernel parameter\n");
> > >  		return 0;
> > > +	}
> > >  
> > >  	nouveau_register_dsm_handler();
> > >  	return drm_init(&driver);
> > > -- 
> > 
> > ping
> I just wonder how this is useful.  I don't find it hard when looking at
> people's logs to scroll to the top and look at the kernel commandline.

The kernel command line does not show module parameters.

It appears, that recently something has started to add KMS-disabling
options to modprobe.conf or equivalent, and those can be further
hidden in initramfs.

Otherwise we have to start asking to dig the parameters from sysfs
on mysterious does-not-work problems.

> Really, that should be done *anyway* as there are many more options that
> are relevant to what nouveau does/does not do as well...

Then maybe we need debug options for those, too, or does the drm core
already print the core options for some value of drm.debug?


Thanks.

-- 
Pekka Paalanen
http://www.iki.fi/pq/