* [PATCH] drm/nouveau: printk info about disabled modesetting
@ 2011-04-04 17:27 Marcin Slusarz
[not found] ` <20110404172735.GA8979-OI9uyE9O0yo@public.gmane.org>
0 siblings, 1 reply; 5+ messages in thread
From: Marcin Slusarz @ 2011-04-04 17:27 UTC (permalink / raw)
To: nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW
... to make it obvious why nouveau refused to drive the hardware.
Signed-off-by: Marcin Slusarz <marcin.slusarz-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
---
drivers/gpu/drm/nouveau/nouveau_drv.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/drivers/gpu/drm/nouveau/nouveau_drv.c b/drivers/gpu/drm/nouveau/nouveau_drv.c
index f658a04..515c656 100644
--- a/drivers/gpu/drm/nouveau/nouveau_drv.c
+++ b/drivers/gpu/drm/nouveau/nouveau_drv.c
@@ -445,8 +445,10 @@ static int __init nouveau_init(void)
nouveau_modeset = 1;
}
- if (!nouveau_modeset)
+ if (!nouveau_modeset) {
+ printk(KERN_INFO "nouveau: modesetting disabled by kernel parameter\n");
return 0;
+ }
nouveau_register_dsm_handler();
return drm_init(&driver);
--
1.7.4.1
^ permalink raw reply related [flat|nested] 5+ messages in thread[parent not found: <20110404172735.GA8979-OI9uyE9O0yo@public.gmane.org>]
* Re: [PATCH] drm/nouveau: printk info about disabled modesetting [not found] ` <20110404172735.GA8979-OI9uyE9O0yo@public.gmane.org> @ 2011-05-01 22:03 ` Marcin Slusarz [not found] ` <20110501220341.GI6742-OI9uyE9O0yo@public.gmane.org> 0 siblings, 1 reply; 5+ messages in thread From: Marcin Slusarz @ 2011-05-01 22:03 UTC (permalink / raw) To: nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW On Mon, Apr 04, 2011 at 07:27:35PM +0200, Marcin Slusarz wrote: > ... to make it obvious why nouveau refused to drive the hardware. > > Signed-off-by: Marcin Slusarz <marcin.slusarz-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> > --- > drivers/gpu/drm/nouveau/nouveau_drv.c | 4 +++- > 1 files changed, 3 insertions(+), 1 deletions(-) > > diff --git a/drivers/gpu/drm/nouveau/nouveau_drv.c b/drivers/gpu/drm/nouveau/nouveau_drv.c > index f658a04..515c656 100644 > --- a/drivers/gpu/drm/nouveau/nouveau_drv.c > +++ b/drivers/gpu/drm/nouveau/nouveau_drv.c > @@ -445,8 +445,10 @@ static int __init nouveau_init(void) > nouveau_modeset = 1; > } > > - if (!nouveau_modeset) > + if (!nouveau_modeset) { > + printk(KERN_INFO "nouveau: modesetting disabled by kernel parameter\n"); > return 0; > + } > > nouveau_register_dsm_handler(); > return drm_init(&driver); > -- ping ^ permalink raw reply [flat|nested] 5+ messages in thread
[parent not found: <20110501220341.GI6742-OI9uyE9O0yo@public.gmane.org>]
* Re: [PATCH] drm/nouveau: printk info about disabled modesetting [not found] ` <20110501220341.GI6742-OI9uyE9O0yo@public.gmane.org> @ 2011-05-02 6:51 ` Ben Skeggs 2011-05-02 16:39 ` Marcin Slusarz 2011-05-02 16:42 ` Pekka Paalanen 0 siblings, 2 replies; 5+ messages in thread From: Ben Skeggs @ 2011-05-02 6:51 UTC (permalink / raw) To: Marcin Slusarz; +Cc: nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW On Mon, 2011-05-02 at 00:03 +0200, Marcin Slusarz wrote: > On Mon, Apr 04, 2011 at 07:27:35PM +0200, Marcin Slusarz wrote: > > ... to make it obvious why nouveau refused to drive the hardware. > > > > Signed-off-by: Marcin Slusarz <marcin.slusarz-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> > > --- > > drivers/gpu/drm/nouveau/nouveau_drv.c | 4 +++- > > 1 files changed, 3 insertions(+), 1 deletions(-) > > > > diff --git a/drivers/gpu/drm/nouveau/nouveau_drv.c b/drivers/gpu/drm/nouveau/nouveau_drv.c > > index f658a04..515c656 100644 > > --- a/drivers/gpu/drm/nouveau/nouveau_drv.c > > +++ b/drivers/gpu/drm/nouveau/nouveau_drv.c > > @@ -445,8 +445,10 @@ static int __init nouveau_init(void) > > nouveau_modeset = 1; > > } > > > > - if (!nouveau_modeset) > > + if (!nouveau_modeset) { > > + printk(KERN_INFO "nouveau: modesetting disabled by kernel parameter\n"); > > return 0; > > + } > > > > nouveau_register_dsm_handler(); > > return drm_init(&driver); > > -- > > ping I just wonder how this is useful. I don't find it hard when looking at people's logs to scroll to the top and look at the kernel commandline. Really, that should be done *anyway* as there are many more options that are relevant to what nouveau does/does not do as well... Ben. > > _______________________________________________ > Nouveau mailing list > Nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org > http://lists.freedesktop.org/mailman/listinfo/nouveau ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/nouveau: printk info about disabled modesetting 2011-05-02 6:51 ` Ben Skeggs @ 2011-05-02 16:39 ` Marcin Slusarz 2011-05-02 16:42 ` Pekka Paalanen 1 sibling, 0 replies; 5+ messages in thread From: Marcin Slusarz @ 2011-05-02 16:39 UTC (permalink / raw) To: Ben Skeggs; +Cc: nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW On Mon, May 02, 2011 at 04:51:14PM +1000, Ben Skeggs wrote: > On Mon, 2011-05-02 at 00:03 +0200, Marcin Slusarz wrote: > > On Mon, Apr 04, 2011 at 07:27:35PM +0200, Marcin Slusarz wrote: > > > ... to make it obvious why nouveau refused to drive the hardware. > > > > > > Signed-off-by: Marcin Slusarz <marcin.slusarz-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> > > > --- > > > drivers/gpu/drm/nouveau/nouveau_drv.c | 4 +++- > > > 1 files changed, 3 insertions(+), 1 deletions(-) > > > > > > diff --git a/drivers/gpu/drm/nouveau/nouveau_drv.c b/drivers/gpu/drm/nouveau/nouveau_drv.c > > > index f658a04..515c656 100644 > > > --- a/drivers/gpu/drm/nouveau/nouveau_drv.c > > > +++ b/drivers/gpu/drm/nouveau/nouveau_drv.c > > > @@ -445,8 +445,10 @@ static int __init nouveau_init(void) > > > nouveau_modeset = 1; > > > } > > > > > > - if (!nouveau_modeset) > > > + if (!nouveau_modeset) { > > > + printk(KERN_INFO "nouveau: modesetting disabled by kernel parameter\n"); > > > return 0; > > > + } > > > > > > nouveau_register_dsm_handler(); > > > return drm_init(&driver); > > > -- > > > > ping > I just wonder how this is useful. I don't find it hard when looking at > people's logs to scroll to the top and look at the kernel commandline. It's not all about kernel commandline (but it's still nice to have it). You can pass modeset=0 by modprobe.conf and there's no way to read it from dmesg later. It just simplifies troubleshooting by taking one of the most frequent reasons of "nouveau does not detect my card"... > Really, that should be done *anyway* as there are many more options that > are relevant to what nouveau does/does not do as well... Yes. But no other parameter silently disables whole module. Marcin ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/nouveau: printk info about disabled modesetting 2011-05-02 6:51 ` Ben Skeggs 2011-05-02 16:39 ` Marcin Slusarz @ 2011-05-02 16:42 ` Pekka Paalanen 1 sibling, 0 replies; 5+ messages in thread From: Pekka Paalanen @ 2011-05-02 16:42 UTC (permalink / raw) To: skeggsb-Re5JQEeQqe8AvxtiuMwx3w; +Cc: nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW On Mon, 02 May 2011 16:51:14 +1000 Ben Skeggs <skeggsb-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote: > On Mon, 2011-05-02 at 00:03 +0200, Marcin Slusarz wrote: > > On Mon, Apr 04, 2011 at 07:27:35PM +0200, Marcin Slusarz wrote: > > > ... to make it obvious why nouveau refused to drive the hardware. > > > > > > Signed-off-by: Marcin Slusarz <marcin.slusarz-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> > > > --- > > > drivers/gpu/drm/nouveau/nouveau_drv.c | 4 +++- > > > 1 files changed, 3 insertions(+), 1 deletions(-) > > > > > > diff --git a/drivers/gpu/drm/nouveau/nouveau_drv.c b/drivers/gpu/drm/nouveau/nouveau_drv.c > > > index f658a04..515c656 100644 > > > --- a/drivers/gpu/drm/nouveau/nouveau_drv.c > > > +++ b/drivers/gpu/drm/nouveau/nouveau_drv.c > > > @@ -445,8 +445,10 @@ static int __init nouveau_init(void) > > > nouveau_modeset = 1; > > > } > > > > > > - if (!nouveau_modeset) > > > + if (!nouveau_modeset) { > > > + printk(KERN_INFO "nouveau: modesetting disabled by kernel parameter\n"); > > > return 0; > > > + } > > > > > > nouveau_register_dsm_handler(); > > > return drm_init(&driver); > > > -- > > > > ping > I just wonder how this is useful. I don't find it hard when looking at > people's logs to scroll to the top and look at the kernel commandline. The kernel command line does not show module parameters. It appears, that recently something has started to add KMS-disabling options to modprobe.conf or equivalent, and those can be further hidden in initramfs. Otherwise we have to start asking to dig the parameters from sysfs on mysterious does-not-work problems. > Really, that should be done *anyway* as there are many more options that > are relevant to what nouveau does/does not do as well... Then maybe we need debug options for those, too, or does the drm core already print the core options for some value of drm.debug? Thanks. -- Pekka Paalanen http://www.iki.fi/pq/ ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2011-05-02 16:42 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-04-04 17:27 [PATCH] drm/nouveau: printk info about disabled modesetting Marcin Slusarz
[not found] ` <20110404172735.GA8979-OI9uyE9O0yo@public.gmane.org>
2011-05-01 22:03 ` Marcin Slusarz
[not found] ` <20110501220341.GI6742-OI9uyE9O0yo@public.gmane.org>
2011-05-02 6:51 ` Ben Skeggs
2011-05-02 16:39 ` Marcin Slusarz
2011-05-02 16:42 ` Pekka Paalanen
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.