[PATCH] ASoC: tlv320dac33: Lower the OSC calibration time

[PATCH] ASoC: tlv320dac33: Lower the OSC calibration time

[Peter Ujfalusi]

To get correct calibration, we can decrease the time
needed for the OSC to calibrate itself.
With this change we can safe ~15ms in the OSC
calibration phase.

Signed-off-by: Peter Ujfalusi <peter.ujfalusi@nokia.com>
---
 sound/soc/codecs/tlv320dac33.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/sound/soc/codecs/tlv320dac33.c b/sound/soc/codecs/tlv320dac33.c
index c109f6d..401a7ce 100644
--- a/sound/soc/codecs/tlv320dac33.c
+++ b/sound/soc/codecs/tlv320dac33.c
@@ -946,8 +946,8 @@ static int dac33_prepare_chip(struct snd_pcm_substream *substream)
 	/* Write registers 0x08 and 0x09 (MSB, LSB) */
 	dac33_write16(codec, DAC33_INT_OSC_FREQ_RAT_A, oscset);
 
-	/* calib time: 128 is a nice number ;) */
-	dac33_write(codec, DAC33_CALIB_TIME, 128);
+	/* OSC calibration time */
+	dac33_write(codec, DAC33_CALIB_TIME, 96);
 
 	/* adjustment treshold & step */
 	dac33_write(codec, DAC33_INT_OSC_CTRL_B, DAC33_ADJTHRSHLD(2) |
-- 
1.7.4.1

Re: [PATCH] ASoC: tlv320dac33: Lower the OSC calibration time

[Lu Guanqun]

On Mon, Apr 11, 2011 at 08:57:44PM +0800, Peter Ujfalusi wrote:
> To get correct calibration, we can decrease the time
> needed for the OSC to calibrate itself.
> With this change we can safe ~15ms in the OSC

s/safe/save/

> calibration phase.
> 
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@nokia.com>
> ---
>  sound/soc/codecs/tlv320dac33.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/sound/soc/codecs/tlv320dac33.c b/sound/soc/codecs/tlv320dac33.c
> index c109f6d..401a7ce 100644
> --- a/sound/soc/codecs/tlv320dac33.c
> +++ b/sound/soc/codecs/tlv320dac33.c
> @@ -946,8 +946,8 @@ static int dac33_prepare_chip(struct snd_pcm_substream *substream)
>  	/* Write registers 0x08 and 0x09 (MSB, LSB) */
>  	dac33_write16(codec, DAC33_INT_OSC_FREQ_RAT_A, oscset);
>  
> -	/* calib time: 128 is a nice number ;) */
> -	dac33_write(codec, DAC33_CALIB_TIME, 128);
> +	/* OSC calibration time */
> +	dac33_write(codec, DAC33_CALIB_TIME, 96);
>  
>  	/* adjustment treshold & step */
>  	dac33_write(codec, DAC33_INT_OSC_CTRL_B, DAC33_ADJTHRSHLD(2) |
> -- 
> 1.7.4.1
> 
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

-- 
guanqun

Re: [PATCH] ASoC: tlv320dac33: Lower the OSC calibration time

[peter.ujfalusi]

> ________________________________________
> From: ext Lu Guanqun [guanqun.lu@intel.com]
> Sent: Monday, April 11, 2011 16:05
> To: Ujfalusi Peter (Nokia-SD/Tampere)
> Cc: alsa-devel@alsa-project.org; Mark Brown; Liam Girdwood
> Subject: Re: [alsa-devel] [PATCH] ASoC: tlv320dac33: Lower the OSC calibration time
> 
> On Mon, Apr 11, 2011 at 08:57:44PM +0800, Peter Ujfalusi wrote:
> > To get correct calibration, we can decrease the time
> > needed for the OSC to calibrate itself.
> > With this change we can safe ~15ms in the OSC
> 
> s/safe/save/

Argh, thanks for noticing it, I'll resend it with the fixed message.

> 
> > calibration phase.
> >
> > Signed-off-by: Peter Ujfalusi <peter.ujfalusi@nokia.com>

Peter

Re: [PATCH] ASoC: tlv320dac33: Lower the OSC calibration time

[Mark Brown]

On Mon, Apr 11, 2011 at 03:57:44PM +0300, Peter Ujfalusi wrote:
> To get correct calibration, we can decrease the time
> needed for the OSC to calibrate itself.
> With this change we can safe ~15ms in the OSC
> calibration phase.
> 
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@nokia.com>

Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>