From: Greg KH <greg@kroah.com>
To: "Rafał Miłecki" <zajec5@gmail.com>
Cc: linux-wireless@vger.kernel.org,
"John W. Linville" <linville@tuxdriver.com>,
"George Kashperko" <george@znau.edu.ua>,
"Arnd Bergmann" <arnd@arndb.de>,
"Russell King" <rmk@arm.linux.org.uk>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
b43-dev@lists.infradead.org, "Michael Büsch" <mb@bu3sch.de>,
linuxdriverproject <devel@linuxdriverproject.org>,
"Andy Botting" <andy@andybotting.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"Larry Finger" <Larry.Finger@lwfinger.net>
Subject: Re: [RFC][PATCH V3] axi: add AXI bus driver
Date: Mon, 11 Apr 2011 14:25:13 -0700 [thread overview]
Message-ID: <20110411212513.GA17809@kroah.com> (raw)
In-Reply-To: <BANLkTim155YxMUVJ=pmVs-rNhkovGPG6OQ@mail.gmail.com>
On Mon, Apr 11, 2011 at 11:19:13PM +0200, Rafał Miłecki wrote:
> 2011/4/11 Greg KH <greg@kroah.com>:
> > On Mon, Apr 11, 2011 at 11:25:14PM +0200, Rafał Miłecki wrote:
> >> +static void axi_release_core_dev(struct device *dev)
> >> +{
> >> + /* Silent lack-of-release warning */
> >> +}
> >
> > Ok, WTF!!!!
>
> Thank you for your kindly words. It's much more enjoyable to work on
> kernel that way. I definitely made that on purpose.
I can't tell if you are kidding or not.
Please read the documentation for how to do this properly. I find it
really hard to believe that you wrote that comment instead of putting in
the 2 lines of code required for this function.
Especially as-it-is, your code does not work properly and leaks memory
badly. Why would you do that on purpose?
thanks,
greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: greg@kroah.com (Greg KH)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC][PATCH V3] axi: add AXI bus driver
Date: Mon, 11 Apr 2011 14:25:13 -0700 [thread overview]
Message-ID: <20110411212513.GA17809@kroah.com> (raw)
In-Reply-To: <BANLkTim155YxMUVJ=pmVs-rNhkovGPG6OQ@mail.gmail.com>
On Mon, Apr 11, 2011 at 11:19:13PM +0200, Rafa? Mi?ecki wrote:
> 2011/4/11 Greg KH <greg@kroah.com>:
> > On Mon, Apr 11, 2011 at 11:25:14PM +0200, Rafa? Mi?ecki wrote:
> >> +static void axi_release_core_dev(struct device *dev)
> >> +{
> >> + ? ? /* Silent lack-of-release warning */
> >> +}
> >
> > Ok, WTF!!!!
>
> Thank you for your kindly words. It's much more enjoyable to work on
> kernel that way. I definitely made that on purpose.
I can't tell if you are kidding or not.
Please read the documentation for how to do this properly. I find it
really hard to believe that you wrote that comment instead of putting in
the 2 lines of code required for this function.
Especially as-it-is, your code does not work properly and leaks memory
badly. Why would you do that on purpose?
thanks,
greg k-h
next prev parent reply other threads:[~2011-04-11 21:25 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-11 21:25 [RFC][PATCH V3] axi: add AXI bus driver Rafał Miłecki
2011-07-08 18:29 ` Rafał Miłecki
2011-04-11 21:25 ` Rafał Miłecki
2011-04-11 21:06 ` Greg KH
2011-04-11 21:06 ` Greg KH
2011-04-11 21:19 ` Rafał Miłecki
2011-04-11 21:19 ` Rafał Miłecki
2011-04-11 21:19 ` Rafał Miłecki
2011-04-11 21:25 ` Greg KH [this message]
2011-04-11 21:25 ` Greg KH
2011-04-11 21:36 ` Rafał Miłecki
2011-04-11 21:36 ` Rafał Miłecki
2011-04-11 21:36 ` Rafał Miłecki
2011-04-11 21:56 ` Greg KH
2011-04-11 21:56 ` Greg KH
2011-04-11 22:12 ` Rafał Miłecki
2011-04-11 22:12 ` Rafał Miłecki
2011-04-11 22:12 ` Rafał Miłecki
2011-04-11 22:36 ` Greg KH
2011-04-11 22:36 ` Greg KH
2011-04-11 22:45 ` Rafał Miłecki
2011-04-11 22:45 ` Rafał Miłecki
2011-04-11 22:45 ` Rafał Miłecki
2011-04-11 23:35 ` Greg KH
2011-04-11 23:35 ` Greg KH
2011-04-12 5:41 ` Rafał Miłecki
2011-04-12 5:41 ` Rafał Miłecki
2011-04-12 5:41 ` Rafał Miłecki
2011-04-12 11:40 ` Rafał Miłecki
2011-04-12 11:40 ` Rafał Miłecki
2011-04-12 11:40 ` Rafał Miłecki
2011-04-12 15:16 ` Greg KH
2011-04-12 15:16 ` Greg KH
2011-04-12 15:14 ` Greg KH
2011-04-12 15:14 ` Greg KH
2011-04-12 15:25 ` Rafał Miłecki
2011-04-12 15:25 ` Rafał Miłecki
2011-04-12 15:25 ` Rafał Miłecki
2011-04-11 21:07 ` Greg KH
2011-04-11 21:07 ` Greg KH
2011-04-11 23:44 ` Joe Perches
2011-04-11 23:44 ` Joe Perches
2011-04-12 5:52 ` Rafał Miłecki
2011-04-12 5:52 ` Rafał Miłecki
2011-04-12 5:52 ` Rafał Miłecki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110411212513.GA17809@kroah.com \
--to=greg@kroah.com \
--cc=Larry.Finger@lwfinger.net \
--cc=andy@andybotting.com \
--cc=arnd@arndb.de \
--cc=b43-dev@lists.infradead.org \
--cc=devel@linuxdriverproject.org \
--cc=george@znau.edu.ua \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mb@bu3sch.de \
--cc=rmk@arm.linux.org.uk \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.