All of lore.kernel.org
 help / color / mirror / Atom feed
From: Russ Anderson <rja@sgi.com>
To: Borislav Petkov <bp@alien8.de>,
	Prarit Bhargava <prarit@redhat.com>,
	"Luck, Tony" <tony.luck@intel.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"dzickus@redhat.com" <dzickus@redhat.com>,
	"mstowe@redhat.com" <mstowe@redhat.com>,
	"dnelson@redhat.com" <dnelson@redhat.com>
Cc: rja@americas.sgi.com
Subject: Re: [PATCH]: mce: don't print "human readable" message for corrected errors
Date: Tue, 12 Apr 2011 22:00:34 -0500	[thread overview]
Message-ID: <20110413030033.GB31652@sgi.com> (raw)
In-Reply-To: <20110412202854.GA32200@liondog.tnic>

On Tue, Apr 12, 2011 at 10:28:54PM +0200, Borislav Petkov wrote:
> 
> Yeah, there's the TAINT thing too, good point Tony. Well, we definitely
> don't want to get tainted for correctable errors - they're too "normal"
> to do so, IMHO.

I agreed.

> I'm thinking remove the TAINT for CEs and don't call the default
> notifier if it is the only notifier call registered. Maybe something like
> 
> 	if (num_notifiers(&x86_mce_decoder_chain) > 1)
> 		atomic_notifier_call_chain(&x86_mce_decoder_chain, 0, &m);
> 
> or since the notifiers are priority sorted, don't call notifiers with -1
> prio.
> 
> Or something to that effect.

What is the point of having a default notifier if it doesn't get called?

Any consideration of adding thresholding (ie only log the first X number
of corrected errors) as is done on IA64?  (see arch/ia64/kernel/mca.c)

Thanks,
-- 
Russ Anderson, OS RAS/Partitioning Project Lead  
SGI - Silicon Graphics Inc          rja@sgi.com

  reply	other threads:[~2011-04-13  3:00 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-12 17:44 [PATCH]: mce: don't print "human readable" message for corrected errors Prarit Bhargava
2011-04-12 18:58 ` Borislav Petkov
2011-04-12 19:22   ` Prarit Bhargava
2011-04-12 19:57     ` Borislav Petkov
2011-04-12 20:02   ` Luck, Tony
2011-04-12 20:15     ` Prarit Bhargava
2011-04-12 20:28       ` Borislav Petkov
2011-04-13  3:00         ` Russ Anderson [this message]
2011-04-13  7:14           ` Borislav Petkov
2011-04-13 13:24             ` Borislav Petkov
2011-04-13 13:36               ` [PATCH 1/3] x86, MCE: Do not taint when correctable errors Borislav Petkov
2011-04-13 13:36               ` [PATCH 2/3] x86, MCE: Drop default decoding notifier Borislav Petkov
2011-04-13 14:01                 ` Prarit Bhargava
2011-04-13 14:18                   ` Borislav Petkov
2011-04-13 14:22                     ` Prarit Bhargava
2011-04-13 14:26                       ` Borislav Petkov
2011-04-13 14:32                         ` Prarit Bhargava
2011-04-13 14:39                           ` Borislav Petkov
2011-04-13 14:45                             ` Prarit Bhargava
2011-04-13 14:36                         ` [PATCH -v2] " Borislav Petkov
2011-04-13 17:01                           ` Prarit Bhargava
2011-04-13 17:13                             ` Luck, Tony
2011-04-13 17:17                               ` Prarit Bhargava
2011-04-13 17:14                             ` Prarit Bhargava
2011-04-13 17:37                               ` Borislav Petkov
2011-04-14 14:59                                 ` Prarit Bhargava
2011-04-14 15:00                                 ` [PATCH -v3] x86, MCE: Drop the " Borislav Petkov
2011-04-14 15:04                                   ` Prarit Bhargava
2011-04-14 15:16                                     ` Borislav Petkov
2011-04-14 15:23                                       ` Prarit Bhargava
2011-04-14 15:44                                         ` Borislav Petkov
2011-04-14 15:49                                           ` Prarit Bhargava
2011-04-14 19:02                                             ` Borislav Petkov
2011-04-14 19:04                                               ` Prarit Bhargava
2011-04-14 15:33                                       ` Russ Anderson
2011-04-14 15:49                                         ` Borislav Petkov
2011-04-13 13:36               ` [PATCH 3/3] EDAC, MCE, AMD: Register with MCE core Borislav Petkov
2011-04-13  2:24     ` [PATCH]: mce: don't print "human readable" message for corrected errors Russ Anderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110413030033.GB31652@sgi.com \
    --to=rja@sgi.com \
    --cc=bp@alien8.de \
    --cc=dnelson@redhat.com \
    --cc=dzickus@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mstowe@redhat.com \
    --cc=prarit@redhat.com \
    --cc=rja@americas.sgi.com \
    --cc=tony.luck@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.