All of lore.kernel.org
 help / color / mirror / Atom feed
From: Borislav Petkov <bp@amd64.org>
To: Prarit Bhargava <prarit@redhat.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Russ Anderson <rja@sgi.com>, "Luck, Tony" <tony.luck@intel.com>,
	"dzickus@redhat.com" <dzickus@redhat.com>,
	"mstowe@redhat.com" <mstowe@redhat.com>,
	"dnelson@redhat.com" <dnelson@redhat.com>,
	"rja@americas.sgi.com" <rja@americas.sgi.com>
Subject: Re: [PATCH 2/3] x86, MCE: Drop default decoding notifier
Date: Wed, 13 Apr 2011 16:39:17 +0200	[thread overview]
Message-ID: <20110413143917.GD2791@aftab> (raw)
In-Reply-To: <4DA5B403.2010203@redhat.com>

On Wed, Apr 13, 2011 at 10:32:35AM -0400, Prarit Bhargava wrote:
> 
> >> .. right ... but we would still see nonsensical messages before the
> >> panic, which will confuse the end user.  IMO, dump the messages unless
> >> it's UC.  And we shouldn't print out the human readable message at all.
> >>     
> > I'd still leave the "mcelog ... " line though as a hint.
> >
> >   
> 
> :)
> 
> There are no messages -- that's part of the problem.  We're asking a
> user to do something for a message that doesn't exist ...

Yes and no - in the UC case you get all the MCA registers dumped in
print_mce() - and those you want to decode. In the CE case, we won't be
issuing any with the default notifier removed. I just sent you a -v2, I
think it should do what we want.

Or am I missing something...?

Thanks.

-- 
Regards/Gruss,
Boris.

Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach
General Managers: Alberto Bozzo, Andrew Bowd
Registration: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632

  reply	other threads:[~2011-04-13 14:39 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-12 17:44 [PATCH]: mce: don't print "human readable" message for corrected errors Prarit Bhargava
2011-04-12 18:58 ` Borislav Petkov
2011-04-12 19:22   ` Prarit Bhargava
2011-04-12 19:57     ` Borislav Petkov
2011-04-12 20:02   ` Luck, Tony
2011-04-12 20:15     ` Prarit Bhargava
2011-04-12 20:28       ` Borislav Petkov
2011-04-13  3:00         ` Russ Anderson
2011-04-13  7:14           ` Borislav Petkov
2011-04-13 13:24             ` Borislav Petkov
2011-04-13 13:36               ` [PATCH 1/3] x86, MCE: Do not taint when correctable errors Borislav Petkov
2011-04-13 13:36               ` [PATCH 2/3] x86, MCE: Drop default decoding notifier Borislav Petkov
2011-04-13 14:01                 ` Prarit Bhargava
2011-04-13 14:18                   ` Borislav Petkov
2011-04-13 14:22                     ` Prarit Bhargava
2011-04-13 14:26                       ` Borislav Petkov
2011-04-13 14:32                         ` Prarit Bhargava
2011-04-13 14:39                           ` Borislav Petkov [this message]
2011-04-13 14:45                             ` Prarit Bhargava
2011-04-13 14:36                         ` [PATCH -v2] " Borislav Petkov
2011-04-13 17:01                           ` Prarit Bhargava
2011-04-13 17:13                             ` Luck, Tony
2011-04-13 17:17                               ` Prarit Bhargava
2011-04-13 17:14                             ` Prarit Bhargava
2011-04-13 17:37                               ` Borislav Petkov
2011-04-14 14:59                                 ` Prarit Bhargava
2011-04-14 15:00                                 ` [PATCH -v3] x86, MCE: Drop the " Borislav Petkov
2011-04-14 15:04                                   ` Prarit Bhargava
2011-04-14 15:16                                     ` Borislav Petkov
2011-04-14 15:23                                       ` Prarit Bhargava
2011-04-14 15:44                                         ` Borislav Petkov
2011-04-14 15:49                                           ` Prarit Bhargava
2011-04-14 19:02                                             ` Borislav Petkov
2011-04-14 19:04                                               ` Prarit Bhargava
2011-04-14 15:33                                       ` Russ Anderson
2011-04-14 15:49                                         ` Borislav Petkov
2011-04-13 13:36               ` [PATCH 3/3] EDAC, MCE, AMD: Register with MCE core Borislav Petkov
2011-04-13  2:24     ` [PATCH]: mce: don't print "human readable" message for corrected errors Russ Anderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110413143917.GD2791@aftab \
    --to=bp@amd64.org \
    --cc=dnelson@redhat.com \
    --cc=dzickus@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mstowe@redhat.com \
    --cc=prarit@redhat.com \
    --cc=rja@americas.sgi.com \
    --cc=rja@sgi.com \
    --cc=tony.luck@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.