From: Prarit Bhargava <prarit@redhat.com>
To: Borislav Petkov <bp@amd64.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Russ Anderson <rja@sgi.com>, "Luck, Tony" <tony.luck@intel.com>,
"dzickus@redhat.com" <dzickus@redhat.com>,
"mstowe@redhat.com" <mstowe@redhat.com>,
"dnelson@redhat.com" <dnelson@redhat.com>,
"rja@americas.sgi.com" <rja@americas.sgi.com>
Subject: Re: [PATCH -v2] x86, MCE: Drop default decoding notifier
Date: Wed, 13 Apr 2011 13:01:00 -0400 [thread overview]
Message-ID: <4DA5D6CC.9090500@redhat.com> (raw)
In-Reply-To: <20110413143642.GC2791@aftab>
> @@ -239,7 +227,9 @@ static void print_mce(struct mce *m)
> * Print out human-readable details about the MCE error,
> * (if the CPU has an implementation for that)
> */
> - atomic_notifier_call_chain(&x86_mce_decoder_chain, 0, m);
> + ret = atomic_notifier_call_chain(&x86_mce_decoder_chain, 0, m);
> + if (ret != NOTIFY_STOP)
> + pr_emerg(HW_ERR "Run the above through 'mcelog --ascii' to decode.\n");
> }
>
Borislav,
I still think you need the check for UC here. When an UC occurs and
mce_panic() is called the output will include:
[Hardware Error]: Run the above through 'mcelog --ascii' to decode.
potentially many, many times. The problem still is that there is no
output to decode (in the default case).
P.
next prev parent reply other threads:[~2011-04-13 17:01 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-12 17:44 [PATCH]: mce: don't print "human readable" message for corrected errors Prarit Bhargava
2011-04-12 18:58 ` Borislav Petkov
2011-04-12 19:22 ` Prarit Bhargava
2011-04-12 19:57 ` Borislav Petkov
2011-04-12 20:02 ` Luck, Tony
2011-04-12 20:15 ` Prarit Bhargava
2011-04-12 20:28 ` Borislav Petkov
2011-04-13 3:00 ` Russ Anderson
2011-04-13 7:14 ` Borislav Petkov
2011-04-13 13:24 ` Borislav Petkov
2011-04-13 13:36 ` [PATCH 1/3] x86, MCE: Do not taint when correctable errors Borislav Petkov
2011-04-13 13:36 ` [PATCH 2/3] x86, MCE: Drop default decoding notifier Borislav Petkov
2011-04-13 14:01 ` Prarit Bhargava
2011-04-13 14:18 ` Borislav Petkov
2011-04-13 14:22 ` Prarit Bhargava
2011-04-13 14:26 ` Borislav Petkov
2011-04-13 14:32 ` Prarit Bhargava
2011-04-13 14:39 ` Borislav Petkov
2011-04-13 14:45 ` Prarit Bhargava
2011-04-13 14:36 ` [PATCH -v2] " Borislav Petkov
2011-04-13 17:01 ` Prarit Bhargava [this message]
2011-04-13 17:13 ` Luck, Tony
2011-04-13 17:17 ` Prarit Bhargava
2011-04-13 17:14 ` Prarit Bhargava
2011-04-13 17:37 ` Borislav Petkov
2011-04-14 14:59 ` Prarit Bhargava
2011-04-14 15:00 ` [PATCH -v3] x86, MCE: Drop the " Borislav Petkov
2011-04-14 15:04 ` Prarit Bhargava
2011-04-14 15:16 ` Borislav Petkov
2011-04-14 15:23 ` Prarit Bhargava
2011-04-14 15:44 ` Borislav Petkov
2011-04-14 15:49 ` Prarit Bhargava
2011-04-14 19:02 ` Borislav Petkov
2011-04-14 19:04 ` Prarit Bhargava
2011-04-14 15:33 ` Russ Anderson
2011-04-14 15:49 ` Borislav Petkov
2011-04-13 13:36 ` [PATCH 3/3] EDAC, MCE, AMD: Register with MCE core Borislav Petkov
2011-04-13 2:24 ` [PATCH]: mce: don't print "human readable" message for corrected errors Russ Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DA5D6CC.9090500@redhat.com \
--to=prarit@redhat.com \
--cc=bp@amd64.org \
--cc=dnelson@redhat.com \
--cc=dzickus@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mstowe@redhat.com \
--cc=rja@americas.sgi.com \
--cc=rja@sgi.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.