[PATCH] USB: OHCI: Fix build warning on Alchemy

[PATCH] USB: OHCI: Fix build warning on Alchemy

[Ralf Baechle]

  CC      drivers/usb/host/ohci-hcd.o
In file included from drivers/usb/host/ohci-hcd.c:1028:0:
drivers/usb/host/ohci-au1xxx.c:36:7: warning: "__BIG_ENDIAN" is not defined [-Wundef]

Fix the warning and some other build bullet proofing; let's not rely on
other needed header files getting dragged in magically.

Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
---

 drivers/usb/host/ohci-au1xxx.c |    7 +++++--
 1 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/drivers/usb/host/ohci-au1xxx.c b/drivers/usb/host/ohci-au1xxx.c
index 17a6043..0723990 100644
--- a/drivers/usb/host/ohci-au1xxx.c
+++ b/drivers/usb/host/ohci-au1xxx.c
@@ -19,7 +19,10 @@
  */
 
 #include <linux/platform_device.h>
-#include <linux/signal.h>
+#include <linux/interrupt.h>
+#include <linux/usb.h>
+#include <linux/usb/hcd.h>
+#include <asm/byteorder.h>
 
 #include <asm/mach-au1x00/au1000.h>
 
@@ -33,7 +36,7 @@
 
 #ifdef __LITTLE_ENDIAN
 #define USBH_ENABLE_INIT (USBH_ENABLE_CE | USBH_ENABLE_E | USBH_ENABLE_C)
-#elif __BIG_ENDIAN
+#elif defined(__BIG_ENDIAN)
 #define USBH_ENABLE_INIT (USBH_ENABLE_CE | USBH_ENABLE_E | USBH_ENABLE_C | \
 			  USBH_ENABLE_BE)
 #else

Re: [PATCH] USB: OHCI: Fix build warning on Alchemy

[Greg KH]

On Thu, Apr 14, 2011 at 01:23:08AM +0200, Ralf Baechle wrote:
>   CC      drivers/usb/host/ohci-hcd.o
> In file included from drivers/usb/host/ohci-hcd.c:1028:0:
> drivers/usb/host/ohci-au1xxx.c:36:7: warning: "__BIG_ENDIAN" is not defined [-Wundef]
> 
> Fix the warning and some other build bullet proofing; let's not rely on
> other needed header files getting dragged in magically.

Ick, I just applied the second part of this patch to my "for-linus"
tree as a patch from someone else.  Are the #include changes really
needed right now?

thanks,

greg k-h

Re: [PATCH] USB: OHCI: Fix build warning on Alchemy

[Ralf Baechle]

On Wed, Apr 13, 2011 at 04:43:17PM -0700, Greg KH wrote:

> On Thu, Apr 14, 2011 at 01:23:08AM +0200, Ralf Baechle wrote:
> >   CC      drivers/usb/host/ohci-hcd.o
> > In file included from drivers/usb/host/ohci-hcd.c:1028:0:
> > drivers/usb/host/ohci-au1xxx.c:36:7: warning: "__BIG_ENDIAN" is not defined [-Wundef]
> > 
> > Fix the warning and some other build bullet proofing; let's not rely on
> > other needed header files getting dragged in magically.
> 
> Ick, I just applied the second part of this patch to my "for-linus"
> tree as a patch from someone else.  Are the #include changes really
> needed right now?

No, the include stuff was more for paranoia.

However the warning fixed by the 2nd part of the patch exists back to
at least 2.6.27.

  Ralf

Re: [PATCH] USB: OHCI: Fix build warning on Alchemy

[Greg KH]

On Thu, Apr 14, 2011 at 02:31:24AM +0200, Ralf Baechle wrote:
> On Wed, Apr 13, 2011 at 04:43:17PM -0700, Greg KH wrote:
> 
> > On Thu, Apr 14, 2011 at 01:23:08AM +0200, Ralf Baechle wrote:
> > >   CC      drivers/usb/host/ohci-hcd.o
> > > In file included from drivers/usb/host/ohci-hcd.c:1028:0:
> > > drivers/usb/host/ohci-au1xxx.c:36:7: warning: "__BIG_ENDIAN" is not defined [-Wundef]
> > > 
> > > Fix the warning and some other build bullet proofing; let's not rely on
> > > other needed header files getting dragged in magically.
> > 
> > Ick, I just applied the second part of this patch to my "for-linus"
> > tree as a patch from someone else.  Are the #include changes really
> > needed right now?
> 
> No, the include stuff was more for paranoia.
> 
> However the warning fixed by the 2nd part of the patch exists back to
> at least 2.6.27.

Ah, it's not that much of a rush then :)

thanks,

greg k-h