From: Wu Fengguang <fengguang.wu@intel.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Jan Kara <jack@suse.cz>, Wu Fengguang <fengguang.wu@intel.com>
Cc: Christoph Hellwig <hch@lst.de>
Cc: Trond Myklebust <Trond.Myklebust@netapp.com>
Cc: Dave Chinner <david@fromorbit.com>
Cc: "Theodore Ts'o" <tytso@mit.edu>
Cc: Chris Mason <chris.mason@oracle.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Mel Gorman <mel@csn.ul.ie>
Cc: Rik van Riel <riel@redhat.com>
Cc: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Cc: Greg Thelen <gthelen@google.com>
Cc: Minchan Kim <minchan.kim@gmail.com>
Cc: Vivek Goyal <vgoyal@redhat.com>
Cc: Andrea Righi <arighi@develer.com>
Cc: Balbir Singh <balbir@linux.vnet.ibm.com>
Cc: linux-mm <linux-mm@kvack.org>
Cc: <linux-fsdevel@vger.kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH 10/12] writeback: trace dirty_ratelimit
Date: Sat, 16 Apr 2011 21:25:56 +0800 [thread overview]
Message-ID: <20110416134333.693350038@intel.com> (raw)
In-Reply-To: 20110416132546.765212221@intel.com
[-- Attachment #1: writeback-trace-throttle-bandwidth.patch --]
[-- Type: text/plain, Size: 2801 bytes --]
It provides critical information to understand how various throttle
bandwidths are updated.
Signed-off-by: Wu Fengguang <fengguang.wu@intel.com>
---
include/trace/events/writeback.h | 51 +++++++++++++++++++++++++++--
mm/page-writeback.c | 1
2 files changed, 49 insertions(+), 3 deletions(-)
--- linux-next.orig/mm/page-writeback.c 2011-04-16 11:28:21.000000000 +0800
+++ linux-next/mm/page-writeback.c 2011-04-16 11:28:27.000000000 +0800
@@ -974,6 +974,7 @@ adjust:
bdi->dirty_ratelimit = bw;
out:
bdi_update_reference_ratelimit(bdi, ref_bw);
+ trace_dirty_ratelimit(bdi, dirty_bw, pos_bw, ref_bw);
}
void bdi_update_bandwidth(struct backing_dev_info *bdi,
--- linux-next.orig/include/trace/events/writeback.h 2011-04-16 11:28:17.000000000 +0800
+++ linux-next/include/trace/events/writeback.h 2011-04-16 11:28:27.000000000 +0800
@@ -147,11 +147,56 @@ DEFINE_EVENT(wbc_class, name, \
DEFINE_WBC_EVENT(wbc_writeback_start);
DEFINE_WBC_EVENT(wbc_writeback_written);
DEFINE_WBC_EVENT(wbc_writeback_wait);
-DEFINE_WBC_EVENT(wbc_balance_dirty_start);
-DEFINE_WBC_EVENT(wbc_balance_dirty_written);
-DEFINE_WBC_EVENT(wbc_balance_dirty_wait);
DEFINE_WBC_EVENT(wbc_writepage);
+#define KBps(x) ((x) << (PAGE_SHIFT - 10))
+
+TRACE_EVENT(dirty_ratelimit,
+
+ TP_PROTO(struct backing_dev_info *bdi,
+ unsigned long dirty_bw,
+ unsigned long pos_bw,
+ unsigned long ref_bw),
+
+ TP_ARGS(bdi, dirty_bw, pos_bw, ref_bw),
+
+ TP_STRUCT__entry(
+ __array(char, bdi, 32)
+ __field(unsigned long, write_bw)
+ __field(unsigned long, avg_bw)
+ __field(unsigned long, dirty_bw)
+ __field(unsigned long, base_bw)
+ __field(unsigned long, pos_bw)
+ __field(unsigned long, ref_bw)
+ __field(unsigned long, avg_ref_bw)
+ ),
+
+ TP_fast_assign(
+ strlcpy(__entry->bdi, dev_name(bdi->dev), 32);
+ __entry->write_bw = KBps(bdi->write_bandwidth);
+ __entry->avg_bw = KBps(bdi->avg_write_bandwidth);
+ __entry->dirty_bw = KBps(dirty_bw);
+ __entry->base_bw = KBps(bdi->dirty_ratelimit);
+ __entry->pos_bw = KBps(pos_bw);
+ __entry->ref_bw = KBps(ref_bw);
+ __entry->avg_ref_bw = KBps(bdi->reference_ratelimit);
+ ),
+
+
+ TP_printk("bdi %s: "
+ "write_bw=%lu awrite_bw=%lu dirty_bw=%lu "
+ "base_bw=%lu pos_bw=%lu ref_bw=%lu aref_bw=%lu",
+ __entry->bdi,
+ __entry->write_bw, /* write bandwidth */
+ __entry->avg_bw, /* avg write bandwidth */
+ __entry->dirty_bw, /* dirty bandwidth */
+ __entry->base_bw, /* dirty ratelimit on each task */
+ __entry->pos_bw, /* position control ratelimit */
+ __entry->ref_bw, /* the reference ratelimit */
+ __entry->avg_ref_bw /* smoothed reference ratelimit */
+ )
+);
+
DECLARE_EVENT_CLASS(writeback_congest_waited_template,
TP_PROTO(unsigned int usec_timeout, unsigned int usec_delayed),
WARNING: multiple messages have this Message-ID (diff)
From: Wu Fengguang <fengguang.wu@intel.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Jan Kara <jack@suse.cz>, Wu Fengguang <fengguang.wu@intel.com>,
Christoph Hellwig <hch@lst.de>,
Trond Myklebust <Trond.Myklebust@netapp.com>,
Dave Chinner <david@fromorbit.com>, Theodore Ts'o <tytso@mit.edu>,
Chris Mason <chris.mason@oracle.com>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Mel Gorman <mel@csn.ul.ie>, Rik van Riel <riel@redhat.com>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
Greg Thelen <gthelen@google.com>,
Minchan Kim <minchan.kim@gmail.com>,
Vivek Goyal <vgoyal@redhat.com>,
Andrea Righi <arighi@develer.com>,
Balbir Singh <balbir@linux.vnet.ibm.com>,
linux-mm <linux-mm@kvack.org>,
linux-fsdevel@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH 10/12] writeback: trace dirty_ratelimit
Date: Sat, 16 Apr 2011 21:25:56 +0800 [thread overview]
Message-ID: <20110416134333.693350038@intel.com> (raw)
In-Reply-To: 20110416132546.765212221@intel.com
[-- Attachment #1: writeback-trace-throttle-bandwidth.patch --]
[-- Type: text/plain, Size: 3104 bytes --]
It provides critical information to understand how various throttle
bandwidths are updated.
Signed-off-by: Wu Fengguang <fengguang.wu@intel.com>
---
include/trace/events/writeback.h | 51 +++++++++++++++++++++++++++--
mm/page-writeback.c | 1
2 files changed, 49 insertions(+), 3 deletions(-)
--- linux-next.orig/mm/page-writeback.c 2011-04-16 11:28:21.000000000 +0800
+++ linux-next/mm/page-writeback.c 2011-04-16 11:28:27.000000000 +0800
@@ -974,6 +974,7 @@ adjust:
bdi->dirty_ratelimit = bw;
out:
bdi_update_reference_ratelimit(bdi, ref_bw);
+ trace_dirty_ratelimit(bdi, dirty_bw, pos_bw, ref_bw);
}
void bdi_update_bandwidth(struct backing_dev_info *bdi,
--- linux-next.orig/include/trace/events/writeback.h 2011-04-16 11:28:17.000000000 +0800
+++ linux-next/include/trace/events/writeback.h 2011-04-16 11:28:27.000000000 +0800
@@ -147,11 +147,56 @@ DEFINE_EVENT(wbc_class, name, \
DEFINE_WBC_EVENT(wbc_writeback_start);
DEFINE_WBC_EVENT(wbc_writeback_written);
DEFINE_WBC_EVENT(wbc_writeback_wait);
-DEFINE_WBC_EVENT(wbc_balance_dirty_start);
-DEFINE_WBC_EVENT(wbc_balance_dirty_written);
-DEFINE_WBC_EVENT(wbc_balance_dirty_wait);
DEFINE_WBC_EVENT(wbc_writepage);
+#define KBps(x) ((x) << (PAGE_SHIFT - 10))
+
+TRACE_EVENT(dirty_ratelimit,
+
+ TP_PROTO(struct backing_dev_info *bdi,
+ unsigned long dirty_bw,
+ unsigned long pos_bw,
+ unsigned long ref_bw),
+
+ TP_ARGS(bdi, dirty_bw, pos_bw, ref_bw),
+
+ TP_STRUCT__entry(
+ __array(char, bdi, 32)
+ __field(unsigned long, write_bw)
+ __field(unsigned long, avg_bw)
+ __field(unsigned long, dirty_bw)
+ __field(unsigned long, base_bw)
+ __field(unsigned long, pos_bw)
+ __field(unsigned long, ref_bw)
+ __field(unsigned long, avg_ref_bw)
+ ),
+
+ TP_fast_assign(
+ strlcpy(__entry->bdi, dev_name(bdi->dev), 32);
+ __entry->write_bw = KBps(bdi->write_bandwidth);
+ __entry->avg_bw = KBps(bdi->avg_write_bandwidth);
+ __entry->dirty_bw = KBps(dirty_bw);
+ __entry->base_bw = KBps(bdi->dirty_ratelimit);
+ __entry->pos_bw = KBps(pos_bw);
+ __entry->ref_bw = KBps(ref_bw);
+ __entry->avg_ref_bw = KBps(bdi->reference_ratelimit);
+ ),
+
+
+ TP_printk("bdi %s: "
+ "write_bw=%lu awrite_bw=%lu dirty_bw=%lu "
+ "base_bw=%lu pos_bw=%lu ref_bw=%lu aref_bw=%lu",
+ __entry->bdi,
+ __entry->write_bw, /* write bandwidth */
+ __entry->avg_bw, /* avg write bandwidth */
+ __entry->dirty_bw, /* dirty bandwidth */
+ __entry->base_bw, /* dirty ratelimit on each task */
+ __entry->pos_bw, /* position control ratelimit */
+ __entry->ref_bw, /* the reference ratelimit */
+ __entry->avg_ref_bw /* smoothed reference ratelimit */
+ )
+);
+
DECLARE_EVENT_CLASS(writeback_congest_waited_template,
TP_PROTO(unsigned int usec_timeout, unsigned int usec_delayed),
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-04-16 14:03 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-16 13:25 [PATCH 00/12] IO-less dirty throttling v7 Wu Fengguang
2011-04-16 13:25 ` Wu Fengguang
2011-04-16 13:25 ` Wu Fengguang
2011-04-16 13:25 ` [PATCH 01/12] writeback: account per-bdi accumulated written pages Wu Fengguang
2011-04-16 13:25 ` Wu Fengguang
2011-04-16 13:25 ` Wu Fengguang
2011-04-16 13:25 ` [PATCH 02/12] writeback: account per-bdi accumulated dirtied pages Wu Fengguang
2011-04-16 13:25 ` Wu Fengguang
2011-04-16 13:25 ` [PATCH 03/12] writeback: bdi write bandwidth estimation Wu Fengguang
2011-04-16 13:25 ` Wu Fengguang
2011-04-16 13:25 ` Wu Fengguang
2011-04-16 13:25 ` [PATCH 04/12] writeback: smoothed global/bdi dirty pages Wu Fengguang
2011-04-16 13:25 ` Wu Fengguang
2011-04-16 13:25 ` Wu Fengguang
2011-04-16 13:25 ` [PATCH 05/12] writeback: smoothed dirty threshold and limit Wu Fengguang
2011-04-16 13:25 ` Wu Fengguang
2011-04-16 13:25 ` Wu Fengguang
2011-04-16 13:25 ` [PATCH 06/12] writeback: enforce 1/4 gap between the dirty/background thresholds Wu Fengguang
2011-04-16 13:25 ` Wu Fengguang
2011-04-16 13:25 ` [PATCH 07/12] writeback: base throttle bandwidth and position ratio Wu Fengguang
2011-04-16 13:25 ` Wu Fengguang
2011-04-16 13:25 ` Wu Fengguang
2011-04-16 13:25 ` [PATCH 08/12] writeback: IO-less balance_dirty_pages() Wu Fengguang
2011-04-16 13:25 ` Wu Fengguang
2011-04-16 13:25 ` [PATCH 09/12] writeback: show bdi write bandwidth in debugfs Wu Fengguang
2011-04-16 13:25 ` Wu Fengguang
2011-04-16 13:25 ` Wu Fengguang
2011-04-16 13:25 ` Wu Fengguang [this message]
2011-04-16 13:25 ` [PATCH 10/12] writeback: trace dirty_ratelimit Wu Fengguang
2011-04-16 13:25 ` [PATCH 11/12] writeback: trace balance_dirty_pages Wu Fengguang
2011-04-16 13:25 ` Wu Fengguang
2011-04-16 13:25 ` [PATCH 12/12] writeback: trace global_dirty_state Wu Fengguang
2011-04-16 13:25 ` Wu Fengguang
2011-04-16 16:27 ` [PATCH 00/12] IO-less dirty throttling v7 Sedat Dilek
2011-04-17 1:44 ` Wu Fengguang
2011-04-17 3:18 ` Sedat Dilek
2011-04-17 4:10 ` Wu Fengguang
2011-04-17 4:10 ` Wu Fengguang
2011-04-17 4:10 ` Wu Fengguang
2011-04-17 4:46 ` Sedat Dilek
2011-04-17 4:46 ` Sedat Dilek
2011-04-17 6:46 ` Sedat Dilek
2011-04-18 0:13 ` Wu Fengguang
2011-04-18 0:13 ` Wu Fengguang
2011-04-18 6:57 ` Sedat Dilek
2011-04-18 8:18 ` Wu Fengguang
2011-04-18 10:22 ` Sedat Dilek
2011-04-17 7:31 ` Marco Stornelli
2011-04-17 7:31 ` Marco Stornelli
2011-04-17 9:30 ` Wu Fengguang
2011-04-17 9:30 ` Wu Fengguang
2011-04-17 17:44 ` Marco Stornelli
2011-04-17 17:44 ` Marco Stornelli
2011-04-17 23:31 ` Wu Fengguang
2011-04-17 23:31 ` Wu Fengguang
2011-04-26 17:19 ` Vivek Goyal
2011-04-26 17:19 ` Vivek Goyal
2011-04-28 14:27 ` Wu Fengguang
2011-04-28 14:27 ` Wu Fengguang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110416134333.693350038@intel.com \
--to=fengguang.wu@intel.com \
--cc=akpm@linux-foundation.org \
--cc=jack@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.