From: Brad Hards <bradh@frogmouth.net>
To: qemu-devel@nongnu.org
Cc: Jan Vesely <jano.vesely@gmail.com>
Subject: Re: [Qemu-devel] Bug #757654: UHCI fails to signal stall response patch
Date: Sat, 16 Apr 2011 16:33:02 +1000 [thread overview]
Message-ID: <201104161633.02418.bradh@frogmouth.net> (raw)
In-Reply-To: <BANLkTik3hmvH6_tUuEZjR8j0L04PdCk7mw@mail.gmail.com>
On Sat, 16 Apr 2011 06:57:00 am Jan Vesely wrote:
> + s->status |= UHCI_STS_USBERR;
This is per UHCI 1.1D Section 4.1.5. Looks good.
> + *int_mask |= 0x02;
> + if (td->ctrl & TD_CTRL_IOC)
> + *int_mask |= 0x01;
> + uhci_update_irq(s);
I see "A hardware interrupt is signalled to the system", but can you provide a
little explanation of why this particular interrupt mask?
> + s->status |= UHCI_STS_USBERR;
This is per UHCI 1.1d Section 4.1.4. Looks good.
> + *int_mask |= 0x02;
> + if (td->ctrl & TD_CTRL_IOC)
> + *int_mask |= 0x01;
> + uhci_update_irq(s);
I see "A hardware interrupt is signalled to the system", but can you provide a
little explanation of why this particular interrupt mask?
next prev parent reply other threads:[~2011-04-16 6:33 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-15 20:57 [Qemu-trivial] Bug #757654: UHCI fails to signal stall response patch Jan Vesely
2011-04-15 20:57 ` [Qemu-devel] " Jan Vesely
2011-04-16 6:33 ` Brad Hards [this message]
2011-04-16 7:29 ` Jan Vesely
2011-04-16 8:40 ` [Qemu-devel] [Qemu-trivial] " Stefan Hajnoczi
2011-05-05 12:05 ` [Qemu-trivial] [Qemu-devel] " Gerd Hoffmann
2011-05-05 12:05 ` Gerd Hoffmann
2011-05-06 8:07 ` [Qemu-trivial] " Jan Vesely
2011-05-06 8:07 ` Jan Vesely
2011-05-09 7:55 ` [Qemu-trivial] " Gerd Hoffmann
2011-05-09 7:55 ` Gerd Hoffmann
2011-05-09 10:16 ` [Qemu-trivial] " Jan Vesely
2011-05-09 10:16 ` Jan Vesely
2011-05-09 11:43 ` [Qemu-trivial] " Gerd Hoffmann
2011-05-09 11:43 ` Gerd Hoffmann
2011-05-11 11:33 ` [Qemu-trivial] " Jan Vesely
2011-05-11 11:33 ` Jan Vesely
2011-05-12 9:28 ` [Qemu-trivial] " Gerd Hoffmann
2011-05-12 9:28 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201104161633.02418.bradh@frogmouth.net \
--to=bradh@frogmouth.net \
--cc=jano.vesely@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.