From: Gerd Hoffmann <kraxel@redhat.com>
To: Jan Vesely <jano.vesely@gmail.com>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-trivial] [Qemu-devel] Bug #757654: UHCI fails to signal stall response patch
Date: Thu, 05 May 2011 14:05:27 +0200 [thread overview]
Message-ID: <4DC29287.5030106@redhat.com> (raw)
In-Reply-To: <BANLkTik3hmvH6_tUuEZjR8j0L04PdCk7mw@mail.gmail.com>
> diff --git a/hw/usb-uhci.c b/hw/usb-uhci.c
> index 346db3e..a51d89b 100644
> --- a/hw/usb-uhci.c
> +++ b/hw/usb-uhci.c
> @@ -732,11 +732,21 @@ out:
> case USB_RET_STALL:
> td->ctrl |= TD_CTRL_STALL;
> td->ctrl&= ~TD_CTRL_ACTIVE;
> + s->status |= UHCI_STS_USBERR;
Just this line should be enougth.
> case USB_RET_BABBLE:
> td->ctrl |= TD_CTRL_BABBLE | TD_CTRL_STALL;
> td->ctrl&= ~TD_CTRL_ACTIVE;
> + s->status |= UHCI_STS_USBERR;
Likewise.
Tried that?
cheers,
Gerd
WARNING: multiple messages have this Message-ID (diff)
From: Gerd Hoffmann <kraxel@redhat.com>
To: Jan Vesely <jano.vesely@gmail.com>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] Bug #757654: UHCI fails to signal stall response patch
Date: Thu, 05 May 2011 14:05:27 +0200 [thread overview]
Message-ID: <4DC29287.5030106@redhat.com> (raw)
In-Reply-To: <BANLkTik3hmvH6_tUuEZjR8j0L04PdCk7mw@mail.gmail.com>
> diff --git a/hw/usb-uhci.c b/hw/usb-uhci.c
> index 346db3e..a51d89b 100644
> --- a/hw/usb-uhci.c
> +++ b/hw/usb-uhci.c
> @@ -732,11 +732,21 @@ out:
> case USB_RET_STALL:
> td->ctrl |= TD_CTRL_STALL;
> td->ctrl&= ~TD_CTRL_ACTIVE;
> + s->status |= UHCI_STS_USBERR;
Just this line should be enougth.
> case USB_RET_BABBLE:
> td->ctrl |= TD_CTRL_BABBLE | TD_CTRL_STALL;
> td->ctrl&= ~TD_CTRL_ACTIVE;
> + s->status |= UHCI_STS_USBERR;
Likewise.
Tried that?
cheers,
Gerd
next prev parent reply other threads:[~2011-05-05 12:05 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-15 20:57 [Qemu-trivial] Bug #757654: UHCI fails to signal stall response patch Jan Vesely
2011-04-15 20:57 ` [Qemu-devel] " Jan Vesely
2011-04-16 6:33 ` Brad Hards
2011-04-16 7:29 ` Jan Vesely
2011-04-16 8:40 ` [Qemu-devel] [Qemu-trivial] " Stefan Hajnoczi
2011-05-05 12:05 ` Gerd Hoffmann [this message]
2011-05-05 12:05 ` [Qemu-devel] " Gerd Hoffmann
2011-05-06 8:07 ` [Qemu-trivial] " Jan Vesely
2011-05-06 8:07 ` Jan Vesely
2011-05-09 7:55 ` [Qemu-trivial] " Gerd Hoffmann
2011-05-09 7:55 ` Gerd Hoffmann
2011-05-09 10:16 ` [Qemu-trivial] " Jan Vesely
2011-05-09 10:16 ` Jan Vesely
2011-05-09 11:43 ` [Qemu-trivial] " Gerd Hoffmann
2011-05-09 11:43 ` Gerd Hoffmann
2011-05-11 11:33 ` [Qemu-trivial] " Jan Vesely
2011-05-11 11:33 ` Jan Vesely
2011-05-12 9:28 ` [Qemu-trivial] " Gerd Hoffmann
2011-05-12 9:28 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DC29287.5030106@redhat.com \
--to=kraxel@redhat.com \
--cc=jano.vesely@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.