All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Jones <davej@redhat.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
	Linus Walleij <linus.walleij@linaro.org>,
	cpufreq@vger.kernel.org, "Rafael J. Wysocki" <rjw@sisk.pl>,
	Tony Lindgren <tony@atomide.com>,
	Russell King - ARM Linux <linux@arm.linux.org.uk>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: Status of arch/arm in linux-next
Date: Thu, 21 Apr 2011 16:14:56 -0400	[thread overview]
Message-ID: <20110421201455.GA18083@redhat.com> (raw)
In-Reply-To: <20110419160545.GJ1765@opensource.wolfsonmicro.com>

On Tue, Apr 19, 2011 at 05:05:46PM +0100, Mark Brown wrote:
 > On Tue, Apr 19, 2011 at 06:01:19PM +0200, Arnd Bergmann wrote:
 > 
 > > I think it would be good to have the out of the individual
 > > platforms, in particular in order to get better reviews of
 > > new cpufreq drivers by people that are interested in them.
 > 
 > FWIW when I pushed the S3C64x0 cpufreq driver into mainline I posted the
 > driver to the cpufreq list and maintainers but never got any response
 > from them.

Like I said in another mail, the platform-specific nature of cpufreq drivers
means that the only people who can really review them are people familiar
with the architecture. (modulo the cpufreq api bits, but it's usually
either no-brainer stuff, or bugs that aren't immediately obvious from review,
like some of the locking mistakes we've historically seen)

This is why I don't believe that moving this code from arch/ to drivers/
will change anything.

if there's commonality between some of the ARM arch drivers, why can't
there be a arch/arm/cpufreq/ dir for the shared code, and do everything there ?

Right now "move it out of the arm tree into the cpufreq tree" just seems
like a cop-out to hide the problem.

	Dave


WARNING: multiple messages have this Message-ID (diff)
From: davej@redhat.com (Dave Jones)
To: linux-arm-kernel@lists.infradead.org
Subject: Status of arch/arm in linux-next
Date: Thu, 21 Apr 2011 16:14:56 -0400	[thread overview]
Message-ID: <20110421201455.GA18083@redhat.com> (raw)
In-Reply-To: <20110419160545.GJ1765@opensource.wolfsonmicro.com>

On Tue, Apr 19, 2011 at 05:05:46PM +0100, Mark Brown wrote:
 > On Tue, Apr 19, 2011 at 06:01:19PM +0200, Arnd Bergmann wrote:
 > 
 > > I think it would be good to have the out of the individual
 > > platforms, in particular in order to get better reviews of
 > > new cpufreq drivers by people that are interested in them.
 > 
 > FWIW when I pushed the S3C64x0 cpufreq driver into mainline I posted the
 > driver to the cpufreq list and maintainers but never got any response
 > from them.

Like I said in another mail, the platform-specific nature of cpufreq drivers
means that the only people who can really review them are people familiar
with the architecture. (modulo the cpufreq api bits, but it's usually
either no-brainer stuff, or bugs that aren't immediately obvious from review,
like some of the locking mistakes we've historically seen)

This is why I don't believe that moving this code from arch/ to drivers/
will change anything.

if there's commonality between some of the ARM arch drivers, why can't
there be a arch/arm/cpufreq/ dir for the shared code, and do everything there ?

Right now "move it out of the arm tree into the cpufreq tree" just seems
like a cop-out to hide the problem.

	Dave

  reply	other threads:[~2011-04-21 20:14 UTC|newest]

Thread overview: 85+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-14  9:44 Status of arch/arm in linux-next Russell King - ARM Linux
2011-04-14 11:08 ` Tony Lindgren
2011-04-14 12:02   ` Russell King - ARM Linux
2011-04-14 12:31     ` Tony Lindgren
2011-04-14 14:20       ` Mark Brown
2011-04-14 14:26         ` Tony Lindgren
2011-04-14 14:31         ` Russell King - ARM Linux
2011-04-14 18:32           ` Mark Brown
2011-04-15 15:12       ` Grant Likely
2011-04-15 15:56         ` Russell King - ARM Linux
2011-04-15 16:10           ` Grant Likely
2011-04-16  8:28             ` Russell King - ARM Linux
2011-04-16 16:57               ` Mark Brown
2011-04-18  8:10                 ` Tony Lindgren
2011-04-18 13:57                   ` Mark Brown
2011-04-18 14:41                     ` Tony Lindgren
2011-04-18 14:41                       ` Tony Lindgren
2011-04-18 15:58                       ` Mark Brown
2011-04-18 15:58                         ` Mark Brown
2011-04-18 17:18                     ` Russell King - ARM Linux
2011-04-18 20:23                       ` Mark Brown
2011-04-18 21:40                         ` Thomas Gleixner
2011-04-18 23:55                           ` Mark Brown
2011-04-14 14:07     ` Mark Brown
2011-04-15  2:59     ` Nico Erfurth
2011-04-15  8:21       ` Nicolas Ferre
2011-04-15 13:13         ` Nico Erfurth
2011-04-15  1:16 ` Linus Walleij
2011-04-15  6:26   ` Tony Lindgren
2011-04-19 14:16     ` Arnd Bergmann
2011-04-19 14:50       ` Mark Brown
2011-04-19 14:55         ` Arnd Bergmann
2011-04-19 15:04           ` Mark Brown
2011-04-19 15:14           ` Linus Walleij
2011-04-19 16:01             ` Arnd Bergmann
2011-04-19 16:01               ` Arnd Bergmann
2011-04-19 16:05               ` Mark Brown
2011-04-19 16:05                 ` Mark Brown
2011-04-21 20:14                 ` Dave Jones [this message]
2011-04-21 20:14                   ` Dave Jones
2011-04-21 21:02                   ` Nicolas Pitre
2011-04-21 21:02                     ` Nicolas Pitre
2011-04-22  7:17                     ` Tony Lindgren
2011-04-22  7:17                       ` Tony Lindgren
2011-04-26 14:05                     ` Arnd Bergmann
2011-04-26 14:05                       ` Arnd Bergmann
2011-04-26 17:04                       ` Rafael J. Wysocki
2011-04-26 17:04                         ` Rafael J. Wysocki
2011-04-26 18:15                         ` Dave Jones
2011-04-26 18:15                           ` Dave Jones
2011-04-29 20:15                           ` Dave Jones
2011-04-29 20:15                             ` Dave Jones
2011-04-30  0:05                             ` Nicolas Pitre
2011-04-30  0:05                               ` Nicolas Pitre
2011-08-13 15:46                           ` [BUG?] Moving drivers to drivers/cpufreq/ causes all to be loaded Jonathan Nieder
2011-08-13 19:02                             ` Jonathan Nieder
2011-08-13 21:11                               ` Dave Jones
2011-08-14  0:18                                 ` Mattia Dongili
2011-08-14  0:18                                   ` Mattia Dongili
2011-08-14 17:01                                 ` Jonathan Nieder
2011-08-14 17:17                                   ` Kay Sievers
2011-08-14 17:17                                     ` Kay Sievers
2011-05-01 23:02                       ` Status of arch/arm in linux-next Jamie Lokier
2011-05-01 23:02                         ` Jamie Lokier
2011-04-19 16:27               ` Dave Jones
2011-04-19 16:27                 ` Dave Jones
2011-04-19 17:12                 ` Arnd Bergmann
2011-04-19 17:12                   ` Arnd Bergmann
2011-04-20  6:36                 ` Linus Walleij
2011-04-20  6:36                   ` Linus Walleij
2011-04-21  7:32             ` Linus Walleij
2011-04-21  8:25               ` Arnd Bergmann
2011-04-22  7:56                 ` Linus Walleij
2011-04-22 11:46                   ` Linus Walleij
2011-05-02 13:49                   ` Samuel Ortiz
2011-05-02 19:21                     ` Linus Walleij
2011-04-20  7:33       ` Tony Lindgren
2011-04-20  7:43         ` Arnd Bergmann
2011-04-15 14:30 ` Martin Guy
2011-04-15 15:50   ` Russell King - ARM Linux
2011-04-18 15:17 ` Alexey Zaytsev
2011-04-18 16:23   ` Linus Torvalds
2011-04-18 21:54     ` Alexey Zaytsev
2011-04-19 15:02       ` Linus Torvalds
2011-04-19 15:20         ` Jean-Christophe PLAGNIOL-VILLARD

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110421201455.GA18083@redhat.com \
    --to=davej@redhat.com \
    --cc=arnd@arndb.de \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=cpufreq@vger.kernel.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux@arm.linux.org.uk \
    --cc=rjw@sisk.pl \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.