All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mike Snitzer <snitzer@redhat.com>
To: dm-devel@redhat.com
Cc: DarkNovaNick@gmail.com,
	LVM general discussion and development <linux-lvm@redhat.com>
Subject: [PATCH] dm snapshot: ignore discards issued to the snapshot-origin target
Date: Wed, 27 Apr 2011 20:19:13 -0400	[thread overview]
Message-ID: <20110428001912.GA14659@redhat.com> (raw)
In-Reply-To: <20110426173213.GA19604@redhat.com>

Discards pose a problem for the snapshot-origin target because they are
treated as writes.  Treating a discard as a write would trigger a
copyout to the snapshot.  Such copyout can prove too costly in the face
of otherwise benign scenarios (e.g. create a snapshot and then mkfs.ext4
the origin -- mkfs.ext4 discards the entire volume by default, which
would copyout the entire origin volume to the snapshot).

Signed-off-by: Mike Snitzer <snitzer@redhat.com>
---
 drivers/md/dm-snap.c |    9 ++++++++-
 1 files changed, 8 insertions(+), 1 deletions(-)

diff --git a/drivers/md/dm-snap.c b/drivers/md/dm-snap.c
index a2d3309..639af12 100644
--- a/drivers/md/dm-snap.c
+++ b/drivers/md/dm-snap.c
@@ -2076,6 +2076,7 @@ static int origin_ctr(struct dm_target *ti, unsigned int argc, char **argv)
 
 	ti->private = dev;
 	ti->num_flush_requests = 1;
+	ti->num_discard_requests = 1;
 
 	return 0;
 }
@@ -2095,6 +2096,12 @@ static int origin_map(struct dm_target *ti, struct bio *bio,
 	if (bio->bi_rw & REQ_FLUSH)
 		return DM_MAPIO_REMAPPED;
 
+	if (bio->bi_rw & REQ_DISCARD) {
+		/* ignore discard requests */
+		bio_endio(bio, 0);
+		return DM_MAPIO_SUBMITTED;
+	}
+
 	/* Only tell snapshots if this is a write */
 	return (bio_rw(bio) == WRITE) ? do_origin(dev, bio) : DM_MAPIO_REMAPPED;
 }
@@ -2153,7 +2160,7 @@ static int origin_iterate_devices(struct dm_target *ti,
 
 static struct target_type origin_target = {
 	.name    = "snapshot-origin",
-	.version = {1, 7, 1},
+	.version = {1, 8, 0},
 	.module  = THIS_MODULE,
 	.ctr     = origin_ctr,
 	.dtr     = origin_dtr,

WARNING: multiple messages have this Message-ID (diff)
From: Mike Snitzer <snitzer@redhat.com>
To: dm-devel@redhat.com
Cc: DarkNovaNick@gmail.com,
	LVM general discussion and development <linux-lvm@redhat.com>
Subject: [linux-lvm] [PATCH] dm snapshot: ignore discards issued to the snapshot-origin target
Date: Wed, 27 Apr 2011 20:19:13 -0400	[thread overview]
Message-ID: <20110428001912.GA14659@redhat.com> (raw)
In-Reply-To: <20110426173213.GA19604@redhat.com>

Discards pose a problem for the snapshot-origin target because they are
treated as writes.  Treating a discard as a write would trigger a
copyout to the snapshot.  Such copyout can prove too costly in the face
of otherwise benign scenarios (e.g. create a snapshot and then mkfs.ext4
the origin -- mkfs.ext4 discards the entire volume by default, which
would copyout the entire origin volume to the snapshot).

Signed-off-by: Mike Snitzer <snitzer@redhat.com>
---
 drivers/md/dm-snap.c |    9 ++++++++-
 1 files changed, 8 insertions(+), 1 deletions(-)

diff --git a/drivers/md/dm-snap.c b/drivers/md/dm-snap.c
index a2d3309..639af12 100644
--- a/drivers/md/dm-snap.c
+++ b/drivers/md/dm-snap.c
@@ -2076,6 +2076,7 @@ static int origin_ctr(struct dm_target *ti, unsigned int argc, char **argv)
 
 	ti->private = dev;
 	ti->num_flush_requests = 1;
+	ti->num_discard_requests = 1;
 
 	return 0;
 }
@@ -2095,6 +2096,12 @@ static int origin_map(struct dm_target *ti, struct bio *bio,
 	if (bio->bi_rw & REQ_FLUSH)
 		return DM_MAPIO_REMAPPED;
 
+	if (bio->bi_rw & REQ_DISCARD) {
+		/* ignore discard requests */
+		bio_endio(bio, 0);
+		return DM_MAPIO_SUBMITTED;
+	}
+
 	/* Only tell snapshots if this is a write */
 	return (bio_rw(bio) == WRITE) ? do_origin(dev, bio) : DM_MAPIO_REMAPPED;
 }
@@ -2153,7 +2160,7 @@ static int origin_iterate_devices(struct dm_target *ti,
 
 static struct target_type origin_target = {
 	.name    = "snapshot-origin",
-	.version = {1, 7, 1},
+	.version = {1, 8, 0},
 	.module  = THIS_MODULE,
 	.ctr     = origin_ctr,
 	.dtr     = origin_dtr,

  reply	other threads:[~2011-04-28  0:19 UTC|newest]

Thread overview: 104+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-12 14:59 [linux-lvm] Testing TRIM with LVM DarkNovaNick
2011-04-12 23:47 ` Mike Snitzer
2011-04-13  1:47   ` DarkNovaNick
2011-04-13  8:41     ` Zdenek Kabelac
2011-04-13 15:38       ` DarkNovaNick
2011-04-13 22:40     ` [PATCH] dm snapshot: add discard support to the snapshot-origin target [was: Re: Testing TRIM with LVM] Mike Snitzer
2011-04-13 22:40       ` [linux-lvm] " Mike Snitzer
2011-04-13 23:48       ` Mike Snitzer
2011-04-13 23:48         ` [linux-lvm] " Mike Snitzer
2011-04-26 17:32         ` Mike Snitzer
2011-04-26 17:32           ` [linux-lvm] " Mike Snitzer
2011-04-28  0:19           ` Mike Snitzer [this message]
2011-04-28  0:19             ` [linux-lvm] [PATCH] dm snapshot: ignore discards issued to the snapshot-origin target Mike Snitzer
2011-04-28  7:53             ` Christoph Hellwig
2011-04-28  7:53               ` [linux-lvm] [dm-devel] " Christoph Hellwig
2011-04-28 20:59               ` do not disable ext4 discards on first discard failure? [was: Re: dm snapshot: ignore discards issued to the snapshot-origin target] Mike Snitzer
2011-04-28 20:59                 ` [linux-lvm] " Mike Snitzer
2011-04-28 21:28                 ` Eric Sandeen
2011-04-28 21:28                   ` [linux-lvm] " Eric Sandeen
2011-04-28 22:59                   ` Alasdair G Kergon
2011-04-28 22:59                     ` Alasdair G Kergon
2011-04-28 23:01                     ` Eric Sandeen
2011-04-28 23:01                       ` Eric Sandeen
2011-04-28 23:11                       ` Alasdair G Kergon
2011-04-28 23:11                         ` Alasdair G Kergon
2011-04-29  1:12                 ` Andreas Dilger
2011-04-29  1:12                   ` [linux-lvm] " Andreas Dilger
2011-04-29 13:55                   ` Mike Snitzer
2011-04-29 13:55                     ` [linux-lvm] " Mike Snitzer
2011-04-29  9:30                 ` Lukas Czerner
2011-04-29  9:30                   ` [linux-lvm] " Lukas Czerner
2011-04-29 12:24                   ` [dm-devel] " Alasdair G Kergon
2011-04-29 12:24                     ` [linux-lvm] " Alasdair G Kergon
2011-04-29 12:29                     ` Christoph Hellwig
2011-04-29 12:29                       ` [linux-lvm] " Christoph Hellwig
2011-04-29 14:28                       ` Eric Sandeen
2011-04-29 14:28                         ` [linux-lvm] " Eric Sandeen
2011-04-29 15:13                         ` Ray Morris
2011-04-29 15:13                           ` Ray Morris
2011-05-04 16:33                         ` Ted Ts'o
2011-05-04 16:33                           ` [linux-lvm] " Ted Ts'o
2011-05-04 16:51                           ` Eric Sandeen
2011-05-04 16:57                             ` Lukas Czerner
2011-05-04 17:02                           ` Lukas Czerner
2011-05-04 17:02                             ` [linux-lvm] " Lukas Czerner
2011-05-02  7:16                     ` Lukas Czerner
2011-05-02  7:16                       ` [linux-lvm] " Lukas Czerner
2011-05-02  8:13                       ` Alasdair G Kergon
2011-05-02  8:13                         ` [linux-lvm] " Alasdair G Kergon
2011-05-02  8:19                         ` Christoph Hellwig
2011-05-02  8:19                           ` [linux-lvm] " Christoph Hellwig
2011-05-02 10:24                           ` Lukas Czerner
2011-05-02 10:24                             ` [linux-lvm] " Lukas Czerner
2011-05-02 12:48                             ` Mike Snitzer
2011-05-02 12:48                               ` [linux-lvm] " Mike Snitzer
2011-05-02 13:05                               ` Lukas Czerner
2011-05-02 13:05                                 ` [linux-lvm] " Lukas Czerner
2011-05-02 14:47                                 ` Eric Sandeen
2011-05-02 14:47                                   ` [linux-lvm] " Eric Sandeen
2011-05-02 14:48                                   ` Christoph Hellwig
2011-05-02 14:48                                     ` [linux-lvm] " Christoph Hellwig
2011-05-02 14:58                                   ` Lukas Czerner
2011-05-02 14:58                                     ` [linux-lvm] " Lukas Czerner
2011-05-02 13:48                             ` [dm-devel] " Martin K. Petersen
2011-05-02 13:48                               ` [linux-lvm] " Martin K. Petersen
2011-05-02 14:20                             ` Martin K. Petersen
2011-05-02 14:20                               ` [linux-lvm] [dm-devel] " Martin K. Petersen
2011-05-02 14:39                               ` Lukas Czerner
2011-05-02 14:39                                 ` [linux-lvm] " Lukas Czerner
2011-05-02 14:50                                 ` Martin K. Petersen
2011-05-02 14:50                                   ` [linux-lvm] " Martin K. Petersen
2011-05-02 14:58                                 ` Mike Snitzer
2011-05-02 14:58                                   ` [linux-lvm] " Mike Snitzer
2011-05-02 16:58                                 ` [dm-devel] " Martin K. Petersen
2011-05-02 16:58                                   ` [linux-lvm] " Martin K. Petersen
2011-05-03  8:57                                   ` Lukas Czerner
2011-05-03  8:57                                     ` [linux-lvm] " Lukas Czerner
2011-05-04 15:10                                     ` Martin K. Petersen
2011-05-04 15:10                                       ` [linux-lvm] " Martin K. Petersen
2011-05-04 16:02                                       ` Mike Snitzer
2011-05-04 16:02                                         ` [linux-lvm] " Mike Snitzer
2011-05-04 16:50                                         ` Martin K. Petersen
2011-05-04 16:50                                           ` [linux-lvm] " Martin K. Petersen
2011-05-04 18:03                                           ` Mike Snitzer
2011-05-04 18:03                                             ` [linux-lvm] " Mike Snitzer
2011-05-04 17:10                                       ` [dm-devel] " Lukas Czerner
2011-05-04 17:10                                         ` [linux-lvm] " Lukas Czerner
2011-05-04 17:32                                         ` Martin K. Petersen
2011-05-04 17:32                                           ` [linux-lvm] " Martin K. Petersen
2011-05-04 17:35                                           ` Lukas Czerner
2011-05-04 17:35                                             ` [linux-lvm] " Lukas Czerner
2011-05-18 12:16                                       ` Mike Snitzer
2011-05-18 12:16                                         ` [linux-lvm] " Mike Snitzer
2011-05-18 12:52                                         ` Mike Snitzer
2011-05-18 12:52                                           ` [linux-lvm] " Mike Snitzer
2011-05-04 15:16                                     ` [dm-devel] " Martin K. Petersen
2011-05-04 15:16                                       ` [linux-lvm] " Martin K. Petersen
2011-05-04 16:12                                       ` Lukas Czerner
2011-05-04 16:12                                         ` [linux-lvm] " Lukas Czerner
2011-05-05  8:33                                       ` Karel Zak
2011-05-05  8:33                                         ` [linux-lvm] " Karel Zak
2011-05-05 10:48                                         ` Lukas Czerner
2011-05-05 10:48                                           ` [linux-lvm] " Lukas Czerner
2011-04-14 15:31       ` [linux-lvm] [PATCH] dm snapshot: add discard support to the snapshot-origin target [was: Re: Testing TRIM wi DarkNovaNick

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110428001912.GA14659@redhat.com \
    --to=snitzer@redhat.com \
    --cc=DarkNovaNick@gmail.com \
    --cc=dm-devel@redhat.com \
    --cc=linux-lvm@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.