All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrea Arcangeli <aarcange@redhat.com>
To: Christoph Lameter <cl@linux.com>
Cc: James Bottomley <James.Bottomley@HansenPartnership.com>,
	Dave Jones <davej@redhat.com>, Mel Gorman <mgorman@suse.de>,
	Andrew Morton <akpm@linux-foundation.org>,
	Colin King <colin.king@canonical.com>,
	Raghavendra D Prabhu <raghu.prabhu13@gmail.com>,
	Jan Kara <jack@suse.cz>, Chris Mason <chris.mason@oracle.com>,
	Pekka Enberg <penberg@kernel.org>, Rik van Riel <riel@redhat.com>,
	Johannes Weiner <hannes@cmpxchg.org>,
	linux-fsdevel <linux-fsdevel@vger.kernel.org>,
	linux-mm <linux-mm@kvack.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	linux-ext4 <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH 3/3] mm: slub: Default slub_max_order to 0
Date: Thu, 12 May 2011 19:46:41 +0200	[thread overview]
Message-ID: <20110512174641.GL11579@random.random> (raw)
In-Reply-To: <alpine.DEB.2.00.1105121144320.27324@router.home>

On Thu, May 12, 2011 at 11:48:19AM -0500, Christoph Lameter wrote:
> Try order = 1 which gives you SLAB like interaction with the page
> allocator. Then we at least know that it is the order 2 and 3 allocs that
> are the problem and not something else.

order 1 should work better, because it's less likely we end up here
(which leaves RECLAIM_MODE_LUMPYRECLAIM on and then see what happens
at the top of page_check_references())

   else if (sc->order && priority < DEF_PRIORITY - 2)
   	sc->reclaim_mode |= syncmode;

with order 1 more likely we end up here as enough pages are freed for
order 1 and we're safe:

     else
	sc->reclaim_mode = RECLAIM_MODE_SINGLE | RECLAIM_MODE_ASYNC;

None of these issue should materialize with COMPACTION=n. Even
__GFP_WAIT can be left enabled to run compaction without expecting
adverse behavior, but running compaction may still not be worth it for
small systems where the benefit of having order 1/2/3 allocation may
not outweight the cost of compaction itself.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Andrea Arcangeli <aarcange@redhat.com>
To: Christoph Lameter <cl@linux.com>
Cc: James Bottomley <James.Bottomley@HansenPartnership.com>,
	Dave Jones <davej@redhat.com>, Mel Gorman <mgorman@suse.de>,
	Andrew Morton <akpm@linux-foundation.org>,
	Colin King <colin.king@canonical.com>,
	Raghavendra D Prabhu <raghu.prabhu13@gmail.com>,
	Jan Kara <jack@suse.cz>, Chris Mason <chris.mason@oracle.com>,
	Pekka Enberg <penberg@kernel.org>, Rik van Riel <riel@redhat.com>,
	Johannes Weiner <hannes@cmpxchg.org>,
	linux-fsdevel <linux-fsdevel@vger.kernel.org>,
	linux-mm <linux-mm@kvack.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	linux-ext4 <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH 3/3] mm: slub: Default slub_max_order to 0
Date: Thu, 12 May 2011 19:46:41 +0200	[thread overview]
Message-ID: <20110512174641.GL11579@random.random> (raw)
In-Reply-To: <alpine.DEB.2.00.1105121144320.27324@router.home>

On Thu, May 12, 2011 at 11:48:19AM -0500, Christoph Lameter wrote:
> Try order = 1 which gives you SLAB like interaction with the page
> allocator. Then we at least know that it is the order 2 and 3 allocs that
> are the problem and not something else.

order 1 should work better, because it's less likely we end up here
(which leaves RECLAIM_MODE_LUMPYRECLAIM on and then see what happens
at the top of page_check_references())

   else if (sc->order && priority < DEF_PRIORITY - 2)
   	sc->reclaim_mode |= syncmode;

with order 1 more likely we end up here as enough pages are freed for
order 1 and we're safe:

     else
	sc->reclaim_mode = RECLAIM_MODE_SINGLE | RECLAIM_MODE_ASYNC;

None of these issue should materialize with COMPACTION=n. Even
__GFP_WAIT can be left enabled to run compaction without expecting
adverse behavior, but running compaction may still not be worth it for
small systems where the benefit of having order 1/2/3 allocation may
not outweight the cost of compaction itself.

  reply	other threads:[~2011-05-12 17:46 UTC|newest]

Thread overview: 157+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-11 15:29 [PATCH 0/3] Reduce impact to overall system of SLUB using high-order allocations Mel Gorman
2011-05-11 15:29 ` Mel Gorman
2011-05-11 15:29 ` [PATCH 1/3] mm: slub: Do not wake kswapd for SLUBs speculative " Mel Gorman
2011-05-11 15:29   ` Mel Gorman
2011-05-11 20:38   ` David Rientjes
2011-05-11 20:38     ` David Rientjes
2011-05-11 15:29 ` [PATCH 2/3] mm: slub: Do not take expensive steps " Mel Gorman
2011-05-11 15:29   ` Mel Gorman
2011-05-11 20:38   ` David Rientjes
2011-05-11 20:38     ` David Rientjes
2011-05-11 21:10     ` Mel Gorman
2011-05-11 21:10       ` Mel Gorman
2011-05-12 17:25       ` Andrea Arcangeli
2011-05-12 17:25         ` Andrea Arcangeli
2011-05-11 15:29 ` [PATCH 3/3] mm: slub: Default slub_max_order to 0 Mel Gorman
2011-05-11 15:29   ` Mel Gorman
2011-05-11 20:38   ` David Rientjes
2011-05-11 20:38     ` David Rientjes
2011-05-11 20:53     ` James Bottomley
2011-05-11 20:53       ` James Bottomley
2011-05-11 21:09     ` Mel Gorman
2011-05-11 21:09       ` Mel Gorman
2011-05-11 22:27       ` David Rientjes
2011-05-11 22:27         ` David Rientjes
2011-05-13 10:14         ` Mel Gorman
2011-05-13 10:14           ` Mel Gorman
2011-05-12 17:36     ` Andrea Arcangeli
2011-05-12 17:36       ` Andrea Arcangeli
2011-05-16 21:03       ` David Rientjes
2011-05-16 21:03         ` David Rientjes
2011-05-17  9:48         ` Mel Gorman
2011-05-17  9:48           ` Mel Gorman
2011-05-17 19:25           ` David Rientjes
2011-05-17 19:25             ` David Rientjes
2011-05-12 14:43   ` Christoph Lameter
2011-05-12 14:43     ` Christoph Lameter
2011-05-12 15:15     ` James Bottomley
2011-05-12 15:15       ` James Bottomley
2011-05-12 15:27       ` Christoph Lameter
2011-05-12 15:27         ` Christoph Lameter
2011-05-12 15:43         ` James Bottomley
2011-05-12 15:43           ` James Bottomley
2011-05-12 15:46           ` Dave Jones
2011-05-12 15:46             ` Dave Jones
2011-05-12 16:00             ` James Bottomley
2011-05-12 16:00               ` James Bottomley
2011-05-12 16:08               ` Dave Jones
2011-05-12 16:08                 ` Dave Jones
2011-05-12 16:27               ` Christoph Lameter
2011-05-12 16:27                 ` Christoph Lameter
2011-05-12 16:30                 ` James Bottomley
2011-05-12 16:30                   ` James Bottomley
2011-05-12 16:48                   ` Christoph Lameter
2011-05-12 16:48                     ` Christoph Lameter
2011-05-12 17:46                     ` Andrea Arcangeli [this message]
2011-05-12 17:46                       ` Andrea Arcangeli
2011-05-12 18:00                       ` Christoph Lameter
2011-05-12 18:00                         ` Christoph Lameter
2011-05-12 18:18                         ` Andrea Arcangeli
2011-05-12 18:18                           ` Andrea Arcangeli
2011-05-12 17:06                   ` Pekka Enberg
2011-05-12 17:06                     ` Pekka Enberg
2011-05-12 17:11                     ` Pekka Enberg
2011-05-12 17:11                       ` Pekka Enberg
2011-05-12 17:38                       ` Christoph Lameter
2011-05-12 17:38                         ` Christoph Lameter
2011-05-12 18:00                         ` Andrea Arcangeli
2011-05-12 18:00                           ` Andrea Arcangeli
2011-05-13  9:49                           ` Mel Gorman
2011-05-13  9:49                             ` Mel Gorman
2011-05-15 16:39                             ` Andrea Arcangeli
2011-05-15 16:39                               ` Andrea Arcangeli
2011-05-16  8:42                               ` Mel Gorman
2011-05-16  8:42                                 ` Mel Gorman
2011-05-12 17:51                       ` Andrea Arcangeli
2011-05-12 17:51                         ` Andrea Arcangeli
2011-05-12 18:03                         ` Christoph Lameter
2011-05-12 18:03                           ` Christoph Lameter
2011-05-12 18:09                           ` Andrea Arcangeli
2011-05-12 18:09                             ` Andrea Arcangeli
2011-05-12 18:16                             ` Christoph Lameter
2011-05-12 18:16                               ` Christoph Lameter
2011-05-12 18:36                       ` James Bottomley
2011-05-12 18:36                         ` James Bottomley
2011-05-12 17:40                 ` Andrea Arcangeli
2011-05-12 17:40                   ` Andrea Arcangeli
2011-05-12 15:55           ` Pekka Enberg
2011-05-12 15:55             ` Pekka Enberg
2011-05-12 18:37             ` James Bottomley
2011-05-12 18:37               ` James Bottomley
2011-05-12 18:46               ` Christoph Lameter
2011-05-12 18:46                 ` Christoph Lameter
2011-05-12 19:21                 ` James Bottomley
2011-05-12 19:21                   ` James Bottomley
2011-05-12 19:44               ` James Bottomley
2011-05-12 19:44                 ` James Bottomley
2011-05-12 20:04                 ` James Bottomley
2011-05-12 20:04                   ` James Bottomley
2011-05-12 20:29                   ` Johannes Weiner
2011-05-12 20:29                     ` Johannes Weiner
2011-05-12 20:31                     ` Johannes Weiner
2011-05-12 20:31                       ` Johannes Weiner
2011-05-12 20:31                     ` James Bottomley
2011-05-12 20:31                       ` James Bottomley
2011-05-12 22:04                   ` James Bottomley
2011-05-12 22:04                     ` James Bottomley
2011-05-12 22:15                     ` Johannes Weiner
2011-05-12 22:15                       ` Johannes Weiner
2011-05-12 22:58                       ` Minchan Kim
2011-05-12 22:58                         ` Minchan Kim
2011-05-12 22:58                         ` Minchan Kim
2011-05-13  5:39                         ` Minchan Kim
2011-05-13  5:39                           ` Minchan Kim
2011-05-13  0:47                       ` James Bottomley
2011-05-13  0:47                         ` James Bottomley
2011-05-13  4:12                         ` James Bottomley
2011-05-13  4:12                           ` James Bottomley
2011-05-13 10:55                         ` Mel Gorman
2011-05-13 10:55                           ` Mel Gorman
2011-05-13 14:16                           ` James Bottomley
2011-05-13 14:16                             ` James Bottomley
2011-05-13 10:30                       ` Mel Gorman
2011-05-13 10:30                         ` Mel Gorman
2011-05-13  6:16                   ` Pekka Enberg
2011-05-13  6:16                     ` Pekka Enberg
2011-05-13  6:16                     ` Pekka Enberg
2011-05-13 10:05                     ` Mel Gorman
2011-05-13 10:05                       ` Mel Gorman
2011-05-13 10:05                       ` Mel Gorman
2011-05-12 16:01           ` Christoph Lameter
2011-05-12 16:01             ` Christoph Lameter
2011-05-12 16:10             ` Eric Dumazet
2011-05-12 16:10               ` Eric Dumazet
2011-05-12 16:10               ` Eric Dumazet
2011-05-12 17:37               ` Andrew Morton
2011-05-12 17:37                 ` Andrew Morton
2011-05-12 15:45         ` Dave Jones
2011-05-12 15:45           ` Dave Jones
2011-05-11 21:39 ` [PATCH 0/3] Reduce impact to overall system of SLUB using high-order allocations James Bottomley
2011-05-11 21:39   ` James Bottomley
2011-05-11 22:28   ` David Rientjes
2011-05-11 22:28     ` David Rientjes
2011-05-11 22:34     ` James Bottomley
2011-05-11 22:34       ` James Bottomley
2011-05-12 11:13       ` Pekka Enberg
2011-05-12 11:13         ` Pekka Enberg
2011-05-12 13:19         ` Mel Gorman
2011-05-12 13:19           ` Mel Gorman
2011-05-12 14:04         ` James Bottomley
2011-05-12 14:04           ` James Bottomley
2011-05-12 15:53           ` James Bottomley
2011-05-13 11:25             ` Mel Gorman
2011-05-13 11:25               ` Mel Gorman
2011-05-12 18:04       ` Andrea Arcangeli
2011-05-12 18:04         ` Andrea Arcangeli
2011-05-13 11:24         ` Mel Gorman
2011-05-13 11:24           ` Mel Gorman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110512174641.GL11579@random.random \
    --to=aarcange@redhat.com \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=akpm@linux-foundation.org \
    --cc=chris.mason@oracle.com \
    --cc=cl@linux.com \
    --cc=colin.king@canonical.com \
    --cc=davej@redhat.com \
    --cc=hannes@cmpxchg.org \
    --cc=jack@suse.cz \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mgorman@suse.de \
    --cc=penberg@kernel.org \
    --cc=raghu.prabhu13@gmail.com \
    --cc=riel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.