[RFC PATCH 2/2] omap: switch to ioremap function pointer

[plagnioj@jcrosoft.com (Jean-Christophe PLAGNIOL-VILLARD)]

On 11:54 Sun 22 May     , Arnd Bergmann wrote:
> On Sunday 22 May 2011 11:04:40 Jean-Christophe PLAGNIOL-VILLARD wrote:
> > 
> > --- a/arch/arm/plat-omap/io.c
> > +++ b/arch/arm/plat-omap/io.c
> > @@ -23,6 +23,12 @@
> >  #define BETWEEN(p,st,sz)       ((p) >= (st) && (p) < ((st) + (sz)))
> >  #define XLATE(p,pst,vst)       ((void __iomem *)((p) - (pst) + (vst)))
> >  
> > +void __init omap_set_ioremap(void)
> > +{
> > +       arch_ioremap = omap_ioremap;
> > +       arch_iounmap = omap_iounmap;
> > +}
> > +
> >  /*
> >   * Intercept ioremap() requests for addresses in our fixed mapping regions.
> 
> The only thing that the ioremap functions for omap do as a special case
> is to handle the fixed mappings. Maybe a better approach would be to
> make handling this in omap (and others) unnecessary, using one of
> two approaches:
> 
> * Remove all fixed mappings that are also ioremapped, and rely on every
>   user calling ioremap correctly. I don't see why we would want to allow
>   both methods anyway.
> 
> * Handle the fixed mappings in the generic ioremap code. They all go through
>   create_mapping(), so we can save a list to walk there.
not sure we can do so as imx do do so, they check on mx3 the memmory region
and fix the remapping type

Not sure it's the right to do either

Best Regards,
J.