From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH 2/2] omap: switch to ioremap function pointer
Date: Sun, 22 May 2011 11:54:28 +0200 [thread overview]
Message-ID: <201105221154.28211.arnd@arndb.de> (raw)
In-Reply-To: <1306055080-30420-2-git-send-email-plagnioj@jcrosoft.com>
On Sunday 22 May 2011 11:04:40 Jean-Christophe PLAGNIOL-VILLARD wrote:
>
> --- a/arch/arm/plat-omap/io.c
> +++ b/arch/arm/plat-omap/io.c
> @@ -23,6 +23,12 @@
> #define BETWEEN(p,st,sz) ((p) >= (st) && (p) < ((st) + (sz)))
> #define XLATE(p,pst,vst) ((void __iomem *)((p) - (pst) + (vst)))
>
> +void __init omap_set_ioremap(void)
> +{
> + arch_ioremap = omap_ioremap;
> + arch_iounmap = omap_iounmap;
> +}
> +
> /*
> * Intercept ioremap() requests for addresses in our fixed mapping regions.
The only thing that the ioremap functions for omap do as a special case
is to handle the fixed mappings. Maybe a better approach would be to
make handling this in omap (and others) unnecessary, using one of
two approaches:
* Remove all fixed mappings that are also ioremapped, and rely on every
user calling ioremap correctly. I don't see why we would want to allow
both methods anyway.
* Handle the fixed mappings in the generic ioremap code. They all go through
create_mapping(), so we can save a list to walk there.
Arnd
next prev parent reply other threads:[~2011-05-22 9:54 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-22 9:04 [RFC PATCH 1/2] arm: introduce arch_ioremap and arch_iounmap function pointer Jean-Christophe PLAGNIOL-VILLARD
2011-05-22 9:04 ` [RFC PATCH 2/2] omap: switch to ioremap " Jean-Christophe PLAGNIOL-VILLARD
2011-05-22 9:54 ` Arnd Bergmann [this message]
2011-05-22 11:13 ` Jean-Christophe PLAGNIOL-VILLARD
2011-05-22 11:20 ` Santosh Shilimkar
2011-05-22 11:17 ` Jean-Christophe PLAGNIOL-VILLARD
2011-05-22 11:35 ` Arnd Bergmann
2011-05-22 11:46 ` Santosh Shilimkar
2011-05-22 12:56 ` Arnd Bergmann
2011-05-22 13:20 ` Santosh Shilimkar
2011-05-22 13:09 ` Russell King - ARM Linux
2011-05-22 13:23 ` Santosh Shilimkar
2011-05-22 16:40 ` Arnd Bergmann
2011-05-22 10:03 ` [RFC PATCH 1/2] arm: introduce arch_ioremap and arch_iounmap " Russell King - ARM Linux
2011-05-22 11:05 ` Jean-Christophe PLAGNIOL-VILLARD
2011-05-22 13:19 ` Russell King - ARM Linux
2011-05-22 14:58 ` Jean-Christophe PLAGNIOL-VILLARD
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201105221154.28211.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.