From: Alexey Dobriyan <adobriyan@gmail.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
benh@kernel.crashing.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, hughd@google.com,
akpm@linux-foundation.org, dave@linux.vnet.ibm.com,
kamezawa.hiroyu@jp.fujitsu.com
Subject: Re: [PATCH] mm: don't access vm_flags as 'int'
Date: Thu, 26 May 2011 21:44:02 +0300 [thread overview]
Message-ID: <20110526184402.GA2453@p183.telecom.by> (raw)
In-Reply-To: <BANLkTi=znC18PAbpDfeVO+=Pat_EeXddjw@mail.gmail.com>
On Thu, May 26, 2011 at 10:53:34AM -0700, Linus Torvalds wrote:
> 2011/5/26 KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>:
> > The type of vma->vm_flags is 'unsigned long'. Neither 'int' nor
> > 'unsigned int'. This patch fixes such misuse.
>
> I applied this, except I also just made the executive decision to
> replace things with "vm_flags_t" after all.
Woo-hoo!
Why it is marked __nocast and not __bitwise__ like gfp_t?
WARNING: multiple messages have this Message-ID (diff)
From: Alexey Dobriyan <adobriyan@gmail.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
benh@kernel.crashing.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, hughd@google.com,
akpm@linux-foundation.org, dave@linux.vnet.ibm.com,
kamezawa.hiroyu@jp.fujitsu.com
Subject: Re: [PATCH] mm: don't access vm_flags as 'int'
Date: Thu, 26 May 2011 21:44:02 +0300 [thread overview]
Message-ID: <20110526184402.GA2453@p183.telecom.by> (raw)
In-Reply-To: <BANLkTi=znC18PAbpDfeVO+=Pat_EeXddjw@mail.gmail.com>
On Thu, May 26, 2011 at 10:53:34AM -0700, Linus Torvalds wrote:
> 2011/5/26 KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>:
> > The type of vma->vm_flags is 'unsigned long'. Neither 'int' nor
> > 'unsigned int'. This patch fixes such misuse.
>
> I applied this, except I also just made the executive decision to
> replace things with "vm_flags_t" after all.
Woo-hoo!
Why it is marked __nocast and not __bitwise__ like gfp_t?
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-05-26 18:44 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-26 10:16 [PATCH] mm: don't access vm_flags as 'int' KOSAKI Motohiro
2011-05-26 10:16 ` KOSAKI Motohiro
2011-05-26 17:53 ` Linus Torvalds
2011-05-26 17:53 ` Linus Torvalds
2011-05-26 18:44 ` Alexey Dobriyan [this message]
2011-05-26 18:44 ` Alexey Dobriyan
2011-05-26 18:49 ` Linus Torvalds
2011-05-26 18:49 ` Linus Torvalds
2011-05-26 18:50 ` richard -rw- weinberger
2011-05-26 18:50 ` richard -rw- weinberger
2011-05-26 19:01 ` Linus Torvalds
2011-05-26 19:01 ` Linus Torvalds
2011-05-27 6:08 ` Ingo Molnar
2011-05-27 6:08 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110526184402.GA2453@p183.telecom.by \
--to=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=benh@kernel.crashing.org \
--cc=dave@linux.vnet.ibm.com \
--cc=hughd@google.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.