From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/3] ARM: mxs: add gpio-mxs platform devices
Date: Fri, 27 May 2011 10:48:00 +0200 [thread overview]
Message-ID: <201105271048.00692.arnd@arndb.de> (raw)
In-Reply-To: <20110527082916.GB30146@S2100-06.ap.freescale.net>
On Friday 27 May 2011, Shawn Guo wrote:
> > I know it's tempting to use macros for these, but I think it obscures
> > the code a lot, especially when you use them to concatenate identifier
> > names. Why not just do:
> >
> > struct platform_device *gpios;
> > gpios = platform_device_register_simple(mxs_host_bus, "mxs-gpio-master", 0, NULL, 0);
> >
> platform_device_register_simple does not have parameter for 'parent',
> and it sets 'parent' NULL anyway.
>
Oops, my mistake. just use platform_device_register_resndata directly then.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: Shawn Guo <shawn.guo@freescale.com>
Cc: linux-arm-kernel@lists.infradead.org,
Shawn Guo <shawn.guo@linaro.org>,
linux-kernel@vger.kernel.org, patches@linaro.org,
linus.walleij@linaro.org, grant.likely@secretlab.ca,
kernel@pengutronix.de
Subject: Re: [PATCH 2/3] ARM: mxs: add gpio-mxs platform devices
Date: Fri, 27 May 2011 10:48:00 +0200 [thread overview]
Message-ID: <201105271048.00692.arnd@arndb.de> (raw)
In-Reply-To: <20110527082916.GB30146@S2100-06.ap.freescale.net>
On Friday 27 May 2011, Shawn Guo wrote:
> > I know it's tempting to use macros for these, but I think it obscures
> > the code a lot, especially when you use them to concatenate identifier
> > names. Why not just do:
> >
> > struct platform_device *gpios;
> > gpios = platform_device_register_simple(mxs_host_bus, "mxs-gpio-master", 0, NULL, 0);
> >
> platform_device_register_simple does not have parameter for 'parent',
> and it sets 'parent' NULL anyway.
>
Oops, my mistake. just use platform_device_register_resndata directly then.
Arnd
next prev parent reply other threads:[~2011-05-27 8:48 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-20 9:57 [PATCH 0/3] remove mach-mxs gpio driver Shawn Guo
2011-05-20 9:57 ` Shawn Guo
2011-05-20 9:57 ` [PATCH 1/3] ARM: mxs: remove gpio driver from mach-mxs Shawn Guo
2011-05-20 9:57 ` Shawn Guo
2011-05-20 10:04 ` Arnd Bergmann
2011-05-20 10:04 ` Arnd Bergmann
2011-05-20 10:27 ` Shawn Guo
2011-05-20 10:27 ` Shawn Guo
2011-05-20 9:57 ` [PATCH 2/3] ARM: mxs: add gpio-mxs platform devices Shawn Guo
2011-05-20 9:57 ` Shawn Guo
2011-05-20 10:23 ` Arnd Bergmann
2011-05-20 10:23 ` Arnd Bergmann
2011-05-20 14:03 ` Shawn Guo
2011-05-20 14:03 ` Shawn Guo
2011-05-20 14:23 ` Arnd Bergmann
2011-05-20 14:23 ` Arnd Bergmann
2011-05-20 14:40 ` Shawn Guo
2011-05-20 14:40 ` Shawn Guo
2011-05-27 9:11 ` Shawn Guo
2011-05-27 9:11 ` Shawn Guo
2011-05-27 11:10 ` Arnd Bergmann
2011-05-27 11:10 ` Arnd Bergmann
2011-05-27 8:29 ` Shawn Guo
2011-05-27 8:29 ` Shawn Guo
2011-05-27 8:48 ` Arnd Bergmann [this message]
2011-05-27 8:48 ` Arnd Bergmann
2011-05-20 9:57 ` [PATCH 3/3] ARM: mxs: select GPIO_MXS for i.MX23 and i.MX28 Shawn Guo
2011-05-20 9:57 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201105271048.00692.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.