From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/3] ARM: mxs: add gpio-mxs platform devices
Date: Fri, 27 May 2011 13:10:18 +0200 [thread overview]
Message-ID: <201105271310.18450.arnd@arndb.de> (raw)
In-Reply-To: <20110527091158.GD30146@S2100-06.ap.freescale.net>
On Friday 27 May 2011, Shawn Guo wrote:
> On Fri, May 20, 2011 at 04:23:40PM +0200, Arnd Bergmann wrote:
> [...]
> > No, this would put all gpio devices below the top-level /sys/devices/platform
> > directory, where they certainly don't belong. Please find a proper
> > place and put them there.
> >
> To make it clear, which one is the best to have all gpio devices below?
>
> * /sys/devices/platform/gpio-mxs
> * /sys/devices/platform/mxs
> * /sys/devices/platform/mxs/gpio
I would say the third one is closes to how it should be.
The (sysfs) device tree, like the of device tree, should ideally be
modeled after the high-level block diagram of the machine.
In case of i.MX23, that could look like
/sys/devices/system \
/ahb
/apbh
/gpio0
/gpio1
/gpmi
/usb0
/apbx
/i2c
/uart0
/pwm
/spi
/mmc
/ethernet
/usb
/rtc
/...
You can argue on whether it makes sense to include the top level, or if you
also want to model the various levels of ahb buses, so there is some freedom
here.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: Shawn Guo <shawn.guo@freescale.com>
Cc: linux-arm-kernel@lists.infradead.org,
Shawn Guo <shawn.guo@linaro.org>,
linux-kernel@vger.kernel.org, patches@linaro.org,
linus.walleij@linaro.org, grant.likely@secretlab.ca,
kernel@pengutronix.de
Subject: Re: [PATCH 2/3] ARM: mxs: add gpio-mxs platform devices
Date: Fri, 27 May 2011 13:10:18 +0200 [thread overview]
Message-ID: <201105271310.18450.arnd@arndb.de> (raw)
In-Reply-To: <20110527091158.GD30146@S2100-06.ap.freescale.net>
On Friday 27 May 2011, Shawn Guo wrote:
> On Fri, May 20, 2011 at 04:23:40PM +0200, Arnd Bergmann wrote:
> [...]
> > No, this would put all gpio devices below the top-level /sys/devices/platform
> > directory, where they certainly don't belong. Please find a proper
> > place and put them there.
> >
> To make it clear, which one is the best to have all gpio devices below?
>
> * /sys/devices/platform/gpio-mxs
> * /sys/devices/platform/mxs
> * /sys/devices/platform/mxs/gpio
I would say the third one is closes to how it should be.
The (sysfs) device tree, like the of device tree, should ideally be
modeled after the high-level block diagram of the machine.
In case of i.MX23, that could look like
/sys/devices/system \
/ahb
/apbh
/gpio0
/gpio1
/gpmi
/usb0
/apbx
/i2c
/uart0
/pwm
/spi
/mmc
/ethernet
/usb
/rtc
/...
You can argue on whether it makes sense to include the top level, or if you
also want to model the various levels of ahb buses, so there is some freedom
here.
Arnd
next prev parent reply other threads:[~2011-05-27 11:10 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-20 9:57 [PATCH 0/3] remove mach-mxs gpio driver Shawn Guo
2011-05-20 9:57 ` Shawn Guo
2011-05-20 9:57 ` [PATCH 1/3] ARM: mxs: remove gpio driver from mach-mxs Shawn Guo
2011-05-20 9:57 ` Shawn Guo
2011-05-20 10:04 ` Arnd Bergmann
2011-05-20 10:04 ` Arnd Bergmann
2011-05-20 10:27 ` Shawn Guo
2011-05-20 10:27 ` Shawn Guo
2011-05-20 9:57 ` [PATCH 2/3] ARM: mxs: add gpio-mxs platform devices Shawn Guo
2011-05-20 9:57 ` Shawn Guo
2011-05-20 10:23 ` Arnd Bergmann
2011-05-20 10:23 ` Arnd Bergmann
2011-05-20 14:03 ` Shawn Guo
2011-05-20 14:03 ` Shawn Guo
2011-05-20 14:23 ` Arnd Bergmann
2011-05-20 14:23 ` Arnd Bergmann
2011-05-20 14:40 ` Shawn Guo
2011-05-20 14:40 ` Shawn Guo
2011-05-27 9:11 ` Shawn Guo
2011-05-27 9:11 ` Shawn Guo
2011-05-27 11:10 ` Arnd Bergmann [this message]
2011-05-27 11:10 ` Arnd Bergmann
2011-05-27 8:29 ` Shawn Guo
2011-05-27 8:29 ` Shawn Guo
2011-05-27 8:48 ` Arnd Bergmann
2011-05-27 8:48 ` Arnd Bergmann
2011-05-20 9:57 ` [PATCH 3/3] ARM: mxs: select GPIO_MXS for i.MX23 and i.MX28 Shawn Guo
2011-05-20 9:57 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201105271310.18450.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.