From: jamie@jamieiles.com (Jamie Iles)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/4] gpio: gpio-mxc: add gpio driver for Freescale MXC architecture
Date: Tue, 31 May 2011 09:44:24 +0100 [thread overview]
Message-ID: <20110531084424.GA2266@pulham.picochip.com> (raw)
In-Reply-To: <1306767139-24763-2-git-send-email-shawn.guo@linaro.org>
Hi Shawn,
On Mon, May 30, 2011 at 10:52:16PM +0800, Shawn Guo wrote:
> Add gpio-mxc driver by copying arch/arm/plat-mxc/gpio.c into
> drivers/gpio with the following changes.
>
> * Use readl/writel to replace mach-specific accessors
> __raw_readl/__raw_writel
>
> * Migrate to platform driver by adding .probe function
>
> * Add a list to save all mx2 ports references, so that
> mx2_gpio_irq_handler can walk through all interrupt status
> registers
>
> Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
> ---
Could you use the stuff in drivers/gpio/basic_mmio_gpio.c for
implementing the gpio_chip? I had a go a little while ago [1] but since
then we've made it possible to embed the bgpio_chip in your own
structure which may be cleaner.
Jamie
1. http://permalink.gmane.org/gmane.linux.ports.arm.kernel/113139
WARNING: multiple messages have this Message-ID (diff)
From: Jamie Iles <jamie@jamieiles.com>
To: Shawn Guo <shawn.guo@linaro.org>
Cc: linux-kernel@vger.kernel.org, grant.likely@secretlab.ca,
arnd@arndb.de, kernel@pengutronix.de,
linux-arm-kernel@lists.infradead.org, patches@linaro.org
Subject: Re: [PATCH 1/4] gpio: gpio-mxc: add gpio driver for Freescale MXC architecture
Date: Tue, 31 May 2011 09:44:24 +0100 [thread overview]
Message-ID: <20110531084424.GA2266@pulham.picochip.com> (raw)
In-Reply-To: <1306767139-24763-2-git-send-email-shawn.guo@linaro.org>
Hi Shawn,
On Mon, May 30, 2011 at 10:52:16PM +0800, Shawn Guo wrote:
> Add gpio-mxc driver by copying arch/arm/plat-mxc/gpio.c into
> drivers/gpio with the following changes.
>
> * Use readl/writel to replace mach-specific accessors
> __raw_readl/__raw_writel
>
> * Migrate to platform driver by adding .probe function
>
> * Add a list to save all mx2 ports references, so that
> mx2_gpio_irq_handler can walk through all interrupt status
> registers
>
> Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
> ---
Could you use the stuff in drivers/gpio/basic_mmio_gpio.c for
implementing the gpio_chip? I had a go a little while ago [1] but since
then we've made it possible to embed the bgpio_chip in your own
structure which may be cleaner.
Jamie
1. http://permalink.gmane.org/gmane.linux.ports.arm.kernel/113139
next prev parent reply other threads:[~2011-05-31 8:44 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-30 14:52 [PATCH 0/4] Move plat-mxc gpio driver into drivers/gpio Shawn Guo
2011-05-30 14:52 ` Shawn Guo
2011-05-30 14:52 ` [PATCH 1/4] gpio: gpio-mxc: add gpio driver for Freescale MXC architecture Shawn Guo
2011-05-30 14:52 ` Shawn Guo
2011-05-31 0:53 ` Olof Johansson
2011-05-31 0:53 ` Olof Johansson
2011-05-31 1:35 ` Shawn Guo
2011-05-31 1:35 ` Shawn Guo
2011-05-31 8:44 ` Jamie Iles [this message]
2011-05-31 8:44 ` Jamie Iles
2011-05-31 9:16 ` Shawn Guo
2011-05-31 9:16 ` Shawn Guo
2011-05-30 14:52 ` [PATCH 2/4] ARM: mxc: migrate mach-mx5 gpio driver to gpio-mxc Shawn Guo
2011-05-30 14:52 ` Shawn Guo
2011-05-31 0:16 ` Olof Johansson
2011-05-31 0:16 ` Olof Johansson
2011-05-31 2:47 ` Shawn Guo
2011-05-31 2:47 ` Shawn Guo
2011-05-31 8:26 ` Arnd Bergmann
2011-05-31 8:26 ` Arnd Bergmann
2011-05-31 10:30 ` Shawn Guo
2011-05-31 10:30 ` Shawn Guo
2011-05-31 11:28 ` Arnd Bergmann
2011-05-31 11:28 ` Arnd Bergmann
2011-05-31 15:10 ` Shawn Guo
2011-05-31 15:10 ` Shawn Guo
2011-05-31 15:27 ` Arnd Bergmann
2011-05-31 15:27 ` Arnd Bergmann
2011-05-31 16:08 ` Shawn Guo
2011-05-31 16:08 ` Shawn Guo
2011-05-31 16:52 ` Olof Johansson
2011-05-31 16:52 ` Olof Johansson
2011-05-30 14:52 ` [PATCH 3/4] ARM: mxc: migrate mach-imx " Shawn Guo
2011-05-30 14:52 ` Shawn Guo
2011-05-30 14:52 ` [PATCH 4/4] ARM: mxc: remove plat-mxc/gpio driver Shawn Guo
2011-05-30 14:52 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110531084424.GA2266@pulham.picochip.com \
--to=jamie@jamieiles.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.