From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/4] ARM: mxc: migrate mach-mx5 gpio driver to gpio-mxc
Date: Tue, 31 May 2011 13:28:17 +0200 [thread overview]
Message-ID: <201105311328.18012.arnd@arndb.de> (raw)
In-Reply-To: <20110531103011.GB32096@S2100-06.ap.freescale.net>
On Tuesday 31 May 2011, Shawn Guo wrote:
> > Just open-code the mxc_add_mxc_gpio() by moving the individual calls to
> > mxc_add_gpio() into the respective callers. Having a global
> > mxc_add_mxc_gpio() function that does something different for each
> > caller seems entirely pointless to me.
> >
> Right now, mxc_add_mxc_gpio() is a postcore_initcall. Moving
> individual mxc_add_gpio() call into irq_init function does not work.
> And I need to find a proper caller for each SoC to call mxc_add_gpio
> to register gpio devices.
Why not init_machine? That is an arch_initcall(), so it's probably close
enough.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: Shawn Guo <shawn.guo@freescale.com>
Cc: Olof Johansson <olof@lixom.net>, Shawn Guo <shawn.guo@linaro.org>,
linux-kernel@vger.kernel.org, grant.likely@secretlab.ca,
kernel@pengutronix.de, linux-arm-kernel@lists.infradead.org,
patches@linaro.org
Subject: Re: [PATCH 2/4] ARM: mxc: migrate mach-mx5 gpio driver to gpio-mxc
Date: Tue, 31 May 2011 13:28:17 +0200 [thread overview]
Message-ID: <201105311328.18012.arnd@arndb.de> (raw)
In-Reply-To: <20110531103011.GB32096@S2100-06.ap.freescale.net>
On Tuesday 31 May 2011, Shawn Guo wrote:
> > Just open-code the mxc_add_mxc_gpio() by moving the individual calls to
> > mxc_add_gpio() into the respective callers. Having a global
> > mxc_add_mxc_gpio() function that does something different for each
> > caller seems entirely pointless to me.
> >
> Right now, mxc_add_mxc_gpio() is a postcore_initcall. Moving
> individual mxc_add_gpio() call into irq_init function does not work.
> And I need to find a proper caller for each SoC to call mxc_add_gpio
> to register gpio devices.
Why not init_machine? That is an arch_initcall(), so it's probably close
enough.
Arnd
next prev parent reply other threads:[~2011-05-31 11:28 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-30 14:52 [PATCH 0/4] Move plat-mxc gpio driver into drivers/gpio Shawn Guo
2011-05-30 14:52 ` Shawn Guo
2011-05-30 14:52 ` [PATCH 1/4] gpio: gpio-mxc: add gpio driver for Freescale MXC architecture Shawn Guo
2011-05-30 14:52 ` Shawn Guo
2011-05-31 0:53 ` Olof Johansson
2011-05-31 0:53 ` Olof Johansson
2011-05-31 1:35 ` Shawn Guo
2011-05-31 1:35 ` Shawn Guo
2011-05-31 8:44 ` Jamie Iles
2011-05-31 8:44 ` Jamie Iles
2011-05-31 9:16 ` Shawn Guo
2011-05-31 9:16 ` Shawn Guo
2011-05-30 14:52 ` [PATCH 2/4] ARM: mxc: migrate mach-mx5 gpio driver to gpio-mxc Shawn Guo
2011-05-30 14:52 ` Shawn Guo
2011-05-31 0:16 ` Olof Johansson
2011-05-31 0:16 ` Olof Johansson
2011-05-31 2:47 ` Shawn Guo
2011-05-31 2:47 ` Shawn Guo
2011-05-31 8:26 ` Arnd Bergmann
2011-05-31 8:26 ` Arnd Bergmann
2011-05-31 10:30 ` Shawn Guo
2011-05-31 10:30 ` Shawn Guo
2011-05-31 11:28 ` Arnd Bergmann [this message]
2011-05-31 11:28 ` Arnd Bergmann
2011-05-31 15:10 ` Shawn Guo
2011-05-31 15:10 ` Shawn Guo
2011-05-31 15:27 ` Arnd Bergmann
2011-05-31 15:27 ` Arnd Bergmann
2011-05-31 16:08 ` Shawn Guo
2011-05-31 16:08 ` Shawn Guo
2011-05-31 16:52 ` Olof Johansson
2011-05-31 16:52 ` Olof Johansson
2011-05-30 14:52 ` [PATCH 3/4] ARM: mxc: migrate mach-imx " Shawn Guo
2011-05-30 14:52 ` Shawn Guo
2011-05-30 14:52 ` [PATCH 4/4] ARM: mxc: remove plat-mxc/gpio driver Shawn Guo
2011-05-30 14:52 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201105311328.18012.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.