* [PATCH] libxl: use '-name' instead of deprecated '-domain-name' for device model
@ 2011-06-07 6:48 Wei Liu
2011-06-07 11:52 ` Stefano Stabellini
0 siblings, 1 reply; 6+ messages in thread
From: Wei Liu @ 2011-06-07 6:48 UTC (permalink / raw)
To: xen-devel
commit 6c744543757f0769e5a8f49ab0d8a01538357fbb
Author: Wei Liu <liuw@liuw.name>
Date: Tue Jun 7 14:26:34 2011 +0800
libxl: use '-name' instead of deprecated '-domain-name' for device model.
This unifies upstream qemu and Xen's qemu-dm startup option.
Signed-off-by: Wei Liu <liuw@liuw.name>
diff --git a/tools/libxl/libxl_dm.c b/tools/libxl/libxl_dm.c
index 47a51c8..d53a20d 100644
--- a/tools/libxl/libxl_dm.c
+++ b/tools/libxl/libxl_dm.c
@@ -95,7 +95,7 @@ static char ** libxl__build_device_model_args_old(libxl__gc *gc,
"-d", libxl__sprintf(gc, "%d", info->domid), NULL);
if (info->dom_name)
- flexarray_vappend(dm_args, "-domain-name", info->dom_name, NULL);
+ flexarray_vappend(dm_args, "-name", info->dom_name, NULL);
if (info->vnc) {
char *vncarg;
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] libxl: use '-name' instead of deprecated '-domain-name' for device model
2011-06-07 6:48 [PATCH] libxl: use '-name' instead of deprecated '-domain-name' for device model Wei Liu
@ 2011-06-07 11:52 ` Stefano Stabellini
2011-06-07 12:11 ` Wei Liu
2011-06-07 12:16 ` Wei Liu
0 siblings, 2 replies; 6+ messages in thread
From: Stefano Stabellini @ 2011-06-07 11:52 UTC (permalink / raw)
To: Wei Liu; +Cc: xen-devel@lists.xensource.com
On Tue, 7 Jun 2011, Wei Liu wrote:
> commit 6c744543757f0769e5a8f49ab0d8a01538357fbb
> Author: Wei Liu <liuw@liuw.name>
> Date: Tue Jun 7 14:26:34 2011 +0800
>
> libxl: use '-name' instead of deprecated '-domain-name' for device model.
>
> This unifies upstream qemu and Xen's qemu-dm startup option.
>
> Signed-off-by: Wei Liu <liuw@liuw.name>
>
> diff --git a/tools/libxl/libxl_dm.c b/tools/libxl/libxl_dm.c
> index 47a51c8..d53a20d 100644
> --- a/tools/libxl/libxl_dm.c
> +++ b/tools/libxl/libxl_dm.c
> @@ -95,7 +95,7 @@ static char ** libxl__build_device_model_args_old(libxl__gc *gc,
> "-d", libxl__sprintf(gc, "%d", info->domid), NULL);
>
> if (info->dom_name)
> - flexarray_vappend(dm_args, "-domain-name", info->dom_name, NULL);
> + flexarray_vappend(dm_args, "-name", info->dom_name, NULL);
>
> if (info->vnc) {
> char *vncarg;
considering that libxl__build_device_model_args_old is only meant to be
used with the old qemu-xen that we are not going to upgrade anymore, I
don't think it is worth to try to update its command line options.
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] libxl: use '-name' instead of deprecated '-domain-name' for device model
2011-06-07 11:52 ` Stefano Stabellini
@ 2011-06-07 12:11 ` Wei Liu
2011-06-07 12:54 ` Stefano Stabellini
2011-06-07 12:16 ` Wei Liu
1 sibling, 1 reply; 6+ messages in thread
From: Wei Liu @ 2011-06-07 12:11 UTC (permalink / raw)
To: Stefano Stabellini; +Cc: xen-devel@lists.xensource.com
On Tue, Jun 7, 2011 at 7:52 PM, Stefano Stabellini
<stefano.stabellini@eu.citrix.com> wrote:
> On Tue, 7 Jun 2011, Wei Liu wrote:
>> commit 6c744543757f0769e5a8f49ab0d8a01538357fbb
>> Author: Wei Liu <liuw@liuw.name>
>> Date: Tue Jun 7 14:26:34 2011 +0800
>>
>> libxl: use '-name' instead of deprecated '-domain-name' for device model.
>>
>> This unifies upstream qemu and Xen's qemu-dm startup option.
>>
>> Signed-off-by: Wei Liu <liuw@liuw.name>
>>
>> diff --git a/tools/libxl/libxl_dm.c b/tools/libxl/libxl_dm.c
>> index 47a51c8..d53a20d 100644
>> --- a/tools/libxl/libxl_dm.c
>> +++ b/tools/libxl/libxl_dm.c
>> @@ -95,7 +95,7 @@ static char ** libxl__build_device_model_args_old(libxl__gc *gc,
>> "-d", libxl__sprintf(gc, "%d", info->domid), NULL);
>>
>> if (info->dom_name)
>> - flexarray_vappend(dm_args, "-domain-name", info->dom_name, NULL);
>> + flexarray_vappend(dm_args, "-name", info->dom_name, NULL);
>>
>> if (info->vnc) {
>> char *vncarg;
>
> considering that libxl__build_device_model_args_old is only meant to be
> used with the old qemu-xen that we are not going to upgrade anymore, I
> don't think it is worth to try to update its command line options.
>
Well, the device_model_{override,version} are not working for pv now.
So I consider this patch a workaround for using upstream qemu as pure
pv backend.
I'm still waiting for IanJ's re-factoring of libxl. Hope that could
get a better implementation.
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] libxl: use '-name' instead of deprecated '-domain-name' for device model
2011-06-07 12:11 ` Wei Liu
@ 2011-06-07 12:54 ` Stefano Stabellini
0 siblings, 0 replies; 6+ messages in thread
From: Stefano Stabellini @ 2011-06-07 12:54 UTC (permalink / raw)
To: Wei Liu; +Cc: xen-devel@lists.xensource.com, Stefano Stabellini
[-- Attachment #1: Type: text/plain, Size: 1747 bytes --]
On Tue, 7 Jun 2011, Wei Liu wrote:
> On Tue, Jun 7, 2011 at 7:52 PM, Stefano Stabellini
> <stefano.stabellini@eu.citrix.com> wrote:
> > On Tue, 7 Jun 2011, Wei Liu wrote:
> >> commit 6c744543757f0769e5a8f49ab0d8a01538357fbb
> >> Author: Wei Liu <liuw@liuw.name>
> >> Date: Tue Jun 7 14:26:34 2011 +0800
> >>
> >> libxl: use '-name' instead of deprecated '-domain-name' for device model.
> >>
> >> This unifies upstream qemu and Xen's qemu-dm startup option.
> >>
> >> Signed-off-by: Wei Liu <liuw@liuw.name>
> >>
> >> diff --git a/tools/libxl/libxl_dm.c b/tools/libxl/libxl_dm.c
> >> index 47a51c8..d53a20d 100644
> >> --- a/tools/libxl/libxl_dm.c
> >> +++ b/tools/libxl/libxl_dm.c
> >> @@ -95,7 +95,7 @@ static char ** libxl__build_device_model_args_old(libxl__gc *gc,
> >> "-d", libxl__sprintf(gc, "%d", info->domid), NULL);
> >>
> >> if (info->dom_name)
> >> - flexarray_vappend(dm_args, "-domain-name", info->dom_name, NULL);
> >> + flexarray_vappend(dm_args, "-name", info->dom_name, NULL);
> >>
> >> if (info->vnc) {
> >> char *vncarg;
> >
> > considering that libxl__build_device_model_args_old is only meant to be
> > used with the old qemu-xen that we are not going to upgrade anymore, I
> > don't think it is worth to try to update its command line options.
> >
>
> Well, the device_model_{override,version} are not working for pv now.
> So I consider this patch a workaround for using upstream qemu as pure
> pv backend.
>
> I'm still waiting for IanJ's re-factoring of libxl. Hope that could
> get a better implementation.
>
IanJ is not going to touch this code AFAIK, so you can go ahead and
write a proper patch for that.
[-- Attachment #2: Type: text/plain, Size: 138 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] libxl: use '-name' instead of deprecated '-domain-name' for device model
2011-06-07 11:52 ` Stefano Stabellini
2011-06-07 12:11 ` Wei Liu
@ 2011-06-07 12:16 ` Wei Liu
2011-06-07 12:54 ` Ian Campbell
1 sibling, 1 reply; 6+ messages in thread
From: Wei Liu @ 2011-06-07 12:16 UTC (permalink / raw)
To: Stefano Stabellini; +Cc: xen-devel@lists.xensource.com
On Tue, Jun 07, 2011 at 12:52:03PM +0100, Stefano Stabellini wrote:
> On Tue, 7 Jun 2011, Wei Liu wrote:
> > commit 6c744543757f0769e5a8f49ab0d8a01538357fbb
> > Author: Wei Liu <liuw@liuw.name>
> > Date: Tue Jun 7 14:26:34 2011 +0800
> >
> > libxl: use '-name' instead of deprecated '-domain-name' for device model.
> >
> > This unifies upstream qemu and Xen's qemu-dm startup option.
> >
> > Signed-off-by: Wei Liu <liuw@liuw.name>
> >
> > diff --git a/tools/libxl/libxl_dm.c b/tools/libxl/libxl_dm.c
> > index 47a51c8..d53a20d 100644
> > --- a/tools/libxl/libxl_dm.c
> > +++ b/tools/libxl/libxl_dm.c
> > @@ -95,7 +95,7 @@ static char ** libxl__build_device_model_args_old(libxl__gc *gc,
> > "-d", libxl__sprintf(gc, "%d", info->domid), NULL);
> >
> > if (info->dom_name)
> > - flexarray_vappend(dm_args, "-domain-name", info->dom_name, NULL);
> > + flexarray_vappend(dm_args, "-name", info->dom_name, NULL);
> >
> > if (info->vnc) {
> > char *vncarg;
>
> considering that libxl__build_device_model_args_old is only meant to be
> used with the old qemu-xen that we are not going to upgrade anymore, I
> don't think it is worth to try to update its command line options.
Well, device_model_{override,version} are not working for pure pv. I
consider this patch a workaround for using upstream qemu as pure pv
backend.
I hope that IanJ's re-factoring of libxl will get a better
implementation of this.
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] libxl: use '-name' instead of deprecated '-domain-name' for device model
2011-06-07 12:16 ` Wei Liu
@ 2011-06-07 12:54 ` Ian Campbell
0 siblings, 0 replies; 6+ messages in thread
From: Ian Campbell @ 2011-06-07 12:54 UTC (permalink / raw)
To: Wei Liu; +Cc: xen-devel@lists.xensource.com, Stefano Stabellini
On Tue, 2011-06-07 at 13:16 +0100, Wei Liu wrote:
> On Tue, Jun 07, 2011 at 12:52:03PM +0100, Stefano Stabellini wrote:
> > On Tue, 7 Jun 2011, Wei Liu wrote:
> > > commit 6c744543757f0769e5a8f49ab0d8a01538357fbb
> > > Author: Wei Liu <liuw@liuw.name>
> > > Date: Tue Jun 7 14:26:34 2011 +0800
> > >
> > > libxl: use '-name' instead of deprecated '-domain-name' for device model.
> > >
> > > This unifies upstream qemu and Xen's qemu-dm startup option.
> > >
> > > Signed-off-by: Wei Liu <liuw@liuw.name>
> > >
> > > diff --git a/tools/libxl/libxl_dm.c b/tools/libxl/libxl_dm.c
> > > index 47a51c8..d53a20d 100644
> > > --- a/tools/libxl/libxl_dm.c
> > > +++ b/tools/libxl/libxl_dm.c
> > > @@ -95,7 +95,7 @@ static char ** libxl__build_device_model_args_old(libxl__gc *gc,
> > > "-d", libxl__sprintf(gc, "%d", info->domid), NULL);
> > >
> > > if (info->dom_name)
> > > - flexarray_vappend(dm_args, "-domain-name", info->dom_name, NULL);
> > > + flexarray_vappend(dm_args, "-name", info->dom_name, NULL);
> > >
> > > if (info->vnc) {
> > > char *vncarg;
> >
> > considering that libxl__build_device_model_args_old is only meant to be
> > used with the old qemu-xen that we are not going to upgrade anymore, I
> > don't think it is worth to try to update its command line options.
>
> Well, device_model_{override,version} are not working for pure pv.
I think it would be preferable to tackle this directly rather than
working around it.
> I
> consider this patch a workaround for using upstream qemu as pure pv
> backend.
>
> I hope that IanJ's re-factoring of libxl will get a better
> implementation of this.
I wasn't aware of any intention (by IanJ or otherwise) to refactor
anything in this particular area.
Ian.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2011-06-07 12:54 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-06-07 6:48 [PATCH] libxl: use '-name' instead of deprecated '-domain-name' for device model Wei Liu
2011-06-07 11:52 ` Stefano Stabellini
2011-06-07 12:11 ` Wei Liu
2011-06-07 12:54 ` Stefano Stabellini
2011-06-07 12:16 ` Wei Liu
2011-06-07 12:54 ` Ian Campbell
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.