From: Arnd Bergmann <arnd@arndb.de>
To: Alexander Graf <agraf@suse.de>
Cc: KVM list <kvm@vger.kernel.org>, kvm-ppc@vger.kernel.org
Subject: Re: [PATCH] KVM: Add compat ioctl for KVM_SET_SIGNAL_MASK
Date: Tue, 07 Jun 2011 20:52:36 +0000 [thread overview]
Message-ID: <201106072252.36636.arnd@arndb.de> (raw)
In-Reply-To: <1307478315-15564-1-git-send-email-agraf@suse.de>
On Tuesday 07 June 2011 22:25:15 Alexander Graf wrote:
> +static long kvm_vcpu_compat_ioctl(struct file *filp,
> + unsigned int ioctl, unsigned long arg)
> +{
> + struct kvm_vcpu *vcpu = filp->private_data;
> + void __user *argp = (void __user *)arg;
Converting a compat user argument into a pointer should use the
compat_ptr() function to do the right thing on s390. Otherwise
your patch looks good.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: Alexander Graf <agraf@suse.de>
Cc: KVM list <kvm@vger.kernel.org>, kvm-ppc@vger.kernel.org
Subject: Re: [PATCH] KVM: Add compat ioctl for KVM_SET_SIGNAL_MASK
Date: Tue, 7 Jun 2011 22:52:36 +0200 [thread overview]
Message-ID: <201106072252.36636.arnd@arndb.de> (raw)
In-Reply-To: <1307478315-15564-1-git-send-email-agraf@suse.de>
On Tuesday 07 June 2011 22:25:15 Alexander Graf wrote:
> +static long kvm_vcpu_compat_ioctl(struct file *filp,
> + unsigned int ioctl, unsigned long arg)
> +{
> + struct kvm_vcpu *vcpu = filp->private_data;
> + void __user *argp = (void __user *)arg;
Converting a compat user argument into a pointer should use the
compat_ptr() function to do the right thing on s390. Otherwise
your patch looks good.
Arnd
next prev parent reply other threads:[~2011-06-07 20:52 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-07 20:25 [PATCH] KVM: Add compat ioctl for KVM_SET_SIGNAL_MASK Alexander Graf
2011-06-07 20:25 ` Alexander Graf
2011-06-07 20:52 ` Arnd Bergmann [this message]
2011-06-07 20:52 ` Arnd Bergmann
2011-06-08 0:45 ` Alexander Graf
2011-06-08 0:45 ` Alexander Graf
2011-06-09 12:24 ` Avi Kivity
2011-06-09 12:24 ` Avi Kivity
2011-06-09 15:57 ` Paolo Bonzini
2011-06-09 15:57 ` Paolo Bonzini
2011-06-19 13:37 ` Avi Kivity
2011-06-19 13:37 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201106072252.36636.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=agraf@suse.de \
--cc=kvm-ppc@vger.kernel.org \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.