Re: [PATCH] KVM: Add compat ioctl for KVM_SET_SIGNAL_MASK

[Paolo Bonzini <pbonzini@redhat.com>]

On 06/09/2011 02:24 PM, Avi Kivity wrote:
> On 06/08/2011 03:45 AM, Alexander Graf wrote:
>> KVM has an ioctl to define which signal mask should be used while running
>> inside VCPU_RUN. At least for big endian systems, this mask is different
>> on 32-bit and 64-bit systems (though the size is identical).
>>
>> Add a compat wrapper that converts the mask to whatever the kernel
>> accepts,
>> allowing 32-bit kvm user space to set signal masks.
>>
>> This patch fixes qemu with --enable-io-thread on ppc64 hosts when running
>> 32-bit user land.
>
> Applied, thanks.

And here's the matching documentation change.  Kunz-kunz, Alex. :)

-------------------------- 8< -----------------------------
 From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
From: Paolo Bonzini <pbonzini@redhat.com>
Date: Thu, 9 Jun 2011 17:48:50 +0200
Subject: [PATCH] KVM: fix documentation for KVM_SET_SIGNAL_MASK

The signal mask passed to KVM_SET_SIGNAL_MASK needs to be ABI-compatible
with sigprocmask, so that functions operating on sigset_t can be used
with it.  Referring to the signal mask as an array of bytes is incorrect
on big endian systems, fix it.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
  Documentation/kvm/api.txt |    4 ++--
  1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/Documentation/kvm/api.txt b/Documentation/kvm/api.txt
index 9bef4e4..ec15972 100644
--- a/Documentation/kvm/api.txt
+++ b/Documentation/kvm/api.txt
@@ -464,8 +464,8 @@ signal mask.

  /* for KVM_SET_SIGNAL_MASK */
  struct kvm_signal_mask {
-	__u32 len;
-	__u8  sigset[0];
+	__u32          len;
+	unsigned long  sigset[0];
  };

  4.22 KVM_GET_FPU
-- 
1.7.4.4