All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Jarkko Nikula <jhnikula@gmail.com>
Cc: Peter Ujfalusi <peter.ujfalusi@ti.com>,
	alsa-devel@alsa-project.org, Liam Girdwood <lrg@ti.com>,
	stable@kernel.org
Subject: Re: [PATCH] ASoC: omap-mcbsp: Do not attempt to change DAI sysclk if stream is active
Date: Fri, 10 Jun 2011 12:35:30 +0100	[thread overview]
Message-ID: <20110610113529.GJ26436@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1307705335-2836-1-git-send-email-jhnikula@gmail.com>

On Fri, Jun 10, 2011 at 02:28:55PM +0300, Jarkko Nikula wrote:

>  
> +	if (mcbsp_data->active)
> +		return 0;
> +

Shouldn't we be returning -EBUSY or something here so the caller knows
we didn't do what it asked (after checking to make sure it's not just
trying to set the existing configuration)?  Otherwise it might get
surprised, assume the new configuration and just move the bug elsewhere.

  reply	other threads:[~2011-06-10 11:35 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-10 11:28 [PATCH] ASoC: omap-mcbsp: Do not attempt to change DAI sysclk if stream is active Jarkko Nikula
2011-06-10 11:35 ` Mark Brown [this message]
2011-06-10 11:56   ` Jarkko Nikula
2011-06-10 11:59     ` Mark Brown
2011-06-10 12:37       ` Jarkko Nikula
2011-06-10 11:36 ` Péter Ujfalusi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110610113529.GJ26436@opensource.wolfsonmicro.com \
    --to=broonie@opensource.wolfsonmicro.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=jhnikula@gmail.com \
    --cc=lrg@ti.com \
    --cc=peter.ujfalusi@ti.com \
    --cc=stable@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.