From: Jarkko Nikula <jhnikula@gmail.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Peter Ujfalusi <peter.ujfalusi@ti.com>,
alsa-devel@alsa-project.org, Liam Girdwood <lrg@ti.com>,
stable@kernel.org
Subject: Re: [PATCH] ASoC: omap-mcbsp: Do not attempt to change DAI sysclk if stream is active
Date: Fri, 10 Jun 2011 15:37:54 +0300 [thread overview]
Message-ID: <20110610153754.3c91a03c.jhnikula@gmail.com> (raw)
In-Reply-To: <20110610115954.GK26436@opensource.wolfsonmicro.com>
On Fri, 10 Jun 2011 12:59:54 +0100
Mark Brown <broonie@opensource.wolfsonmicro.com> wrote:
> On Fri, Jun 10, 2011 at 02:56:10PM +0300, Jarkko Nikula wrote:
>
> > I was thinking to return -EBUSY here but went thinking is it really
> > worth of trouble? Machine drivers are calling this from their hw_params
> > callback with the same configuration always (I suppose) for both
> > playback and capture and it sounded kind of overkill to check what is
> > existing configuration or skip the -EBUSY error.
>
> One fairly common case is selecting the system clock rate to a fixed
> multiple of the sample rate so applications that try to set up different
> playback and record rates trigger issues.
Umm, yeah. I'll cook another version which returns -EBUSY but still
trying to keep this regression fix minimal. Anyway it's only pandora
that can trigger the regression in mainline.
--
Jarkko
next prev parent reply other threads:[~2011-06-10 12:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-10 11:28 [PATCH] ASoC: omap-mcbsp: Do not attempt to change DAI sysclk if stream is active Jarkko Nikula
2011-06-10 11:35 ` Mark Brown
2011-06-10 11:56 ` Jarkko Nikula
2011-06-10 11:59 ` Mark Brown
2011-06-10 12:37 ` Jarkko Nikula [this message]
2011-06-10 11:36 ` Péter Ujfalusi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110610153754.3c91a03c.jhnikula@gmail.com \
--to=jhnikula@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=lrg@ti.com \
--cc=peter.ujfalusi@ti.com \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.