From: "Péter Ujfalusi" <peter.ujfalusi@ti.com>
To: Jarkko Nikula <jhnikula@gmail.com>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
"Girdwood, Liam" <lrg@ti.com>,
"stable@kernel.org" <stable@kernel.org>
Subject: Re: [PATCH] ASoC: omap-mcbsp: Do not attempt to change DAI sysclk if stream is active
Date: Fri, 10 Jun 2011 14:36:52 +0300 [thread overview]
Message-ID: <201106101436.53099.peter.ujfalusi@ti.com> (raw)
In-Reply-To: <1307705335-2836-1-git-send-email-jhnikula@gmail.com>
On Friday 10 June 2011 14:28:55 Jarkko Nikula wrote:
> Attempt to change McBSP CLKS source while another stream is active is not
> safe after commit d135865 ("OMAP: McBSP: implement functional clock
> switching via clock framework") in 2.6.37.
>
> CLKS parent clock switching using clock framework have to idle the McBSP
> before switching and then activate it again. This short break can cause a
> DMA transaction error to already running stream which halts and recovers
> only by closing and restarting the stream.
>
> This goes more fatal after commit e2fa61d ("OMAP3: l3: Introduce
> l3-interconnect error handling driver") in 2.6.39 where l3 driver detects a
> severe timeout error and does BUG_ON().
>
> Fix this by checking is the McBSP active in omap_mcbsp_dai_set_dai_sysclk
> before attempting to change any clocking configuration. This test should
> have been here just from the beginning anyway.
>
> Signed-off-by: Jarkko Nikula <jhnikula@gmail.com>
> Cc: stable@kernel.org
Acked-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
prev parent reply other threads:[~2011-06-10 11:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-10 11:28 [PATCH] ASoC: omap-mcbsp: Do not attempt to change DAI sysclk if stream is active Jarkko Nikula
2011-06-10 11:35 ` Mark Brown
2011-06-10 11:56 ` Jarkko Nikula
2011-06-10 11:59 ` Mark Brown
2011-06-10 12:37 ` Jarkko Nikula
2011-06-10 11:36 ` Péter Ujfalusi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201106101436.53099.peter.ujfalusi@ti.com \
--to=peter.ujfalusi@ti.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=jhnikula@gmail.com \
--cc=lrg@ti.com \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.