From: Wolfram Sang <w.sang@pengutronix.de>
To: Shawn Guo <shawn.guo@freescale.com>
Cc: Shawn Guo <shawn.guo@linaro.org>,
linux-mmc@vger.kernel.org, Chris Ball <cjb@laptop.org>,
Eric Benard <eric@eukrea.com>,
Arnaud Patard <arnaud.patard@rtp-net.org>,
kernel@pengutronix.de, linux-arm-kernel@lists.infradead.org,
patches@linaro.org
Subject: Re: [PATCH v2 4/4] mmc: sdhci-esdhc-imx: extend card_detect and write_protect support for mx5
Date: Wed, 15 Jun 2011 12:44:04 +0200 [thread overview]
Message-ID: <20110615104404.GA3097@pengutronix.de> (raw)
In-Reply-To: <20110615103344.GA3579@S2100-06.ap.freescale.net>
[-- Attachment #1: Type: text/plain, Size: 684 bytes --]
> Sorry. I had some reason for moving esdhc_pltfm_get_ro around. We
> can not keep the existing approach (what I said above). For mx51
> babbage example, esdhc1 uses internal WP while esdhc2 uses gpio WP.
> If we have esdhc_pltfm_get_ro handle gpio only and assign it to
> sdhci_esdhc_ops.get_ro in .probe only when wp_type is ESDHC_WP_GPIO,
> that works for esdhc2 but breaks esdhc1 WP function. So no, I will
> not change my code except adding NONE case handling there.
Ok, fine with me. Thanks for checking!
--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: w.sang@pengutronix.de (Wolfram Sang)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 4/4] mmc: sdhci-esdhc-imx: extend card_detect and write_protect support for mx5
Date: Wed, 15 Jun 2011 12:44:04 +0200 [thread overview]
Message-ID: <20110615104404.GA3097@pengutronix.de> (raw)
In-Reply-To: <20110615103344.GA3579@S2100-06.ap.freescale.net>
> Sorry. I had some reason for moving esdhc_pltfm_get_ro around. We
> can not keep the existing approach (what I said above). For mx51
> babbage example, esdhc1 uses internal WP while esdhc2 uses gpio WP.
> If we have esdhc_pltfm_get_ro handle gpio only and assign it to
> sdhci_esdhc_ops.get_ro in .probe only when wp_type is ESDHC_WP_GPIO,
> that works for esdhc2 but breaks esdhc1 WP function. So no, I will
> not change my code except adding NONE case handling there.
Ok, fine with me. Thanks for checking!
--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20110615/d5cff7fc/attachment.sig>
next prev parent reply other threads:[~2011-06-15 10:44 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-10 10:42 [PATCH 0/4] Extend sdhci-esdhc-imx card_detect and write_protect support for mx5 Shawn Guo
2011-06-10 10:42 ` Shawn Guo
2011-06-10 10:42 ` [PATCH 1/4] mmc: sdhci: fix interrupt storm from card detection Shawn Guo
2011-06-10 10:42 ` Shawn Guo
2011-06-14 9:24 ` Wolfram Sang
2011-06-14 9:24 ` Wolfram Sang
2011-06-14 11:55 ` Shawn Guo
2011-06-14 11:55 ` Shawn Guo
2011-06-14 12:02 ` Wolfram Sang
2011-06-14 12:02 ` Wolfram Sang
2011-06-14 12:24 ` Shawn Guo
2011-06-14 12:24 ` Shawn Guo
2011-06-10 10:42 ` [PATCH 2/4] mmc: sdhci-esdhc-imx: SDHCI_CARD_PRESENT does not get cleared Shawn Guo
2011-06-10 10:42 ` Shawn Guo
2011-06-14 9:22 ` Wolfram Sang
2011-06-14 9:22 ` Wolfram Sang
2011-06-10 10:42 ` [PATCH 3/4] mmc: sdhci-esdhc-imx: remove "WP" from flag ESDHC_FLAG_GPIO_FOR_CD_WP Shawn Guo
2011-06-10 10:42 ` Shawn Guo
2011-06-14 9:28 ` Wolfram Sang
2011-06-14 9:28 ` Wolfram Sang
2011-06-14 11:51 ` Shawn Guo
2011-06-14 11:51 ` Shawn Guo
2011-06-10 10:42 ` [PATCH 4/4] mmc: sdhci-esdhc-imx: extend card_detect and write_protect support Shawn Guo
2011-06-10 10:42 ` Shawn Guo
2011-06-11 9:30 ` Arnaud Patard
2011-06-11 9:30 ` Arnaud Patard (Rtp)
2011-06-11 11:50 ` Shawn Guo
2011-06-11 11:50 ` Shawn Guo
2011-06-11 11:59 ` Arnaud Patard
2011-06-11 11:59 ` Arnaud Patard (Rtp)
2011-06-11 13:16 ` Shawn Guo
2011-06-11 13:16 ` Shawn Guo
2011-06-11 19:21 ` Arnaud Patard
2011-06-11 19:21 ` Arnaud Patard (Rtp)
2011-06-14 6:47 ` [PATCH v2 4/4] mmc: sdhci-esdhc-imx: extend card_detect and write_protect support for mx5 Shawn Guo
2011-06-14 6:47 ` Shawn Guo
2011-06-14 9:51 ` Wolfram Sang
2011-06-14 9:51 ` Wolfram Sang
2011-06-14 13:06 ` Shawn Guo
2011-06-14 13:06 ` Shawn Guo
2011-06-14 13:55 ` Wolfram Sang
2011-06-14 13:55 ` Wolfram Sang
2011-06-15 3:10 ` Shawn Guo
2011-06-15 3:10 ` Shawn Guo
2011-06-15 10:33 ` Shawn Guo
2011-06-15 10:33 ` Shawn Guo
2011-06-15 10:44 ` Wolfram Sang [this message]
2011-06-15 10:44 ` Wolfram Sang
2011-06-14 6:48 ` [PATCH 0/4] Extend sdhci-esdhc-imx " Shawn Guo
2011-06-14 6:48 ` Shawn Guo
2011-06-14 11:13 ` Arnaud Patard
2011-06-14 11:13 ` Arnaud Patard (Rtp)
2011-06-14 11:39 ` Shawn Guo
2011-06-14 11:39 ` Shawn Guo
2011-06-14 13:12 ` Shawn Guo
2011-06-14 13:12 ` Shawn Guo
2011-06-14 14:29 ` Arnaud Patard
2011-06-14 14:29 ` Arnaud Patard (Rtp)
2011-06-15 3:13 ` Shawn Guo
2011-06-15 3:13 ` Shawn Guo
2011-06-16 18:32 ` Arnaud Patard
2011-06-16 18:32 ` Arnaud Patard (Rtp)
2011-06-20 10:41 ` Shawn Guo
2011-06-20 10:41 ` Shawn Guo
-- strict thread matches above, loose matches on Subject: below --
2011-06-15 11:15 [PATCH v2 " Shawn Guo
2011-06-15 11:15 ` [PATCH v2 4/4] mmc: sdhci-esdhc-imx: extend " Shawn Guo
2011-06-15 11:15 ` Shawn Guo
2011-06-16 12:10 ` Wolfram Sang
2011-06-16 12:10 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110615104404.GA3097@pengutronix.de \
--to=w.sang@pengutronix.de \
--cc=arnaud.patard@rtp-net.org \
--cc=cjb@laptop.org \
--cc=eric@eukrea.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mmc@vger.kernel.org \
--cc=patches@linaro.org \
--cc=shawn.guo@freescale.com \
--cc=shawn.guo@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.