All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnaud Patard (Rtp) <arnaud.patard@rtp-net.org>
To: Shawn Guo <shawn.guo@freescale.com>
Cc: Eric Benard <eric@eukrea.com>,
	patches@linaro.org, linux-mmc@vger.kernel.org,
	Wolfram Sang <w.sang@pengutronix.de>,
	kernel@pengutronix.de, Chris Ball <cjb@laptop.org>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 0/4] Extend sdhci-esdhc-imx card_detect and write_protect support for mx5
Date: Thu, 16 Jun 2011 20:32:33 +0200	[thread overview]
Message-ID: <87lix1hbjy.fsf@lebrac.rtp-net.org> (raw)
In-Reply-To: <20110614064841.GB30295@S2100-06.ap.freescale.net> (Shawn Guo's message of "Tue, 14 Jun 2011 14:48:42 +0800")

Shawn Guo <shawn.guo@freescale.com> writes:

Hi,

> On Fri, Jun 10, 2011 at 06:42:48PM +0800, Shawn Guo wrote:
>> The card-present polling within sdhci based driver is very expensive
>> in terms of the impact to system performance.  We observe a few
>> system performance issues from Freescale and Linaro on mx5 platforms,
>> which have been proved card polling related.
>> 
>> The patch set extends the current sdhci-esdhc-imx card_detect and
>> write_protect support to cover mx5 platforms, and solves above
>> performance issues.
>> 
>> Shawn Guo (4):
>>       mmc: sdhci: fix interrupt storm from card detection
>>       mmc: sdhci-esdhc-imx: SDHCI_CARD_PRESENT does not get cleared
>>       mmc: sdhci-esdhc-imx: remove "WP" from flag ESDHC_FLAG_GPIO_FOR_CD_WP
>>       mmc: sdhci-esdhc-imx: extend card_detect and write_protect support
>> 
> Hi Arnaud,
>
> Any chance to play with it yet?

Finally managed to build a kernel with this version of the
patchset. While I'm not polling anymore, I'm getting a lot of interrupts
if the card is not inserted. Theses interrupts are not happening if the
card is inserted. I can see things like this in the logs :
sdhci [sdhci_irq()]: *** mmc0 got interrupt: 0x00000080

[ of course, the bit of the present state register indicating card
presence is equal to 0 ]

I've tested the SIGNAL case only. Don't know if switch to GPIO may help.
Do you have same kind of issue on your side ?

Thanks,
Arnaud

WARNING: multiple messages have this Message-ID (diff)
From: arnaud.patard@rtp-net.org (Arnaud Patard (Rtp))
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 0/4] Extend sdhci-esdhc-imx card_detect and write_protect support for mx5
Date: Thu, 16 Jun 2011 20:32:33 +0200	[thread overview]
Message-ID: <87lix1hbjy.fsf@lebrac.rtp-net.org> (raw)
In-Reply-To: <20110614064841.GB30295@S2100-06.ap.freescale.net> (Shawn Guo's message of "Tue, 14 Jun 2011 14:48:42 +0800")

Shawn Guo <shawn.guo@freescale.com> writes:

Hi,

> On Fri, Jun 10, 2011 at 06:42:48PM +0800, Shawn Guo wrote:
>> The card-present polling within sdhci based driver is very expensive
>> in terms of the impact to system performance.  We observe a few
>> system performance issues from Freescale and Linaro on mx5 platforms,
>> which have been proved card polling related.
>> 
>> The patch set extends the current sdhci-esdhc-imx card_detect and
>> write_protect support to cover mx5 platforms, and solves above
>> performance issues.
>> 
>> Shawn Guo (4):
>>       mmc: sdhci: fix interrupt storm from card detection
>>       mmc: sdhci-esdhc-imx: SDHCI_CARD_PRESENT does not get cleared
>>       mmc: sdhci-esdhc-imx: remove "WP" from flag ESDHC_FLAG_GPIO_FOR_CD_WP
>>       mmc: sdhci-esdhc-imx: extend card_detect and write_protect support
>> 
> Hi Arnaud,
>
> Any chance to play with it yet?

Finally managed to build a kernel with this version of the
patchset. While I'm not polling anymore, I'm getting a lot of interrupts
if the card is not inserted. Theses interrupts are not happening if the
card is inserted. I can see things like this in the logs :
sdhci [sdhci_irq()]: *** mmc0 got interrupt: 0x00000080

[ of course, the bit of the present state register indicating card
presence is equal to 0 ]

I've tested the SIGNAL case only. Don't know if switch to GPIO may help.
Do you have same kind of issue on your side ?

Thanks,
Arnaud

  parent reply	other threads:[~2011-06-16 18:32 UTC|newest]

Thread overview: 64+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-10 10:42 [PATCH 0/4] Extend sdhci-esdhc-imx card_detect and write_protect support for mx5 Shawn Guo
2011-06-10 10:42 ` Shawn Guo
2011-06-10 10:42 ` [PATCH 1/4] mmc: sdhci: fix interrupt storm from card detection Shawn Guo
2011-06-10 10:42   ` Shawn Guo
2011-06-14  9:24   ` Wolfram Sang
2011-06-14  9:24     ` Wolfram Sang
2011-06-14 11:55     ` Shawn Guo
2011-06-14 11:55       ` Shawn Guo
2011-06-14 12:02       ` Wolfram Sang
2011-06-14 12:02         ` Wolfram Sang
2011-06-14 12:24         ` Shawn Guo
2011-06-14 12:24           ` Shawn Guo
2011-06-10 10:42 ` [PATCH 2/4] mmc: sdhci-esdhc-imx: SDHCI_CARD_PRESENT does not get cleared Shawn Guo
2011-06-10 10:42   ` Shawn Guo
2011-06-14  9:22   ` Wolfram Sang
2011-06-14  9:22     ` Wolfram Sang
2011-06-10 10:42 ` [PATCH 3/4] mmc: sdhci-esdhc-imx: remove "WP" from flag ESDHC_FLAG_GPIO_FOR_CD_WP Shawn Guo
2011-06-10 10:42   ` Shawn Guo
2011-06-14  9:28   ` Wolfram Sang
2011-06-14  9:28     ` Wolfram Sang
2011-06-14 11:51     ` Shawn Guo
2011-06-14 11:51       ` Shawn Guo
2011-06-10 10:42 ` [PATCH 4/4] mmc: sdhci-esdhc-imx: extend card_detect and write_protect support Shawn Guo
2011-06-10 10:42   ` Shawn Guo
2011-06-11  9:30   ` Arnaud Patard
2011-06-11  9:30     ` Arnaud Patard (Rtp)
2011-06-11 11:50     ` Shawn Guo
2011-06-11 11:50       ` Shawn Guo
2011-06-11 11:59       ` Arnaud Patard
2011-06-11 11:59         ` Arnaud Patard (Rtp)
2011-06-11 13:16         ` Shawn Guo
2011-06-11 13:16           ` Shawn Guo
2011-06-11 19:21           ` Arnaud Patard
2011-06-11 19:21             ` Arnaud Patard (Rtp)
2011-06-14  6:47   ` [PATCH v2 4/4] mmc: sdhci-esdhc-imx: extend card_detect and write_protect support for mx5 Shawn Guo
2011-06-14  6:47     ` Shawn Guo
2011-06-14  9:51     ` Wolfram Sang
2011-06-14  9:51       ` Wolfram Sang
2011-06-14 13:06       ` Shawn Guo
2011-06-14 13:06         ` Shawn Guo
2011-06-14 13:55         ` Wolfram Sang
2011-06-14 13:55           ` Wolfram Sang
2011-06-15  3:10           ` Shawn Guo
2011-06-15  3:10             ` Shawn Guo
2011-06-15 10:33         ` Shawn Guo
2011-06-15 10:33           ` Shawn Guo
2011-06-15 10:44           ` Wolfram Sang
2011-06-15 10:44             ` Wolfram Sang
2011-06-14  6:48 ` [PATCH 0/4] Extend sdhci-esdhc-imx " Shawn Guo
2011-06-14  6:48   ` Shawn Guo
2011-06-14 11:13   ` Arnaud Patard
2011-06-14 11:13     ` Arnaud Patard (Rtp)
2011-06-14 11:39     ` Shawn Guo
2011-06-14 11:39       ` Shawn Guo
2011-06-14 13:12       ` Shawn Guo
2011-06-14 13:12         ` Shawn Guo
2011-06-14 14:29       ` Arnaud Patard
2011-06-14 14:29         ` Arnaud Patard (Rtp)
2011-06-15  3:13         ` Shawn Guo
2011-06-15  3:13           ` Shawn Guo
2011-06-16 18:32   ` Arnaud Patard [this message]
2011-06-16 18:32     ` Arnaud Patard (Rtp)
2011-06-20 10:41     ` Shawn Guo
2011-06-20 10:41       ` Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87lix1hbjy.fsf@lebrac.rtp-net.org \
    --to=arnaud.patard@rtp-net.org \
    --cc=cjb@laptop.org \
    --cc=eric@eukrea.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=patches@linaro.org \
    --cc=shawn.guo@freescale.com \
    --cc=w.sang@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.