From: Wolfram Sang <w.sang@pengutronix.de>
To: Pavel Machek <pma@sysgo.com>
Cc: Richard Zhu <richard.zhu@linaro.org>,
linux-arm-kernel@lists.infradead.org, cjb@laptop.org,
linux-mmc@vger.kernel.org, eric.miao@linaro.org,
kernel@pengutronix.de, avorontsov@ru.mvista.com, pba@sysgo.com
Subject: Re: [PATCH V2] mmc: Enable the ADMA on esdhc imx driver
Date: Thu, 16 Jun 2011 14:19:42 +0200 [thread overview]
Message-ID: <20110616121942.GD23579@pengutronix.de> (raw)
In-Reply-To: <20110616120629.GD31375@pma.sysgo.com>
[-- Attachment #1: Type: text/plain, Size: 946 bytes --]
On Thu, Jun 16, 2011 at 02:06:29PM +0200, Pavel Machek wrote:
> On Thu 2011-06-16 14:00:09, Wolfram Sang wrote:
> >
> > > Unfortunately register differences are common. Is there better
> > > approach than patching it in low level functions like this?
> >
> > I am all ears for suggestions...
>
> One way would be to move functions such as
>
> sdhci_activate_led()
>
> to the low level driver,
There is no "low level driver" if the controller is done right.
> and introduce functions such as write_host_control() -- with no
> corresponding read_host_control, so that translation is easy to do...
So, a seperate function for every register which differs from the
standard? There are a lot of SoCs out there, and even more to come...
Regards,
Wolfram
--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: w.sang@pengutronix.de (Wolfram Sang)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V2] mmc: Enable the ADMA on esdhc imx driver
Date: Thu, 16 Jun 2011 14:19:42 +0200 [thread overview]
Message-ID: <20110616121942.GD23579@pengutronix.de> (raw)
In-Reply-To: <20110616120629.GD31375@pma.sysgo.com>
On Thu, Jun 16, 2011 at 02:06:29PM +0200, Pavel Machek wrote:
> On Thu 2011-06-16 14:00:09, Wolfram Sang wrote:
> >
> > > Unfortunately register differences are common. Is there better
> > > approach than patching it in low level functions like this?
> >
> > I am all ears for suggestions...
>
> One way would be to move functions such as
>
> sdhci_activate_led()
>
> to the low level driver,
There is no "low level driver" if the controller is done right.
> and introduce functions such as write_host_control() -- with no
> corresponding read_host_control, so that translation is easy to do...
So, a seperate function for every register which differs from the
standard? There are a lot of SoCs out there, and even more to come...
Regards,
Wolfram
--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20110616/09c3d3da/attachment.sig>
next prev parent reply other threads:[~2011-06-16 12:19 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20110615082223.GA28798@atrey.karlin.mff.cuni.cz>
2011-06-16 11:51 ` [PATCH V2] mmc: Enable the ADMA on esdhc imx driver Pavel Machek
2011-06-16 11:51 ` Pavel Machek
2011-06-16 12:00 ` Wolfram Sang
2011-06-16 12:00 ` Wolfram Sang
2011-06-16 12:06 ` Pavel Machek
2011-06-16 12:06 ` Pavel Machek
2011-06-16 12:19 ` Wolfram Sang [this message]
2011-06-16 12:19 ` Wolfram Sang
[not found] ` <BANLkTi=JHnv+_HwkqR+LEq4no70abVKksw@mail.gmail.com>
2011-06-17 7:48 ` Wolfram Sang
2011-06-17 7:48 ` Wolfram Sang
2011-06-09 5:37 Richard Zhu
2011-06-09 5:37 ` Richard Zhu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110616121942.GD23579@pengutronix.de \
--to=w.sang@pengutronix.de \
--cc=avorontsov@ru.mvista.com \
--cc=cjb@laptop.org \
--cc=eric.miao@linaro.org \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mmc@vger.kernel.org \
--cc=pba@sysgo.com \
--cc=pma@sysgo.com \
--cc=richard.zhu@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.