All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gleb Natapov <gleb@redhat.com>
To: Avi Kivity <avi@redhat.com>
Cc: Daniel Gollub <gollub@b1-systems.de>,
	"Daniel P. Berrange" <berrange@redhat.com>,
	kvm@vger.kernel.org, qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [PATCH 0/2] Introduce panic hypercall
Date: Tue, 21 Jun 2011 12:03:48 +0300	[thread overview]
Message-ID: <20110621090348.GE491@redhat.com> (raw)
In-Reply-To: <4E005CBA.3000105@redhat.com>

On Tue, Jun 21, 2011 at 11:56:26AM +0300, Avi Kivity wrote:
> On 06/21/2011 11:41 AM, Gleb Natapov wrote:
> >On Tue, Jun 21, 2011 at 11:09:21AM +0300, Avi Kivity wrote:
> >>  On 06/21/2011 09:02 AM, Gleb Natapov wrote:
> >>  >On Mon, Jun 20, 2011 at 07:34:57PM +0300, Avi Kivity wrote:
> >>  >>   >The only two things which came to my mind are:
> >>  >>   >
> >>  >>   >    * NMI (aka. ipmitool diag) - already available in qemu/kvm - but requires
> >>  >>   >      in-guest kexec/kdump
> >>  >>   >    * Hardware-Watchdog (also available in qemu/libvirt)
> >>  >>
> >>  >>   A watchdog has the advantage that is also detects lockups.
> >>  >>
> >>  >And has disadvantage that all time base heuristics are bite us in the
> >>  >end.
> >>
> >>  The perf-based watchdog counts clocks-not-halted, not time, so it is
> >>  safe from time issues.
> >So it counts only instruction that guest actually executed? That's
> >perfect then. How much overhead it has in a guest though?
> 
> Should be pretty low, especially if the guest is idle.  There were
> some negative reports about the pmu From David Ahern, so it needs to
> be verified.
But it will be running not only when the guest is idle.

> 
> 
> >>                          We could make the hardware watchdog cheat in
> >>  the same way.
> >>
> >Something like steal time, but for watchdog. But this become complicated fast.
> >Watchdog emulation will have to move into kernel for starter.
> 
> Why?  You can use a performance counter from userspace.
> 
Heh, haven't thought about such way of implementing watchdog device.
But the same question again: what impact on performance constantly running
guest under perf is? Doesn't running guest under perf involve a lot of
NMIs (and hence vmexists)?

--
			Gleb.

WARNING: multiple messages have this Message-ID (diff)
From: Gleb Natapov <gleb@redhat.com>
To: Avi Kivity <avi@redhat.com>
Cc: Daniel Gollub <gollub@b1-systems.de>,
	qemu-devel <qemu-devel@nongnu.org>,
	kvm@vger.kernel.org
Subject: Re: [Qemu-devel] [PATCH 0/2] Introduce panic hypercall
Date: Tue, 21 Jun 2011 12:03:48 +0300	[thread overview]
Message-ID: <20110621090348.GE491@redhat.com> (raw)
In-Reply-To: <4E005CBA.3000105@redhat.com>

On Tue, Jun 21, 2011 at 11:56:26AM +0300, Avi Kivity wrote:
> On 06/21/2011 11:41 AM, Gleb Natapov wrote:
> >On Tue, Jun 21, 2011 at 11:09:21AM +0300, Avi Kivity wrote:
> >>  On 06/21/2011 09:02 AM, Gleb Natapov wrote:
> >>  >On Mon, Jun 20, 2011 at 07:34:57PM +0300, Avi Kivity wrote:
> >>  >>   >The only two things which came to my mind are:
> >>  >>   >
> >>  >>   >    * NMI (aka. ipmitool diag) - already available in qemu/kvm - but requires
> >>  >>   >      in-guest kexec/kdump
> >>  >>   >    * Hardware-Watchdog (also available in qemu/libvirt)
> >>  >>
> >>  >>   A watchdog has the advantage that is also detects lockups.
> >>  >>
> >>  >And has disadvantage that all time base heuristics are bite us in the
> >>  >end.
> >>
> >>  The perf-based watchdog counts clocks-not-halted, not time, so it is
> >>  safe from time issues.
> >So it counts only instruction that guest actually executed? That's
> >perfect then. How much overhead it has in a guest though?
> 
> Should be pretty low, especially if the guest is idle.  There were
> some negative reports about the pmu From David Ahern, so it needs to
> be verified.
But it will be running not only when the guest is idle.

> 
> 
> >>                          We could make the hardware watchdog cheat in
> >>  the same way.
> >>
> >Something like steal time, but for watchdog. But this become complicated fast.
> >Watchdog emulation will have to move into kernel for starter.
> 
> Why?  You can use a performance counter from userspace.
> 
Heh, haven't thought about such way of implementing watchdog device.
But the same question again: what impact on performance constantly running
guest under perf is? Doesn't running guest under perf involve a lot of
NMIs (and hence vmexists)?

--
			Gleb.

  reply	other threads:[~2011-06-21  9:03 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-20 13:38 [PATCH 0/2] Introduce panic hypercall Daniel Gollub
2011-06-20 13:38 ` [PATCH 1/2] Inroduce panic hypercall KVM_HC_PANIC (host) Daniel Gollub
2011-06-20 13:38 ` [PATCH 2/2] Call KVM_HC_PANIC if guest panics Daniel Gollub
2011-06-20 15:31 ` [PATCH 0/2] Introduce panic hypercall Avi Kivity
2011-06-20 15:38   ` Daniel P. Berrange
2011-06-20 15:45     ` Avi Kivity
2011-06-20 15:45       ` [Qemu-devel] " Avi Kivity
2011-06-20 15:59       ` Jan Kiszka
2011-06-20 15:59         ` [Qemu-devel] " Jan Kiszka
2011-06-20 16:26       ` Daniel Gollub
2011-06-20 16:26         ` [Qemu-devel] " Daniel Gollub
2011-06-20 16:34         ` Avi Kivity
2011-06-20 16:34           ` [Qemu-devel] " Avi Kivity
2011-06-20 17:13           ` Jan Kiszka
2011-06-20 17:13             ` [Qemu-devel] " Jan Kiszka
2011-06-20 17:23             ` Avi Kivity
2011-06-20 17:23               ` [Qemu-devel] " Avi Kivity
2011-06-21  6:04               ` Gleb Natapov
2011-06-21  6:04                 ` [Qemu-devel] " Gleb Natapov
2011-06-21  6:02           ` Gleb Natapov
2011-06-21  6:02             ` [Qemu-devel] " Gleb Natapov
2011-06-21  8:09             ` Avi Kivity
2011-06-21  8:09               ` [Qemu-devel] " Avi Kivity
2011-06-21  8:41               ` Gleb Natapov
2011-06-21  8:41                 ` [Qemu-devel] " Gleb Natapov
2011-06-21  8:56                 ` Avi Kivity
2011-06-21  8:56                   ` [Qemu-devel] " Avi Kivity
2011-06-21  9:03                   ` Gleb Natapov [this message]
2011-06-21  9:03                     ` Gleb Natapov
2011-06-21  9:07                     ` Avi Kivity
2011-06-21  9:07                       ` [Qemu-devel] " Avi Kivity
2011-06-21  9:30               ` shawn che
2011-06-21  9:30                 ` [Qemu-devel] " shawn che
2011-06-20 19:28   ` Anthony Liguori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110621090348.GE491@redhat.com \
    --to=gleb@redhat.com \
    --cc=avi@redhat.com \
    --cc=berrange@redhat.com \
    --cc=gollub@b1-systems.de \
    --cc=kvm@vger.kernel.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.