All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vasiliy Kulikov <segoon@openwall.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Ingo Molnar <mingo@elte.hu>,
	Andrew Morton <akpm@linux-foundation.org>,
	James Morris <jmorris@namei.org>,
	Namhyung Kim <namhyung@gmail.com>,
	Greg Kroah-Hartman <gregkh@suse.de>,
	kernel-hardening@lists.openwall.com,
	linux-kernel@vger.kernel.org,
	Linus Torvalds <torvalds@linux-foundation.org>
Subject: [kernel-hardening] Re: [PATCH v2] kernel: escape non-ASCII and control characters in printk()
Date: Mon, 27 Jun 2011 22:38:29 +0400	[thread overview]
Message-ID: <20110627183829.GA16033@albatros> (raw)
In-Reply-To: <20110627104058.45e93c41@pyx>

On Mon, Jun 27, 2011 at 10:40 +0100, Alan Cox wrote:
> 
> Go back and read what I said originally, and think about it.
> 
> You have to look at the IUTF bit of the relevant console you are logging
> to.

The knowledge of what specific console is relevant is unknown at the
moment of printk().  Do you approve only filtering on klogd side?

> But arbitarily blocking anything non ASCII is going to make a mess in
> anything non American. Even English needs UTF-8.

Sure, I don't propose it anymore (v2 goes without it).


Thanks,

-- 
Vasiliy Kulikov
http://www.openwall.com - bringing security into open computing environments

WARNING: multiple messages have this Message-ID (diff)
From: Vasiliy Kulikov <segoon@openwall.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Ingo Molnar <mingo@elte.hu>,
	Andrew Morton <akpm@linux-foundation.org>,
	James Morris <jmorris@namei.org>,
	Namhyung Kim <namhyung@gmail.com>,
	Greg Kroah-Hartman <gregkh@suse.de>,
	kernel-hardening@lists.openwall.com,
	linux-kernel@vger.kernel.org,
	Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH v2] kernel: escape non-ASCII and control characters in printk()
Date: Mon, 27 Jun 2011 22:38:29 +0400	[thread overview]
Message-ID: <20110627183829.GA16033@albatros> (raw)
In-Reply-To: <20110627104058.45e93c41@pyx>

On Mon, Jun 27, 2011 at 10:40 +0100, Alan Cox wrote:
> 
> Go back and read what I said originally, and think about it.
> 
> You have to look at the IUTF bit of the relevant console you are logging
> to.

The knowledge of what specific console is relevant is unknown at the
moment of printk().  Do you approve only filtering on klogd side?

> But arbitarily blocking anything non ASCII is going to make a mess in
> anything non American. Even English needs UTF-8.

Sure, I don't propose it anymore (v2 goes without it).


Thanks,

-- 
Vasiliy Kulikov
http://www.openwall.com - bringing security into open computing environments

  reply	other threads:[~2011-06-27 18:38 UTC|newest]

Thread overview: 59+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-23 15:21 [kernel-hardening] [PATCH v2] kernel: escape non-ASCII and control characters in printk() Vasiliy Kulikov
2011-06-23 15:21 ` Vasiliy Kulikov
2011-06-26 10:39 ` [kernel-hardening] " Ingo Molnar
2011-06-26 10:39   ` Ingo Molnar
2011-06-26 16:54   ` [kernel-hardening] " Vasiliy Kulikov
2011-06-26 16:54     ` Vasiliy Kulikov
2011-06-26 18:26     ` [kernel-hardening] " Ingo Molnar
2011-06-26 18:26       ` Ingo Molnar
2011-06-26 19:06       ` [kernel-hardening] " Vasiliy Kulikov
2011-06-26 19:06         ` Vasiliy Kulikov
2011-06-26 19:46         ` [kernel-hardening] " Ingo Molnar
2011-06-26 19:46           ` Ingo Molnar
2011-06-26 20:25           ` [kernel-hardening] " Vasiliy Kulikov
2011-06-26 20:25             ` Vasiliy Kulikov
2011-06-26 22:01             ` [kernel-hardening] " Ingo Molnar
2011-06-26 22:01               ` Ingo Molnar
2011-06-27  8:36               ` [kernel-hardening] " Vasiliy Kulikov
2011-06-27  8:36                 ` Vasiliy Kulikov
2011-06-27  9:20                 ` [kernel-hardening] " Vasiliy Kulikov
2011-06-27  9:20                   ` Vasiliy Kulikov
2011-06-27  9:40                 ` [kernel-hardening] " Alan Cox
2011-06-27  9:40                   ` Alan Cox
2011-06-27 18:38                   ` Vasiliy Kulikov [this message]
2011-06-27 18:38                     ` Vasiliy Kulikov
2011-06-28 19:30                     ` [kernel-hardening] " Linus Torvalds
2011-06-28 19:30                       ` Linus Torvalds
2011-07-01 12:00                       ` [kernel-hardening] " Ingo Molnar
2011-07-01 12:00                         ` Ingo Molnar
2011-07-01 12:54                         ` [kernel-hardening] " Vasiliy Kulikov
2011-07-01 14:20                           ` Alan Cox
2011-07-02 16:42                             ` Solar Designer
2011-07-02 16:42                               ` Solar Designer
2011-07-02 19:33                               ` [kernel-hardening] " Alan Cox
2011-07-02 19:33                                 ` Alan Cox
2011-07-02 20:34                                 ` [kernel-hardening] " Linus Torvalds
2011-07-02 20:34                                   ` Linus Torvalds
2011-07-01 14:37                       ` [kernel-hardening] " Vasiliy Kulikov
2011-07-01 14:37                         ` Vasiliy Kulikov
2011-07-01 14:49                         ` [kernel-hardening] " Alan Cox
2011-07-01 14:49                           ` Alan Cox
2011-07-02  8:10                           ` [kernel-hardening] " Vasiliy Kulikov
2011-07-02  8:10                             ` Vasiliy Kulikov
2011-07-02 15:08                             ` [kernel-hardening] " Greg KH
2011-07-02 15:08                               ` Greg KH
2011-07-03 10:01                           ` [kernel-hardening] " Vasiliy Kulikov
2011-07-03 10:01                             ` Vasiliy Kulikov
2011-07-03 11:42                             ` [kernel-hardening] " Vasiliy Kulikov
2011-07-03 11:42                               ` Vasiliy Kulikov
2011-07-03 12:23                             ` [kernel-hardening] " Alan Cox
2011-07-03 12:23                               ` Alan Cox
2011-07-03 17:42                             ` [kernel-hardening] " Linus Torvalds
2011-07-03 17:42                               ` Linus Torvalds
2011-07-03 21:10                               ` [kernel-hardening] " Alan Cox
2011-07-03 21:10                                 ` Alan Cox
2011-07-03 21:34                                 ` [kernel-hardening] " Linus Torvalds
2011-07-03 21:34                                   ` Linus Torvalds
2011-07-05 17:49                               ` [kernel-hardening] " Vasiliy Kulikov
2011-07-01 12:12                 ` Ingo Molnar
2011-07-01 12:12                   ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110627183829.GA16033@albatros \
    --to=segoon@openwall.com \
    --cc=akpm@linux-foundation.org \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=gregkh@suse.de \
    --cc=jmorris@namei.org \
    --cc=kernel-hardening@lists.openwall.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=namhyung@gmail.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.