From: Greg KH <gregkh@suse.de>
To: Vasiliy Kulikov <segoon@openwall.com>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>,
Linus Torvalds <torvalds@linux-foundation.org>,
Ingo Molnar <mingo@elte.hu>,
Andrew Morton <akpm@linux-foundation.org>,
James Morris <jmorris@namei.org>,
Namhyung Kim <namhyung@gmail.com>,
kernel-hardening@lists.openwall.com,
linux-kernel@vger.kernel.org
Subject: [kernel-hardening] Re: [PATCH v2] kernel: escape non-ASCII and control characters in printk()
Date: Sat, 2 Jul 2011 08:08:01 -0700 [thread overview]
Message-ID: <20110702150801.GA14453@suse.de> (raw)
In-Reply-To: <20110702081022.GA2755@albatros>
On Sat, Jul 02, 2011 at 12:10:22PM +0400, Vasiliy Kulikov wrote:
> Greg - do you know any devices supplying multibyte strings, but not in
> UTF-8 encoding? If yes, then CSI filtering is a bad idea :\
USB is "supposed" to have UTF-16 strings, but there's devices out there
that have crazy stuff in them. And of course, anyone can put anything
in the device string if they know how to write a bit of firmware, so we
have to watch out for that. Hopefully we handle that properly in the
usb_string() function in the kernel but review of it is always nice to
have.
Other than that, I don't know of any multi-byte strings in devices at
the moment. I haven't seen the Thunderbolt specs though, so who knows
what is coming next.
Hope this helps,
greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <gregkh@suse.de>
To: Vasiliy Kulikov <segoon@openwall.com>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>,
Linus Torvalds <torvalds@linux-foundation.org>,
Ingo Molnar <mingo@elte.hu>,
Andrew Morton <akpm@linux-foundation.org>,
James Morris <jmorris@namei.org>,
Namhyung Kim <namhyung@gmail.com>,
kernel-hardening@lists.openwall.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] kernel: escape non-ASCII and control characters in printk()
Date: Sat, 2 Jul 2011 08:08:01 -0700 [thread overview]
Message-ID: <20110702150801.GA14453@suse.de> (raw)
In-Reply-To: <20110702081022.GA2755@albatros>
On Sat, Jul 02, 2011 at 12:10:22PM +0400, Vasiliy Kulikov wrote:
> Greg - do you know any devices supplying multibyte strings, but not in
> UTF-8 encoding? If yes, then CSI filtering is a bad idea :\
USB is "supposed" to have UTF-16 strings, but there's devices out there
that have crazy stuff in them. And of course, anyone can put anything
in the device string if they know how to write a bit of firmware, so we
have to watch out for that. Hopefully we handle that properly in the
usb_string() function in the kernel but review of it is always nice to
have.
Other than that, I don't know of any multi-byte strings in devices at
the moment. I haven't seen the Thunderbolt specs though, so who knows
what is coming next.
Hope this helps,
greg k-h
next prev parent reply other threads:[~2011-07-02 15:08 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-23 15:21 [kernel-hardening] [PATCH v2] kernel: escape non-ASCII and control characters in printk() Vasiliy Kulikov
2011-06-23 15:21 ` Vasiliy Kulikov
2011-06-26 10:39 ` [kernel-hardening] " Ingo Molnar
2011-06-26 10:39 ` Ingo Molnar
2011-06-26 16:54 ` [kernel-hardening] " Vasiliy Kulikov
2011-06-26 16:54 ` Vasiliy Kulikov
2011-06-26 18:26 ` [kernel-hardening] " Ingo Molnar
2011-06-26 18:26 ` Ingo Molnar
2011-06-26 19:06 ` [kernel-hardening] " Vasiliy Kulikov
2011-06-26 19:06 ` Vasiliy Kulikov
2011-06-26 19:46 ` [kernel-hardening] " Ingo Molnar
2011-06-26 19:46 ` Ingo Molnar
2011-06-26 20:25 ` [kernel-hardening] " Vasiliy Kulikov
2011-06-26 20:25 ` Vasiliy Kulikov
2011-06-26 22:01 ` [kernel-hardening] " Ingo Molnar
2011-06-26 22:01 ` Ingo Molnar
2011-06-27 8:36 ` [kernel-hardening] " Vasiliy Kulikov
2011-06-27 8:36 ` Vasiliy Kulikov
2011-06-27 9:20 ` [kernel-hardening] " Vasiliy Kulikov
2011-06-27 9:20 ` Vasiliy Kulikov
2011-06-27 9:40 ` [kernel-hardening] " Alan Cox
2011-06-27 9:40 ` Alan Cox
2011-06-27 18:38 ` [kernel-hardening] " Vasiliy Kulikov
2011-06-27 18:38 ` Vasiliy Kulikov
2011-06-28 19:30 ` [kernel-hardening] " Linus Torvalds
2011-06-28 19:30 ` Linus Torvalds
2011-07-01 12:00 ` [kernel-hardening] " Ingo Molnar
2011-07-01 12:00 ` Ingo Molnar
2011-07-01 12:54 ` [kernel-hardening] " Vasiliy Kulikov
2011-07-01 14:20 ` Alan Cox
2011-07-02 16:42 ` Solar Designer
2011-07-02 16:42 ` Solar Designer
2011-07-02 19:33 ` [kernel-hardening] " Alan Cox
2011-07-02 19:33 ` Alan Cox
2011-07-02 20:34 ` [kernel-hardening] " Linus Torvalds
2011-07-02 20:34 ` Linus Torvalds
2011-07-01 14:37 ` [kernel-hardening] " Vasiliy Kulikov
2011-07-01 14:37 ` Vasiliy Kulikov
2011-07-01 14:49 ` [kernel-hardening] " Alan Cox
2011-07-01 14:49 ` Alan Cox
2011-07-02 8:10 ` [kernel-hardening] " Vasiliy Kulikov
2011-07-02 8:10 ` Vasiliy Kulikov
2011-07-02 15:08 ` Greg KH [this message]
2011-07-02 15:08 ` Greg KH
2011-07-03 10:01 ` [kernel-hardening] " Vasiliy Kulikov
2011-07-03 10:01 ` Vasiliy Kulikov
2011-07-03 11:42 ` [kernel-hardening] " Vasiliy Kulikov
2011-07-03 11:42 ` Vasiliy Kulikov
2011-07-03 12:23 ` [kernel-hardening] " Alan Cox
2011-07-03 12:23 ` Alan Cox
2011-07-03 17:42 ` [kernel-hardening] " Linus Torvalds
2011-07-03 17:42 ` Linus Torvalds
2011-07-03 21:10 ` [kernel-hardening] " Alan Cox
2011-07-03 21:10 ` Alan Cox
2011-07-03 21:34 ` [kernel-hardening] " Linus Torvalds
2011-07-03 21:34 ` Linus Torvalds
2011-07-05 17:49 ` [kernel-hardening] " Vasiliy Kulikov
2011-07-01 12:12 ` Ingo Molnar
2011-07-01 12:12 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110702150801.GA14453@suse.de \
--to=gregkh@suse.de \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=jmorris@namei.org \
--cc=kernel-hardening@lists.openwall.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=namhyung@gmail.com \
--cc=segoon@openwall.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.