From: Richard Weinberger <richard@nod.at>
To: vitalivanov@gmail.com
Cc: Jeff Dike <jdike@addtoit.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
user-mode-linux-devel@lists.sourceforge.net,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: [uml-devel] [PATCH 1/4] uml: cow_user.c warning corrections
Date: Tue, 5 Jul 2011 11:28:24 +0200 [thread overview]
Message-ID: <201107051128.25262.richard@nod.at> (raw)
In-Reply-To: <1309821341.4527.5.camel@vitaliy-Vostro-1400>
Am Dienstag 05 Juli 2011, 01:15:41 schrieb Vitaliy Ivanov:
> From 6201d3e862fca8670b206338dc90303ea0acc77d Mon Sep 17 00:00:00 2001
> From: Vitaliy Ivanov <vitalivanov@gmail.com>
> Date: Tue, 5 Jul 2011 01:57:51 +0300
> Subject: [PATCH 1/4] uml: cow_user.c warning corrections
> MIME-Version: 1.0
> Content-Type: text/plain; charset=UTF-8
> Content-Transfer-Encoding: 8bit
>
> arch/um/drivers/cow_user.c: In function ‘absolutize’:
> arch/um/drivers/cow_user.c:189:7: warning: ignoring return value of
> ‘chdir’, declared with attribute warn_unused_result
What compiler flags are you using?
Using the default settings this warning does not show up.
Most of the "ignoring return value" are totally useless.
> Signed-off-by: Vitaliy Ivanov <vitalivanov@gmail.com>
> ---
> arch/um/drivers/cow_user.c | 6 +++++-
> 1 files changed, 5 insertions(+), 1 deletions(-)
>
> diff --git a/arch/um/drivers/cow_user.c b/arch/um/drivers/cow_user.c
> index 93f227a..9cbb426 100644
> --- a/arch/um/drivers/cow_user.c
> +++ b/arch/um/drivers/cow_user.c
> @@ -186,7 +186,11 @@ static int absolutize(char *to, int size, char *from)
> strcat(to, "/");
> strcat(to, from);
> }
> - chdir(save_cwd);
> + if (chdir(save_cwd)) {
> + cow_printf("absolutize : Can't cd to '%s' - "
> + "errno = %d\n", save_cwd, errno);
> + return -1;
> + }
I don't think that this check is needed nor chdir() to save_cwd can fail.
Because we obtain it by calling getcwd() and never change it...
Thanks,
//richard
------------------------------------------------------------------------------
All of the data generated in your IT infrastructure is seriously valuable.
Why? It contains a definitive record of application performance, security
threats, fraudulent activity, and more. Splunk takes this data and makes
sense of it. IT sense. And common sense.
http://p.sf.net/sfu/splunk-d2d-c2
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel
WARNING: multiple messages have this Message-ID (diff)
From: Richard Weinberger <richard@nod.at>
To: vitalivanov@gmail.com
Cc: Jeff Dike <jdike@addtoit.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
user-mode-linux-devel@lists.sourceforge.net,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/4] uml: cow_user.c warning corrections
Date: Tue, 5 Jul 2011 11:28:24 +0200 [thread overview]
Message-ID: <201107051128.25262.richard@nod.at> (raw)
In-Reply-To: <1309821341.4527.5.camel@vitaliy-Vostro-1400>
Am Dienstag 05 Juli 2011, 01:15:41 schrieb Vitaliy Ivanov:
> From 6201d3e862fca8670b206338dc90303ea0acc77d Mon Sep 17 00:00:00 2001
> From: Vitaliy Ivanov <vitalivanov@gmail.com>
> Date: Tue, 5 Jul 2011 01:57:51 +0300
> Subject: [PATCH 1/4] uml: cow_user.c warning corrections
> MIME-Version: 1.0
> Content-Type: text/plain; charset=UTF-8
> Content-Transfer-Encoding: 8bit
>
> arch/um/drivers/cow_user.c: In function ‘absolutize’:
> arch/um/drivers/cow_user.c:189:7: warning: ignoring return value of
> ‘chdir’, declared with attribute warn_unused_result
What compiler flags are you using?
Using the default settings this warning does not show up.
Most of the "ignoring return value" are totally useless.
> Signed-off-by: Vitaliy Ivanov <vitalivanov@gmail.com>
> ---
> arch/um/drivers/cow_user.c | 6 +++++-
> 1 files changed, 5 insertions(+), 1 deletions(-)
>
> diff --git a/arch/um/drivers/cow_user.c b/arch/um/drivers/cow_user.c
> index 93f227a..9cbb426 100644
> --- a/arch/um/drivers/cow_user.c
> +++ b/arch/um/drivers/cow_user.c
> @@ -186,7 +186,11 @@ static int absolutize(char *to, int size, char *from)
> strcat(to, "/");
> strcat(to, from);
> }
> - chdir(save_cwd);
> + if (chdir(save_cwd)) {
> + cow_printf("absolutize : Can't cd to '%s' - "
> + "errno = %d\n", save_cwd, errno);
> + return -1;
> + }
I don't think that this check is needed nor chdir() to save_cwd can fail.
Because we obtain it by calling getcwd() and never change it...
Thanks,
//richard
next prev parent reply other threads:[~2011-07-05 9:28 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-04 23:15 [PATCH 1/4] uml: cow_user.c warning corrections Vitaliy Ivanov
2011-07-04 23:15 ` Vitaliy Ivanov
2011-07-05 9:28 ` Richard Weinberger [this message]
2011-07-05 9:28 ` Richard Weinberger
2011-07-05 11:10 ` Vitaliy Ivanov
2011-07-05 11:10 ` Vitaliy Ivanov
2011-07-05 11:31 ` Richard Weinberger
2011-07-05 11:31 ` Richard Weinberger
2011-07-05 11:38 ` Geert Uytterhoeven
2011-07-05 11:40 ` Richard Weinberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201107051128.25262.richard@nod.at \
--to=richard@nod.at \
--cc=akpm@linux-foundation.org \
--cc=jdike@addtoit.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=user-mode-linux-devel@lists.sourceforge.net \
--cc=vitalivanov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.