* [PATCH] frv: remove unnecessary code
@ 2011-06-16 16:44 Greg Dietsche
2011-07-09 15:29 ` Greg Dietsche
2011-07-20 2:03 ` Greg Dietsche
0 siblings, 2 replies; 4+ messages in thread
From: Greg Dietsche @ 2011-06-16 16:44 UTC (permalink / raw)
To: kernel-janitors
remove unnecessary code that matches this coccinelle pattern
if (...)
return ret;
return ret;
Signed-off-by: Greg Dietsche <Gregory.Dietsche@cuw.edu>
---
arch/frv/mm/pgalloc.c | 8 +-------
1 files changed, 1 insertions(+), 7 deletions(-)
diff --git a/arch/frv/mm/pgalloc.c b/arch/frv/mm/pgalloc.c
index c42c83d..4fb63a3 100644
--- a/arch/frv/mm/pgalloc.c
+++ b/arch/frv/mm/pgalloc.c
@@ -133,13 +133,7 @@ void pgd_dtor(void *pgd)
pgd_t *pgd_alloc(struct mm_struct *mm)
{
- pgd_t *pgd;
-
- pgd = quicklist_alloc(0, GFP_KERNEL, pgd_ctor);
- if (!pgd)
- return pgd;
-
- return pgd;
+ return quicklist_alloc(0, GFP_KERNEL, pgd_ctor);
}
void pgd_free(struct mm_struct *mm, pgd_t *pgd)
--
1.7.2.5
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] frv: remove unnecessary code
2011-06-16 16:44 [PATCH] frv: remove unnecessary code Greg Dietsche
@ 2011-07-09 15:29 ` Greg Dietsche
2011-07-20 2:03 ` Greg Dietsche
1 sibling, 0 replies; 4+ messages in thread
From: Greg Dietsche @ 2011-07-09 15:29 UTC (permalink / raw)
To: kernel-janitors
On Thu, Jun 16, 2011 at 11:44:20AM -0500, Greg Dietsche wrote:
> remove unnecessary code that matches this coccinelle pattern
> if (...)
> return ret;
> return ret;
>
> Signed-off-by: Greg Dietsche <Gregory.Dietsche@cuw.edu>
> ---
> arch/frv/mm/pgalloc.c | 8 +-------
> 1 files changed, 1 insertions(+), 7 deletions(-)
>
> diff --git a/arch/frv/mm/pgalloc.c b/arch/frv/mm/pgalloc.c
> index c42c83d..4fb63a3 100644
> --- a/arch/frv/mm/pgalloc.c
> +++ b/arch/frv/mm/pgalloc.c
> @@ -133,13 +133,7 @@ void pgd_dtor(void *pgd)
>
> pgd_t *pgd_alloc(struct mm_struct *mm)
> {
> - pgd_t *pgd;
> -
> - pgd = quicklist_alloc(0, GFP_KERNEL, pgd_ctor);
> - if (!pgd)
> - return pgd;
> -
> - return pgd;
> + return quicklist_alloc(0, GFP_KERNEL, pgd_ctor);
> }
>
> void pgd_free(struct mm_struct *mm, pgd_t *pgd)
> --
> 1.7.2.5
>
> --
Any feedback on this patch?
Thanks!
Greg
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] frv: remove unnecessary code
2011-06-16 16:44 [PATCH] frv: remove unnecessary code Greg Dietsche
2011-07-09 15:29 ` Greg Dietsche
@ 2011-07-20 2:03 ` Greg Dietsche
1 sibling, 0 replies; 4+ messages in thread
From: Greg Dietsche @ 2011-07-20 2:03 UTC (permalink / raw)
To: kernel-janitors
On 07/09/2011 10:29 AM, Greg Dietsche wrote:
> On Thu, Jun 16, 2011 at 11:44:20AM -0500, Greg Dietsche wrote:
>
>> remove unnecessary code that matches this coccinelle pattern
>> if (...)
>> return ret;
>> return ret;
>>
>> Signed-off-by: Greg Dietsche<Gregory.Dietsche@cuw.edu>
>> ---
>> arch/frv/mm/pgalloc.c | 8 +-------
>> 1 files changed, 1 insertions(+), 7 deletions(-)
>>
>> diff --git a/arch/frv/mm/pgalloc.c b/arch/frv/mm/pgalloc.c
>> index c42c83d..4fb63a3 100644
>> --- a/arch/frv/mm/pgalloc.c
>> +++ b/arch/frv/mm/pgalloc.c
>> @@ -133,13 +133,7 @@ void pgd_dtor(void *pgd)
>>
>> pgd_t *pgd_alloc(struct mm_struct *mm)
>> {
>> - pgd_t *pgd;
>> -
>> - pgd = quicklist_alloc(0, GFP_KERNEL, pgd_ctor);
>> - if (!pgd)
>> - return pgd;
>> -
>> - return pgd;
>> + return quicklist_alloc(0, GFP_KERNEL, pgd_ctor);
>> }
>>
>> void pgd_free(struct mm_struct *mm, pgd_t *pgd)
>> --
>> 1.7.2.5
>>
>> --
>>
> Any feedback on this patch?
>
> Thanks!
> Greg
>
>
adding trivial@kernel.org to the cc list since this is trivial and no
one has picked up this patch to date.
Greg
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] frv: remove unnecessary code
@ 2011-07-29 15:46 David Howells
0 siblings, 0 replies; 4+ messages in thread
From: David Howells @ 2011-07-29 15:46 UTC (permalink / raw)
To: torvalds, akpm; +Cc: linux-kernel, Greg Dietsche, David Howells
From: Greg Dietsche <Gregory.Dietsche@cuw.edu>
remove unnecessary code that matches this coccinelle pattern
if (...)
return ret;
return ret;
Signed-off-by: Greg Dietsche <Gregory.Dietsche@cuw.edu>
Signed-off-by: David Howells <dhowells@redhat.com>
---
arch/frv/mm/pgalloc.c | 8 +-------
1 files changed, 1 insertions(+), 7 deletions(-)
diff --git a/arch/frv/mm/pgalloc.c b/arch/frv/mm/pgalloc.c
index c42c83d..4fb63a3 100644
--- a/arch/frv/mm/pgalloc.c
+++ b/arch/frv/mm/pgalloc.c
@@ -133,13 +133,7 @@ void pgd_dtor(void *pgd)
pgd_t *pgd_alloc(struct mm_struct *mm)
{
- pgd_t *pgd;
-
- pgd = quicklist_alloc(0, GFP_KERNEL, pgd_ctor);
- if (!pgd)
- return pgd;
-
- return pgd;
+ return quicklist_alloc(0, GFP_KERNEL, pgd_ctor);
}
void pgd_free(struct mm_struct *mm, pgd_t *pgd)
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-07-29 15:46 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-06-16 16:44 [PATCH] frv: remove unnecessary code Greg Dietsche
2011-07-09 15:29 ` Greg Dietsche
2011-07-20 2:03 ` Greg Dietsche
-- strict thread matches above, loose matches on Subject: below --
2011-07-29 15:46 David Howells
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.