* [lm-sensors] Suggested additions to hwmon sysfs ABI
@ 2011-07-09 17:07 Guenter Roeck
2011-07-11 8:53 ` Jonathan Cameron
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Guenter Roeck @ 2011-07-09 17:07 UTC (permalink / raw)
To: lm-sensors
Hi all,
while adding support for more PMBus devices, I noticed that many of the chips
support attributes which are not currently available in the sysfs ABI.
Here is a (not necessarily complete) list.
---
Historic minimum attributes:
vout_min vin_min temp_min
MAX34440 x
MAX34441 x
LTC2978 x x x
Peak (historic maximum) attributes:
pin_peak vin_peak vout_peak iout_peak temp_peak
MAX34440 x x x
MAX34441 x x x
MAX8688 x x x
MAX16064 x x
ADM1275 x x x
ADM1276 x x x x
LTC2978 x x x
LM25066 x (1)
LM5064 x (1)
LM5066 x (1)
ZLxxxx (2) x (3)
Average attributes:
vin_avg vout_avg iin_avg pin_avg
LM25066 x x x x (1)
LM5064 x x x x (1)
LM5066 x x x x (1)
Notes:
1) In addition to instantaneous power measurements
2) All Intersil / Zilker Labs power management chips
3) Only available through SNAPSHOT command, which reads a total of 32 bytes.
Also see Intersil / Zilker Labs AN2033.
---
Based on this list, I suggest adding the following attributes to the ABI.
in[0-*]_input_lowest
in[0-*]_input_highest
in[0-*]_average
in[0-*]_reset_history
curr[1-*]_input_lowest
curr[1-*]_input_highest
curr[1-*]_average
curr[1-*]_reset_history
temp[1-*]_input_lowest
temp[1-*]_input_highest
temp[1-*]_average
temp[1-*]_reset_history
It might also be necessary to modify the sensors command to support both instantaneous
and average/peak power readings at the same time.
Thoughts/comments ?
Thanks,
Guenter
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [lm-sensors] Suggested additions to hwmon sysfs ABI
2011-07-09 17:07 [lm-sensors] Suggested additions to hwmon sysfs ABI Guenter Roeck
@ 2011-07-11 8:53 ` Jonathan Cameron
2011-07-11 12:42 ` Guenter Roeck
2011-07-11 14:32 ` Guenter Roeck
2 siblings, 0 replies; 4+ messages in thread
From: Jonathan Cameron @ 2011-07-11 8:53 UTC (permalink / raw)
To: lm-sensors
On 07/09/11 18:07, Guenter Roeck wrote:
> Hi all,
>
> while adding support for more PMBus devices, I noticed that many of the chips
> support attributes which are not currently available in the sysfs ABI.
>
> Here is a (not necessarily complete) list.
>
> ---
>
> Historic minimum attributes:
> vout_min vin_min temp_min
> MAX34440 x
> MAX34441 x
> LTC2978 x x x
>
> Peak (historic maximum) attributes:
>
> pin_peak vin_peak vout_peak iout_peak temp_peak
> MAX34440 x x x
> MAX34441 x x x
> MAX8688 x x x
> MAX16064 x x
> ADM1275 x x x
> ADM1276 x x x x
> LTC2978 x x x
> LM25066 x (1)
> LM5064 x (1)
> LM5066 x (1)
> ZLxxxx (2) x (3)
>
> Average attributes:
>
> vin_avg vout_avg iin_avg pin_avg
> LM25066 x x x x (1)
> LM5064 x x x x (1)
> LM5066 x x x x (1)
>
> Notes:
> 1) In addition to instantaneous power measurements
> 2) All Intersil / Zilker Labs power management chips
> 3) Only available through SNAPSHOT command, which reads a total of 32 bytes.
> Also see Intersil / Zilker Labs AN2033.
>
> ---
>
> Based on this list, I suggest adding the following attributes to the ABI.
>
> in[0-*]_input_lowest
> in[0-*]_input_highest
> in[0-*]_average
> in[0-*]_reset_history
>
> curr[1-*]_input_lowest
> curr[1-*]_input_highest
> curr[1-*]_average
> curr[1-*]_reset_history
>
> temp[1-*]_input_lowest
> temp[1-*]_input_highest
> temp[1-*]_average
> temp[1-*]_reset_history
>
> It might also be necessary to modify the sensors command to support both instantaneous
> and average/peak power readings at the same time.
How are you going to do peak power?
Otherwise, Looks sensible. Ran into this in IIO as well, we went with peak, but highest / lowest
works just as well. (not seen the minimum version yet)
>
> Thoughts/comments ?
>
> Thanks,
> Guenter
>
> _______________________________________________
> lm-sensors mailing list
> lm-sensors@lm-sensors.org
> http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
>
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [lm-sensors] Suggested additions to hwmon sysfs ABI
2011-07-09 17:07 [lm-sensors] Suggested additions to hwmon sysfs ABI Guenter Roeck
2011-07-11 8:53 ` Jonathan Cameron
@ 2011-07-11 12:42 ` Guenter Roeck
2011-07-11 14:32 ` Guenter Roeck
2 siblings, 0 replies; 4+ messages in thread
From: Guenter Roeck @ 2011-07-11 12:42 UTC (permalink / raw)
To: lm-sensors
On Mon, Jul 11, 2011 at 04:53:09AM -0400, Jonathan Cameron wrote:
[ ... ]
> >
> > Based on this list, I suggest adding the following attributes to the ABI.
> >
> > in[0-*]_input_lowest
> > in[0-*]_input_highest
> > in[0-*]_average
> > in[0-*]_reset_history
> >
> > curr[1-*]_input_lowest
> > curr[1-*]_input_highest
> > curr[1-*]_average
> > curr[1-*]_reset_history
> >
> > temp[1-*]_input_lowest
> > temp[1-*]_input_highest
> > temp[1-*]_average
> > temp[1-*]_reset_history
> >
> > It might also be necessary to modify the sensors command to support both instantaneous
> > and average/peak power readings at the same time.
> How are you going to do peak power?
>
power already has
power[1-*]_average
power[1-*]_input_highest
power[1-*]_input_lowest
power[1-*]_reset_history
Also, turns out that the following attributes for current sensors already exist.
curr[1-*]_average
curr[1-*]_lowest
curr[1-*]_highest
curr[1-*]_reset_history
curr_reset_history
so I decided to stick with that terminology and use it for voltage and temperature sensors
in my proposed patch.
> Otherwise, Looks sensible. Ran into this in IIO as well, we went with peak, but highest / lowest
> works just as well. (not seen the minimum version yet)
I thought about using peak too, but since lowest/highest is already used,
think it is better to stick with it.
Thanks,
Guenter
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [lm-sensors] Suggested additions to hwmon sysfs ABI
2011-07-09 17:07 [lm-sensors] Suggested additions to hwmon sysfs ABI Guenter Roeck
2011-07-11 8:53 ` Jonathan Cameron
2011-07-11 12:42 ` Guenter Roeck
@ 2011-07-11 14:32 ` Guenter Roeck
2 siblings, 0 replies; 4+ messages in thread
From: Guenter Roeck @ 2011-07-11 14:32 UTC (permalink / raw)
To: lm-sensors
On Mon, Jul 11, 2011 at 08:42:45AM -0400, Guenter Roeck wrote:
> On Mon, Jul 11, 2011 at 04:53:09AM -0400, Jonathan Cameron wrote:
> [ ... ]
> > >
> > > Based on this list, I suggest adding the following attributes to the ABI.
> > >
> > > in[0-*]_input_lowest
> > > in[0-*]_input_highest
> > > in[0-*]_average
> > > in[0-*]_reset_history
> > >
> > > curr[1-*]_input_lowest
> > > curr[1-*]_input_highest
> > > curr[1-*]_average
> > > curr[1-*]_reset_history
> > >
> > > temp[1-*]_input_lowest
> > > temp[1-*]_input_highest
> > > temp[1-*]_average
> > > temp[1-*]_reset_history
> > >
> > > It might also be necessary to modify the sensors command to support both instantaneous
> > > and average/peak power readings at the same time.
> > How are you going to do peak power?
> >
> power already has
>
> power[1-*]_average
> power[1-*]_input_highest
> power[1-*]_input_lowest
> power[1-*]_reset_history
>
> Also, turns out that the following attributes for current sensors already exist.
>
> curr[1-*]_average
> curr[1-*]_lowest
> curr[1-*]_highest
> curr[1-*]_reset_history
> curr_reset_history
>
Correction, the above existed for temperature sensors, and I added new attributes
for voltage and current.
Guenter
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-07-11 14:32 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-07-09 17:07 [lm-sensors] Suggested additions to hwmon sysfs ABI Guenter Roeck
2011-07-11 8:53 ` Jonathan Cameron
2011-07-11 12:42 ` Guenter Roeck
2011-07-11 14:32 ` Guenter Roeck
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.