* Re: [lm-sensors] RFC: Moving pmbus drivers into hwmon subdirectory
2011-07-12 2:12 [lm-sensors] RFC: Moving pmbus drivers into hwmon subdirectory Guenter Roeck
2011-07-12 6:38 ` Jean Delvare
@ 2011-07-14 11:52 ` Jean Delvare
2011-07-14 13:46 ` Guenter Roeck
2 siblings, 0 replies; 4+ messages in thread
From: Jean Delvare @ 2011-07-14 11:52 UTC (permalink / raw)
To: lm-sensors
On Tue, 12 Jul 2011 08:38:49 +0200, Jean Delvare wrote:
> On Mon, 11 Jul 2011 19:12:30 -0700, Guenter Roeck wrote:
> > Hi all,
> >
> > since the number of PMBus slave/client drivers keeps getting larger,
> > I have been wondering if I should move them into a separate subdirectory,
> > most likely drivers/hwmon/pmbus/.
> >
> > Any thoughts/comments about that ?
>
> Seems to be a good idea, yes.
Thinking some more about this... Does PMBus fit entirely in hwmon, or
does it cover additional functions? If it does cover additional
functions, then maybe drivers/pmbus would be a better place.
--
Jean Delvare
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [lm-sensors] RFC: Moving pmbus drivers into hwmon subdirectory
2011-07-12 2:12 [lm-sensors] RFC: Moving pmbus drivers into hwmon subdirectory Guenter Roeck
2011-07-12 6:38 ` Jean Delvare
2011-07-14 11:52 ` Jean Delvare
@ 2011-07-14 13:46 ` Guenter Roeck
2 siblings, 0 replies; 4+ messages in thread
From: Guenter Roeck @ 2011-07-14 13:46 UTC (permalink / raw)
To: lm-sensors
On Thu, Jul 14, 2011 at 07:52:24AM -0400, Jean Delvare wrote:
> On Tue, 12 Jul 2011 08:38:49 +0200, Jean Delvare wrote:
> > On Mon, 11 Jul 2011 19:12:30 -0700, Guenter Roeck wrote:
> > > Hi all,
> > >
> > > since the number of PMBus slave/client drivers keeps getting larger,
> > > I have been wondering if I should move them into a separate subdirectory,
> > > most likely drivers/hwmon/pmbus/.
> > >
> > > Any thoughts/comments about that ?
> >
> > Seems to be a good idea, yes.
>
> Thinking some more about this... Does PMBus fit entirely in hwmon, or
> does it cover additional functions? If it does cover additional
> functions, then maybe drivers/pmbus would be a better place.
>
Hi Jean,
The functionality implemented today is pure hwmon functionality and thus
belongs entirely into hwmon.
It may at some point be of interest to add regulator functionality.
If so, the way to do it would be to move generic (ie chip read/write code)
functionality to mfd and implement regulator and hwmon frontends.
I would be very hesitant to do that, though. First, I have not seen an actual
use case for it, and second it is extremely dangerous to change voltages,
and very easy to literally blow up a chip or even an entire board
if a chip is programmed with values it does not like (I have blown up
several of my test boards ;).
Guenter
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply [flat|nested] 4+ messages in thread