All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wu Fengguang <fengguang.wu@intel.com>
To: Raghavendra D Prabhu <rprabhu@wnohang.net>
Cc: "linux-mm@kvack.org" <linux-mm@kvack.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"akpm@linux-foundation.org" <akpm@linux-foundation.org>
Subject: Re: Re. Revised [PATCH 3/3] mm/readahead: Remove the check for ra->ra_pages
Date: Tue, 12 Jul 2011 11:09:55 -0700	[thread overview]
Message-ID: <20110712180955.GA12562@localhost> (raw)
In-Reply-To: <20110711230209.GA39196@Xye>

>  The check for ra->ra_pages is not required since fs like tmpfs which have
>  ra_pages set to 0 don't use filemap_fault as part of their VMA ops (it uses
>  shmem_fault). Also, page_cache_sync_readahead does its own check for ra_pages.
> 
>  Signed-off-by: Raghavendra D Prabhu <rprabhu@wnohang.net>

Acked-by: Wu Fengguang <fengguang.wu@intel.com>

Thank you!

WARNING: multiple messages have this Message-ID (diff)
From: Wu Fengguang <fengguang.wu@intel.com>
To: Raghavendra D Prabhu <rprabhu@wnohang.net>
Cc: "linux-mm@kvack.org" <linux-mm@kvack.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"akpm@linux-foundation.org" <akpm@linux-foundation.org>
Subject: Re: Re. Revised [PATCH 3/3] mm/readahead: Remove the check for ra->ra_pages
Date: Tue, 12 Jul 2011 11:09:55 -0700	[thread overview]
Message-ID: <20110712180955.GA12562@localhost> (raw)
In-Reply-To: <20110711230209.GA39196@Xye>

>  The check for ra->ra_pages is not required since fs like tmpfs which have
>  ra_pages set to 0 don't use filemap_fault as part of their VMA ops (it uses
>  shmem_fault). Also, page_cache_sync_readahead does its own check for ra_pages.
> 
>  Signed-off-by: Raghavendra D Prabhu <rprabhu@wnohang.net>

Acked-by: Wu Fengguang <fengguang.wu@intel.com>

Thank you!

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2011-07-12 18:09 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-09 19:41 [PATCH 0/3] Readahead fixes Raghavendra D Prabhu
2011-07-09 19:41 ` Raghavendra D Prabhu
2011-07-09 19:41 ` [PATCH 1/3] mm/readahead: Change the check for PageReadahead into an else-if Raghavendra D Prabhu
2011-07-09 19:41   ` Raghavendra D Prabhu
2011-07-09 20:47   ` Wu Fengguang
2011-07-09 20:47     ` Wu Fengguang
2011-07-09 19:41 ` [PATCH 2/3] mm/readahead: Remove file_ra_state from arguments of count_history_pages Raghavendra D Prabhu
2011-07-09 19:41   ` Raghavendra D Prabhu
2011-07-09 20:47   ` Wu Fengguang
2011-07-09 20:47     ` Wu Fengguang
2011-07-09 19:41 ` [PATCH 3/3] mm/readahead: Move the check for ra_pages after VM_SequentialReadHint() Raghavendra D Prabhu
2011-07-09 19:41   ` Raghavendra D Prabhu
2011-07-09 20:53   ` Wu Fengguang
2011-07-09 20:53     ` Wu Fengguang
2011-07-10 12:59     ` [TOME] " Raghavendra D Prabhu
2011-07-10 15:59       ` Wu Fengguang
2011-07-10 15:59         ` Wu Fengguang
2011-07-11 23:02         ` Re. Revised [PATCH 3/3] mm/readahead: Remove the check for ra->ra_pages Raghavendra D Prabhu
2011-07-11 23:02           ` Raghavendra D Prabhu
2011-07-12 18:09           ` Wu Fengguang [this message]
2011-07-12 18:09             ` Wu Fengguang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110712180955.GA12562@localhost \
    --to=fengguang.wu@intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=rprabhu@wnohang.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.