From: Arnd Bergmann <arnd@arndb.de>
To: Jiri Slaby <jslaby@suse.cz>
Cc: gregkh@suse.de, linux-serial@vger.kernel.org,
linux-kernel@vger.kernel.org, jirislaby@gmail.com,
Alan Cox <alan@linux.intel.com>
Subject: Re: [PATCH 3/3] TTY: serial, remove tasklet for tty_wakeup
Date: Tue, 12 Jul 2011 23:08:25 +0200 [thread overview]
Message-ID: <201107122308.26080.arnd@arndb.de> (raw)
In-Reply-To: <1310503400-28447-3-git-send-email-jslaby@suse.cz>
On Tuesday 12 July 2011 22:43:20 Jiri Slaby wrote:
> tty_wakeup can be called from any context. So there is no need to have
> an extra tasklet for calling that. Hence save some space and remove
> the tasklet completely.
>
> Signed-off-by: Jiri Slaby <jslaby@suse.cz>
> Cc: Greg Kroah-Hartman <gregkh@suse.de>
> Cc: Alan Cox <alan@linux.intel.com>
This is probably ok, but strictly speaking, we we cannot call
tty_wakeup from any context: not while holding the ldisc_mutex,
i.e. from ld->ops->{open,close}.
I don't see a reason why we would ever do that, but it's the
only explanation I have why the tasklet was introduced intially.
Arnd
next prev parent reply other threads:[~2011-07-12 21:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-12 20:43 [PATCH 1/3] TTY: serial, remove BTM from wait_until_sent Jiri Slaby
2011-07-12 20:43 ` [PATCH 2/3] TTY: msm_serial, remove unneeded console set Jiri Slaby
2011-07-12 20:43 ` [PATCH 3/3] TTY: serial, remove tasklet for tty_wakeup Jiri Slaby
2011-07-12 21:08 ` Arnd Bergmann [this message]
2011-07-12 21:25 ` [PATCH 1/3] TTY: serial, remove BTM from wait_until_sent Arnd Bergmann
2011-07-13 10:31 ` [PATCH 1/2] TTY: ami_serial, " Jiri Slaby
2011-07-13 10:31 ` [PATCH 2/2] TTY: remove tty_locked Jiri Slaby
2011-07-13 12:56 ` Arnd Bergmann
2011-07-14 12:18 ` Jiri Slaby
2011-07-14 12:18 ` Jiri Slaby
2011-07-13 12:56 ` [PATCH 1/2] TTY: ami_serial, remove BTM from wait_until_sent Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201107122308.26080.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=alan@linux.intel.com \
--cc=gregkh@suse.de \
--cc=jirislaby@gmail.com \
--cc=jslaby@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.